MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D91tXWjTt0AEzOyUbukmSMw9QA9+xoav7caddY_ig0C7w@mail.gmail.com>
References: 
 <CAM5-9D-ti4O0bE3W_=puMMWPjO4qR525gYfKuGSYAiGow-AZdQ@mail.gmail.com>
 <CA+OCxowGDMCf_YJauW=u24X_7X4XMnT5tkca4qMRZCpH8z2mDA@mail.gmail.com>
 <CAM5-9D8XX_BVPi2XQODAK5DPRrhi9sTMHQDh_KTu0p9FjkU=dQ@mail.gmail.com>
 <CA+OCxozBD1OBWQTG5SvdnVFipuScgK1nNaXUxazDSXqif_gtzQ@mail.gmail.com>
 <CAM5-9D8osVRFd4s9kps-Bnuqw53WPFT4TN8ayuOO0Hr5nzuwxA@mail.gmail.com>
 <CA+OCxowo2158=USKZ1nFvpogA4BO2R3UcHHC6xWzSsiGOdj6eg@mail.gmail.com>
 <CAM5-9D97YhGDXQZfOg+FBf0nDedQvydWH+mAmr2iRi0rOL9PSA@mail.gmail.com>
 <CA+OCxoyCJuY-Edh7K8uX8v9f+uYAS0YpQMmnzqPn5AZyY9WgKw@mail.gmail.com>
 <CAM5-9D-+uETwn4_LqHOGAwk46Wg6U-udSV_WrAy=FHnKwffhFA@mail.gmail.com>
 <CA+OCxowjCY1bvuBM3nZ8QpCkG2GxawCThLTjf9mg_VRHGCQaew@mail.gmail.com>
 <CAM5-9D_EPCFv4kYs_qaXpBNyDRQhANDCz+kgYikyf7-Xathg4w@mail.gmail.com>
 <CA+OCxowyX+RkvqiEQZ0BNn=iTUnyDTF3XXixEGnhsU8SwaTVCA@mail.gmail.com>
 <CAM5-9D91tXWjTt0AEzOyUbukmSMw9QA9+xoav7caddY_ig0C7w@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 25 Jan 2017 13:21:49 +0000
Message-ID: 
 <CA+OCxoyRKYCXg6BPUHSP+0OzecNmP-DxDa84xiDh+whS2rF95Q@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM1840 - cannot create gist
 index due to enforced ASC, DESC options in generated SQL
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks, patch applied.

On Fri, Jan 20, 2017 at 7:29 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi Dave,
>
> The last patch was for exclusion constraint only. The same issue issue is
> reported RM2061 for index.
> So, this patch takes care of both issues.
>
> Added a flag 'is_sort_nulls_applicable' which is set to true for access
> method 'btree'.
> If its is true, the values for options 'ASC/DESC' and 'NULLS' are included
> in 'create' sql for exclusion and index otherwise not.
>
> Please find updated patch and review.
>
> On Tue, Jan 17, 2017 at 3:43 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Tue, Jan 17, 2017 at 9:52 AM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>> > Hi
>> > On Tue, Jan 17, 2017 at 3:08 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Fri, Jan 13, 2017 at 6:50 AM, Surinder Kumar
>> >> <surinder.kumar@enterprisedb.com> wrote:
>> >> > Hi
>> >> >
>> >> > Please find updated patch following changes:
>> >> > 1) Keep field 'opclass' combo box enabled.
>> >>
>> >> That doesn't seem to be working.
>
> It is now fixed in the updated patch.
>>
>> >
>> > Is the field 'opclass' is not enabled for you?.
>>
>> No.
>>
>> > Can you please tell in which scenario it doesn't gets enabled? so that I
>> > can
>> > fix it.
>>
>> PostgreSQL 9.4, table:
>>
>> CREATE TABLE public.foo
>> (
>>     id text COLLATE pg_catalog."default" NOT NULL,
>>     data1 text COLLATE pg_catalog."default",
>>     CONSTRAINT foo_pkey1 PRIMARY KEY (id),
>>     CONSTRAINT gerp1 UNIQUE (id, data1)
>> )
>>
>> 1) Right-click, Create index
>>
>> 2) Name: xxxx
>>
>> 3) Access method: gist
>>
>> 4) Add column. Select id (note the opclass field is not enabled)
>>
>> 5) Add column. Select data1 (note the opclass field is not enabled).
>>
>> 6) Click save, and behold the following error in all it's glory :-)
>>
>> ERROR: data type text has no default operator class for access method
>> "gist"
>> HINT: You must specify an operator class for the index or define a
>> default operator class for the data type.
>
> Thanks for steps.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers