Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8VSC-0002y0-8q for pgadmin-hackers@arkaria.postgresql.org; Thu, 02 Jun 2016 16:26:40 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b8VSB-0003It-7A for pgadmin-hackers@arkaria.postgresql.org; Thu, 02 Jun 2016 16:26:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b8VRy-00034t-7N for pgadmin-hackers@postgresql.org; Thu, 02 Jun 2016 16:26:26 +0000 Received: from mail-it0-x234.google.com ([2607:f8b0:4001:c0b::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b8VRu-0004Tv-8A for pgadmin-hackers@postgresql.org; Thu, 02 Jun 2016 16:26:25 +0000 Received: by mail-it0-x234.google.com with SMTP id z189so115173198itg.0 for ; Thu, 02 Jun 2016 09:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=NeNksPJwelZcndzGmKkxrdP54EoDhsfnwGM50nIMy44=; b=Tk1jbYnb3CO4svNvQ4qyqurBhxlVcQI4Zq33PFLwN93BkYEjr0ASE0u13pRXaW7Z+x YLs9n+x5P4JJU0CHbAYzdkHOAVQKtgunwibipH1CSw+3rA/WwuVt0DUu4nIv4ogsNFds /kC4lYDmDMwPfJMQSOHl1RF+qukmCWAtEEgvwH1c+KIvri3p6tZIvGKcXhTF4rfUg56J ESXFgqjM6Y4tA9QQ5G7sVTC9F2fqL8ZeNVmA3nnvzFaJfMBQ2aJF2AEaWOB9PoGi7Bc5 NLX8OYuhGJiMU71fg4mGUFtMJ4Zw7dCY0TOWw2COeHDYjzryv2dNflZFA+qyKg32T4/4 mpOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=NeNksPJwelZcndzGmKkxrdP54EoDhsfnwGM50nIMy44=; b=EItoaxnWJjjy1oms+++fftQCQj+0tPFwTwd+CYpIwQYk/VNQ3Yvz8XNRnECyhrIyfs +yO2/SwxuYEr2z60sefM2S+SjFYDkW1TJZDSfsleecNcKeeEet49Gg111njLFvNSVbUs Qndo7ZtF8y89mpO6GpPdci+PsdtY9dbht9n5u68cJeTqpXW0s4gQU2Qycv6Q90kPkWzz 4IITFBRbadti2y8EJyh4kgv4OEEYmY3WZGLkBrfTQKqxhl+n9cqRHwvR8/7PPvvlP0s1 BJCavxY0ckdI4zdqdysaEYXu2ukSegkV2HfEjcOkSLJBt5yijlO5T3AYqUi8gLN2yRfY +qkQ== X-Gm-Message-State: ALyK8tK5qwuUOMd9YG5WN3Gqft691ip24ZZTe3QQ+iK9GBcf2/DQWQyo1g2L3cGz6HdiANO863ODXf51pPI2+pyO1hwpgmGJ3fzAH2xGkv7N1O/hfwEHVPNmPxjJcAdm0VW+qVQDmQq8fG2pWcNwDCl4s7MjLgdX6oj6AxOAduLN//qLeIvImLzm2G05c8Ru7zOnmkxi6Q== X-Received: by 10.36.127.1 with SMTP id r1mr4512001itc.52.1464884780108; Thu, 02 Jun 2016 09:26:20 -0700 (PDT) Received: from mail-it0-f46.google.com (mail-it0-f46.google.com. [209.85.214.46]) by smtp.gmail.com with ESMTPSA id u21sm2510950itc.1.2016.06.02.09.26.19 for (version=TLSv1/SSLv3 cipher=OTHER); Thu, 02 Jun 2016 09:26:19 -0700 (PDT) Received: by mail-it0-f46.google.com with SMTP id n126so2216865itd.1 for ; Thu, 02 Jun 2016 09:26:19 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.36.16.67 with SMTP id 64mr4593587ity.88.1464884778935; Thu, 02 Jun 2016 09:26:18 -0700 (PDT) Received: by 10.64.236.101 with HTTP; Thu, 2 Jun 2016 09:26:18 -0700 (PDT) In-Reply-To: References: Date: Thu, 2 Jun 2016 17:26:18 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: PATCH: pgAdmin4 debian installer From: Dave Page To: Paresh More Cc: Devrim Gunduz , pgadmin-hackers , Sandeep Thakkar , Hamid Quddus Content-Type: multipart/alternative; boundary=001a11445b18e2ee2405344e1090 X-Pg-Spam-Score: -1.5 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11445b18e2ee2405344e1090 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Devrim only works on Redhat, so I'll take a look at this myself. Thanks. BTW - I need the completed and working Windows build scripts tomorrow AM, my time! On Thu, Jun 2, 2016 at 5:16 PM, Paresh More wrote: > Hello Dave and Devrim, > > > Changes are done as per discussed with Sandeep. > > There are some python modules which are not available on ubuntu (through > apt-get) which is mentioned in the sheet here , We could find some packag= es > on web and the URLs of same have been updated in the sheet. For the > packages that are not available, we have to build them on our own. > > > https://docs.google.com/spreadsheets/d/13CIYR82twj0LIUteFSZR7RE8ZbtUfvCqy= kXw1wy3gzE/edit#gid=3D1213443181 > > > Attached is the patch for pgadmin4 debian package. I have also attached > runtime server patch separately (This is already included in the rpm patc= h > sent by Sandeep) > > > > > On Mon, May 9, 2016 at 6:45 PM, Dave Page > wrote: > >> Hi >> >> Please see my earlier comments regarding the RPM packages - many of them >> apply to this patch as well: >> http://www.postgresql.org/message-id/CA+OCxoxBDt82P75Q4Cy4fBkznkPBW3YJwP= z+wFARbBBSoi3fgg@mail.gmail.com >> >> By way of additional comment, why does pkg/deb/README include a bunch of >> boiler-plate text that I wrote long ago for the top-level README? It's o= ut >> of date now, and shouldn't be in a packaging README anyway. >> >> Thanks. >> >> On Tue, Apr 26, 2016 at 4:20 PM, Paresh More < >> paresh.more@enterprisedb.com> wrote: >> >>> Hi Team, Dave, >>> >>> debian package is located @ location >>> >>> pgadmin4-web >>> >>> https://uploads.enterprisedb.com/download.php?file=3D0196f693811b57088d= a5ed7396cec284 >>> >>> pgadmin4-runtime >>> >>> https://uploads.enterprisedb.com/download.php?file=3D958528f7c619efa7b4= 83a6d2e0c23cd5 >>> >>> Attached herewith are two patches. >>> >>> pgadmin4_debian.patch - This is the main patch that includes >>> Makefile,README,debian scripts >>> >>> It will create two .deb i.e pgadmin4-runtime and pgadmin4-web. >>> The pgadmin4-runtime depends on web and the web debian depends on the >>> python packages. >>> I have listed some packages which are not available on some systems so >>> that Devrim can build them. >>> >>> The installation path for pgadmin4 is "/usr/pgadmin4/." >>> and pgadmin4-web is the site-packages/pgadmin4-web >>> >>> As per rpm patch (*sandeep mentioned*) below is the comment which >>> applies same for debian. >>> >>> *pgadmin4-server-ini.patch* - This is the patch for runtime/Server.cpp. >>> As said pgadmin4-web and runtime installation directories are different= and >>> that means web does not exists in parallel to runtime like in sources. >>> >>> *Sandeep comments* >>> >>> *=E2=80=9CI observed that the location of application settings was not = defined >>> in* >>> *Server.cpp. As per QSettings doc, the default location on Unix is the* >>> *$HOME/.config//.conf. Here, $HOME depends on the >>> user* >>> *that runs the application. So, I thought why not to define the >>> application* >>> *settings in application directory itself. RPM then knows where to >>> define* >>> *the ApplicationPath. I tested it and it worked fine with me. I haven't >>> done* >>> *this change for platform dependent* >>> >>> *Another change that I did in this file is that, I observed that >>> canonicalPath()* >>> *was not giving the absolute path (by removing the sym link and the* >>> *redundant ".." as per doc). Hence, I used absolutePath() for the >>> paths[i]* >>> *that are relative (../web, etc) and not for the already absolute path >>> (ex.* >>> *ApplicationPath like /usr/lib/python2.7/site-packages/pgadmin4-web)=E2= =80=9D* >>> >>> What the patch will create ? >>> - It would create deb folder in pkg >>> - It would create Makefile, README and debian scripts >>> >>> >>> -- >>> >>> Thanks & Regards >>> >>> *Paresh More* >>> >>> [image: NEW-EDB-logo-4c] >>> >>> Pune, India. >>> Cell : +919922000564 | www.enterprisedb.com >>> >> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > > > -- > > Thanks & Regards > > *Paresh More* > > [image: NEW-EDB-logo-4c] > > Pune, India. > Cell : +919922000564 | www.enterprisedb.com > --=20 Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --001a11445b18e2ee2405344e1090 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Devrim only works on Redhat, so I'll take a look at th= is myself.

Thanks.

BTW - I need= the completed and working Windows build scripts tomorrow AM, my time!

On Thu, Ju= n 2, 2016 at 5:16 PM, Paresh More <paresh.more@enterprisedb.com= > wrote:
H= ello Dave and Devrim,


Changes are done as= per discussed with Sandeep.

There are some python= modules which are not available on ubuntu (through apt-get) which is menti= oned in the sheet here , We could find some packages on web and the URLs of= same have been updated in the sheet. For the packages that are not availab= le, we have to build them on our own.



Attached is the p= atch for pgadmin4 debian package.=C2=A0 I have also attached runtime server= patch separately (This is already included in the rpm patch sent by Sandee= p)




On Mon, May 9, 2016 at 6:45 PM, Dave Page &l= t;dave.page= @enterprisedb.com> wrote:
<= div dir=3D"ltr">Hi

Please see my earlier comments regard= ing the RPM packages - many of them apply to this patch as well:=C2=A0http://www.postgresql= .org/message-id/CA+OCxoxBDt82P75Q4Cy4fBkznkPBW3YJwPz+wFARbBBSoi3fgg@mail.gm= ail.com

By way of additional comment, why does= pkg/deb/README include a bunch of boiler-plate text that I wrote long ago = for the top-level README? It's out of date now, and shouldn't be in= a packaging README anyway.

Thanks.

On Tue, Ap= r 26, 2016 at 4:20 PM, Paresh More <paresh.more@enterprisedb.co= m> wrote:
=
Hi Team, Dave,

debian package is located @ lo= cation

pgadmin4-web

pgadmin4-runti= me
=

Attached herewith are two patches.

=
pgadmin4_debian.patch - This is the main patch that includes Makefile,= README,debian scripts

It will create two .deb i.e = pgadmin4-runtime and pgadmin4-web.=C2=A0
The =C2=A0pgadmin4-runti= me depends on web and the web debian depends on the python packages.=C2=A0<= /div>
I have listed some packages which are not available on some syste= ms so that Devrim can build them.

The installation= path for pgadmin4 is "/usr/pgadmin4/<major>.<minor>"= and pgadmin4-web is the site-packages/pgadmin4-web

As per rpm patch (sandeep mentioned) below is the comment which ap= plies same for debian.

pgadm= in4-server-ini.patch=C2=A0- This is the patch for runtime/Server.cpp. A= s said pgadmin4-web and runtime installation directories are different and<= br>
that means web does not exists in parallel to runtime like in= sources.

Sandeep comments<= /b>

=E2=80=9CI observed that the location of ap= plication settings was not defined in
Server.cpp. As p= er QSettings doc, the default location on Unix is the
$HOM= E/.config/<companyname>/<appname>.conf. Here, $HOME depends on = the user
that runs the application. So, I thought why not = to define the application
settings in application director= y itself. RPM then knows where to define
the ApplicationPa= th. I tested it and it worked fine with me. I haven't done
this change for platform dependent

Another change that I did in this file is that, I observed that canonic= alPath()
was not giving the absolute path (by removing the= sym link and the
redundant ".." as per doc). He= nce, I used absolutePath() for the paths[i]
that are relat= ive (../web, etc) and not for the already absolute path (ex.
= ApplicationPath like /usr/lib/python2.7/site-packages/pgadmin4-web)=E2= =80=9D

What the patch will create ?
= - It would create deb folder in pkg=C2=A0
- It would create Makef= ile, README and debian scripts

=

--

Thanks & Regards

Paresh More

3D=

Pune, India.




<= font color=3D"#888888">--
Dave Page
VP, Chief Architect, Tools = & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreS= QL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


--

Thanks & Regards

Paresh More

3D"NEW-=

Pune, India.




--
=
Dave Page=
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Tw= itter: @pgsnake
--001a11445b18e2ee2405344e1090--