Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fVQWl-0000vX-3R for pgadmin-hackers@arkaria.postgresql.org; Tue, 19 Jun 2018 23:59:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fVQWj-0008Vh-Fz for pgadmin-hackers@arkaria.postgresql.org; Tue, 19 Jun 2018 23:59:09 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fVQWj-0008VR-2P for pgadmin-hackers@lists.postgresql.org; Tue, 19 Jun 2018 23:59:09 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fVQWf-00083R-Ss for pgadmin-hackers@postgresql.org; Tue, 19 Jun 2018 23:59:07 +0000 Received: by mail-wm0-x242.google.com with SMTP id 69-v6so3468101wmf.3 for ; Tue, 19 Jun 2018 16:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=szVFdwAv/NwKj3qs48tPX+lVmyTCeV/inV5yXN5Amg4=; b=Hd16Cc0gtJFBTAVBOkKtAZPwQIqRjktRigokdv1l//sZP5w1CSsYSXrwJHqcz7BCHF FMcqnNK8v383zrGJ5KeLpJozGY1tZPTnZG7xdxNabsjTpxq++Mq+ZaEFgs8ixX0ZVi5R GHwnE6BErKCi8zaZ0kTRLH8EwQ07zPVfrtuWju99eTBSHBRPVCSjbtIu1C3b1H1SunFv ksH0g8QLTfqdjzpKKqFiIkvEzHju2Iu2m9A0v/HPteFVG22WYRsItKwwT9GLroNIEsgR Eh7W3b+VSVVUA9hS6iNAtsF9kLZQpp8vIMeN4omBX2rEnIjcxWE5fsE0B8eG9ilE7+T7 qssw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=szVFdwAv/NwKj3qs48tPX+lVmyTCeV/inV5yXN5Amg4=; b=eh/iGRRqCNgBDd4VICtWPvzTlb3lUBVQZ3ri7VrYAa1/vI1USSPUf6mGCKaDwxVvTY oFYJdsjjIde2FXobTIA+CvRdHejgM/nlPOWIUAyYbguII29ZInLXM9cX3xOq0eOldHsK QDcAVUb56Z4uNaEhtT5LN2ev5WTzlVijeSYdoppcEHm3AwtxANjaWWS2+etkltBLswbo OvFsBI13vjzUiOh4XZgABD6PNI8dFEOKIBlXjlK5LRk01ZtErwxUndFh/NjC4W6LbL0A pHDvg+zNyG1FJOu8RTsequr3wGQ+JpN69KWQw7oHoHeN34c0zsfv8Wd5aYkkvazdpBIi 9dyg== X-Gm-Message-State: APt69E0tH+qhwH99+vX+H2xVlOsX7pkf2qvPa0qAnBJmQx2NSjql32mW VAACI4KdgxYgF4lXvecYUDCgB6YvvnfYDxG8IS/TMg== X-Google-Smtp-Source: ADUXVKJgC+POpMrW3WfwOUEZAcKaK/IFAY7taFNA/v8kg0RRa3M/QH5uEDUdT4L7/CmJYk9G5o5GId5gz1m6ujr7724= X-Received: by 2002:a1c:ec84:: with SMTP id h4-v6mr13832226wmi.154.1529452743213; Tue, 19 Jun 2018 16:59:03 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Tue, 19 Jun 2018 16:59:02 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 20 Jun 2018 00:59:02 +0100 Message-ID: Subject: Re: [pgadmin4][Patch]: Feature #3388 Allow to set the connection timeout on the server properties dialog To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000075d88f056f077786" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000075d88f056f077786 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Tue, Jun 19, 2018 at 12:18 PM, Akshay Joshi < akshay.joshi@enterprisedb.com> wrote: > Hi > > On Tue, Jun 19, 2018 at 2:11 PM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi >> >> On Mon, Jun 18, 2018 at 10:39 PM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, Jun 18, 2018 at 12:18 PM, Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch for Feature #3388 Allow to set the connection >>>> timeout on the server properties dialog. Please review it. >>>> >>> >>> I took a quick look at this and had some questions/comments: >>> >>> - Doc updates seem to be missing. >>> >> >> My bad, again I forgot to do that. Fixed in attached patch. >> >>> >>> - The timeout should be passed through to external utilities like >>> pg_dump/pg_restore. >>> >> >> I am not able to see any option to set the timeout for >> pg_dump/pg_restore. >> > > Fixed it by setting environment variable "PGCONNECT_TIMEOUT". > Attached is the new updated patch. > > >> >>> - Can/should the timeout be extended to the SSH tunnels? >>> >> >> No option to set the timeout, I have check the sshtunnel's >> documentation . >> >>> >>> - Any refactoring opportunities in the code you're touching? >>> >> >> Not seen any logic that can be refactored. >> >>> >>> Thanks. >>> >> >> Apart from above, I have found one issue in *datamodel.js* when >> setting the min value to 0 for input control, it didn't work. >> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000075d88f056f077786 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Tue, Jun 19, 2018 at 12:18 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi

On Tue, Jun 19, 2018 at 2:11 PM, Aksh= ay Joshi <akshay.joshi@enterprisedb.com> wr= ote:
= Hi

On Mon, Jun 18, 2018 at 10:39 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org><= /span> wrote:
Hi

= On Mon, Jun 18, 2018 at 12:18 PM, Akshay Joshi <akshay.joshi@e= nterprisedb.com> wrote:
Hi Hackers,

Attached is the patch for Feature #3388 Allow to set the connecti= on timeout on the server properties dialog. Please review it.

I took a quick look at this and had some= questions/comments:

- Doc updates seem to be miss= ing.

=C2=A0 = =C2=A0 My bad, again I forgot to do that. Fixed in attached patch.=C2=A0=C2= =A0

- The timeout should be passed= through to external utilities like pg_dump/pg_restore.

=C2=A0 =C2=A0I am not able to s= ee any option to set the timeout for pg_dump/pg_restore.
<= /div>

=C2=A0 =C2=A0 =C2=A0 Fixed it = by setting environment variable "PGCONNECT_TIMEOUT". Attached is = the new updated patch.
=C2=A0
<= div class=3D"gmail_quote">

- Can/shoul= d the timeout be extended to the SSH tunnels?

=C2=A0 =C2=A0 =C2=A0No option to set the = timeout, I have check the sshtunnel's=C2=A0docum= entation.

- Any refactoring op= portunities in the code you're touching?

=C2=A0 =C2=A0 Not seen any logic that can = be refactored.=C2=A0

Thanks.

=C2=A0 =C2=A0Apart from above, I have found one issue in datamodel.js=C2=A0when setting = the min value to 0 for input control, it didn't work.=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y



--
Akshay Joshi
Sr. Software Architect


= Phone: +91 20-3058-9517
Mobile: +91 976-78= 8-8246



<= /div>--
Akshay Joshi
Sr. Software Architect
<= /font>

=

Phone: +91 20-3058= -9517
Mobile: +91 976-788-8246
=



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--00000000000075d88f056f077786--