Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7gq0-0003vg-90 for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 11:28:24 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d7gpz-0004sA-RX for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 11:28:23 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d7gpx-0004qU-QP for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 11:28:22 +0000 Received: from mail-io0-x22e.google.com ([2607:f8b0:4001:c06::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d7gpu-0001LJ-Gh for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 11:28:20 +0000 Received: by mail-io0-x22e.google.com with SMTP id o12so19477389iod.3 for ; Mon, 08 May 2017 04:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QbEC4MVpb08OxcmPhxcfCclX5ldQH9UTZtP3x+lKB/c=; b=pzsdWkOetS8SaaTBdb5Rq0QM2TfZTE9nsz+LRT8HmC44zuuVi1/n8qxXnrgvzccT55 ijZlC+QfjW9zvq0ATCoMayja3utDVQneNZvtoYhtL/k/l89heM1Xn8GDnbE0C5Hg1+Xi 1MOlFdaID5CCf8fmhCfKC/lZD1K2Niv1WIvGiaOnPEk5nZIUWMCu9RZg4v1iMgGjGhCf Uzvf2itSE9jo0GmfFahGehJCIdPupsnaepGyRlOOjqe8UT465Me046FWwzCr4NBr1yOV lazE5bhhrm9pVv4SyDdxFK5ZVhLoXSQEKaldo19ufvFfura/wfGhcmCZ3SschTyVrKq/ x+7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QbEC4MVpb08OxcmPhxcfCclX5ldQH9UTZtP3x+lKB/c=; b=lAf6RDKi74J1hXY1qqHRlUSklIhOPFW6MOZgm3zSbRo95cGeFnMIimfts0ndEdnfmB sRRG3FJuPK8gNzFYDSYwBFHvd/tKePt9hIsZTR8KARuAY1ZzKFq2sFGtFyexR20bcvPd 3fSzr/SCZkigyg5YogiqwR6aTaREIL+OjOl47GZKT0bPPql8XmHCNH/h6ZLacu4xDq8X VxzKyaVtc0AMmNjMxBVc/pTz3Tf9RFW0eE4DvBoFN60gBjweEElBoOmoCn1rppdSMXAk V2I2z32DawQilXOcc50Ic+3UaoyM2ZZOW3D6bS4xw9XQ4OrmSkHNIYNWdt/z8lm54y/M sVdQ== X-Gm-Message-State: AODbwcDgIql1NcELguobM78Wb+68fN/m1eXy7/Crt+7rr5M1w6VUUJSU 2Dz0TYP2TnGKPZAUhye29aEeoxQI0w== X-Received: by 10.107.3.165 with SMTP id e37mr2262214ioi.232.1494242897193; Mon, 08 May 2017 04:28:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Mon, 8 May 2017 04:28:16 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 8 May 2017 12:28:16 +0100 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Akshay Joshi Cc: Robert Eckhardt , Sarah McAlear , Joao Pedro De Almeida Pereira , Ashesh Vashi , pgadmin-hackers , Matthew Kleiman Content-Type: multipart/alternative; boundary=001a113ed3be188220054f018996 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113ed3be188220054f018996 Content-Type: text/plain; charset=UTF-8 Hi On Mon, May 8, 2017 at 12:24 PM, Akshay Joshi wrote: > Hi All > > I have reviewed the code and have following questions: > > - Why do we have empty __init__.py file in sql and templates/ > folder. In this patch we have couple of occurrences one of them is web/ > pgadmin/browser/server_groups/servers/databases/schemas/table/templates/trigger > and web/pgadmin/browser/server_groups/servers/databases/schemas/table/ > templates/trigger/sql > > That was already answered up-thread: We added the __init__.py files into templates to convert them into packages so that the tests inside of them can be found by the test runner. > > - Why do we have tests folder inside sql folder as we already have > tests folder in respective module. For example we have tests folder in > *web/pgadmin/browser/server_groups/servers/databases/schemas/table/column *then > why do we need it in > *web/pgadmin/browser/server_groups/servers/databases/schemas/table/templates/column/sql/tests* > > That does seem like a valid concern to me. > Apart from above code looks good to me. > > On Mon, May 8, 2017 at 2:20 PM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> >> >> On Mon, May 8, 2017 at 1:46 PM, Dave Page wrote: >> >>> Akshay, as Ashesh is unavailable today, can you please review/commit >>> this ASAP? >>> >> >> Sure. >> >>> >>> Thanks. >>> >>> On Fri, May 5, 2017 at 1:18 PM, Dave Page wrote: >>> >>>> Can you get this polished off on Monday please Ashesh? >>>> >>>> On Thu, May 4, 2017 at 12:51 PM, Robert Eckhardt >>>> wrote: >>>> >>>>> All, >>>>> >>>>> This change in the xss testing is preventing our CI from going green >>>>> and is also preventing the Dependents and Dependencies tabs in Greenplum >>>>> from being useful. >>>>> >>>>> Can we either merge this or provide feedback as to what needs to >>>>> change so that it can be merged. >>>>> >>>>> Thank you >>>>> Rob >>>>> >>>>> On Tue, May 2, 2017 at 5:17 PM, Sarah McAlear >>>>> wrote: >>>>> >>>>>> Hi Hackers & Ashesh! >>>>>> >>>>>> Is there anything else we can do for this? >>>>>> >>>>>> Thanks! >>>>>> Matt & Sarah >>>>>> >>>>>> On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira < >>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>> >>>>>>> Thanks for reviewing, Ashesh. >>>>>>> >>>>>>> We have updated the patch. The headers are all consistent and we >>>>>>> removed the __init__.py files in directories containing only .sql. >>>>>>> >>>>>>> Thanks! >>>>>>> Joao & Matt >>>>>>> >>>>>>> On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira < >>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>> >>>>>>>> Hello Ashesh, >>>>>>>> >>>>>>>> Thanks for reviewing the patch. >>>>>>>> >>>>>>>> We added the __init__.py files into templates to convert them into >>>>>>>> packages so that the tests inside of them can be found by the test runner. >>>>>>>> >>>>>>>> Thanks! >>>>>>>> Joao & Sarah >>>>>>>> >>>>>>>> On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi < >>>>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Ashesh, can you review/commit this please? >>>>>>>>>> >>>>>>>>>> On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < >>>>>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Hackers, >>>>>>>>>>> >>>>>>>>>>> We found out that when you are connected to a GreenPlum database >>>>>>>>>>> and try to get Dependents and Dependencies of an object the application was >>>>>>>>>>> returning a SQL error. >>>>>>>>>>> >>>>>>>>>>> This patch splits the SQL query used to retrieve the Dependents, >>>>>>>>>>> Dependencies, and Roles SQL file into multiple versioned files. >>>>>>>>>>> Add Unit Tests for each file. >>>>>>>>>>> Also added __init__.py files to other test directories to run >>>>>>>>>>> the tests in them. >>>>>>>>>>> >>>>>>>>>> Hi Joao & Sarah, >>>>>>>>> >>>>>>>>> Why do we need to add __init__.py in the template directory? >>>>>>>>> I didn't understand the purpose of the adding __init__.py files in >>>>>>>>> the template directories. >>>>>>>>> >>>>>>>>> NOTE: The headers in those files are not consistent with the other >>>>>>>>> project files. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> Thanks & Regards, >>>>>>>>> >>>>>>>>> Ashesh Vashi >>>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>>>> >>>>>>>>> >>>>>>>>>> Add ORDER BY into Copy Selection Feature test to ensure the >>>>>>>>>>> results are retrieved always in the same order >>>>>>>>>>> Renamed the Scenario of the xss_checks_pgadmin_debugger_test >>>>>>>>>>> and skip it for versions less than 9.1 >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> >>>>>>>>>>> Joao & Sarah >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>>>> To make changes to your subscription: >>>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>> Twitter: @pgsnake >>>>>>>>>> >>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.or >>>>>>> g) >>>>>>> To make changes to your subscription: >>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 >> <+91%2097678%2088246>* >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113ed3be188220054f018996 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

On Mon, May 8, 2017 at 12:24 PM, Akshay Joshi <<= a href=3D"mailto:akshay.joshi@enterprisedb.com" target=3D"_blank">akshay.jo= shi@enterprisedb.com> wrote:
Hi All

I have revi= ewed the code and have following questions:
  • Why do we hav= e empty __init__.py file in sql and templates/<modul= e> folder. In this patch we have couple of occurrences one of them is we= b/pgadmin/browser/s= erver_groups/servers/databases/schemas/table/templates/trigger and=C2=A0=C2=A0web/pgadmin/browse= r/server_groups/servers/databases/schemas/table/templates/trigger/sql
That was already answered up-thread:=C2=A0We added the __init__.py files into templates to convert them in= to packages so that the tests inside of them can be found by the test runne= r.
  • Why do we have tests folder inside sql folder as we already have tests f= older in respective module. For example we have tests folder in=C2=A0web= /pgadmin/browser/se= rver_groups/servers/databases/schemas/table/column=C2=A0then why do we need it i= n=C2=A0web/pgadmin/browser/server_groups/servers/databases/schemas/table/templates/column/sql/tests
That does seem like a valid concern to me.
=C2=A0
Apart from above code looks good to me.
On Mon, May 8, 2017 at 2:20 PM, Akshay Joshi <= span dir=3D"ltr"><akshay.joshi@enterprisedb.com> wrote:


On Mon, May 8, 20= 17 at 1:46 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, as As= hesh is unavailable today, can you please review/commit this ASAP?

=C2=A0 =C2=A0 Sure.=C2=A0

Thanks.
=

On Fri, May 5, 2017 at 1:18= PM, Dave Page <dpage@pgadmin.org> wrote:
Can you get this polish= ed off on Monday please Ashesh?

On Thu, May 4, 2017 at 12= :51 PM, Robert Eckhardt <reckhardt@pivotal.io> wrote:
=
All,=C2= =A0

This change in the xss testing is preventing our CI = from going green and is also preventing the=C2=A0Dependents and Dependencie= s tabs in Greenplum from being useful.=C2=A0

Can w= e either merge this or provide feedback as to what needs to change so that = it can be merged.=C2=A0

Thank you
Rob

On Tue, M= ay 2, 2017 at 5:17 PM, Sarah McAlear <smcalear@pivotal.io>= wrote:
Hi Hackers & Ashesh!

Is there anything else we can do fo= r this?

Thanks!
Matt & Sarah

On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeid= a Pereira <jdealmeidapereira@pivotal.io> wrote:
Thanks= for reviewing, Ashesh.

We have updated the patch. The h= eaders are all consistent and we removed the __init__.py files in directories containing only .sql.

Thanks!
<= div>Joao & Matt

On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almei= da Pereira <jdealmeidapereira@pivotal.io> wrote:<= br>
Hello= Ashesh,

Thanks for reviewing the patch.

<= div>We added the __init__.py files into templates to convert them into pack= ages so that the tests inside of them can be found by the test runner.

Thanks!
Joao & Sarah

On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Mon, Apr 24, 2017 at 4:43 = PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you review/c= ommit this please?

On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi = Hackers,

We found out that when you are connected to a G= reenPlum database and try to get Dependents and Dependencies of an object t= he application was returning a SQL error.

This pat= ch splits the SQL query used to retrieve the Dependents, Dependencies, and = Roles SQL file into multiple versioned files.
Add Unit Tests for = each file.
Also added __init__.py files to other test directories= to run the tests in them.
=
Hi Joao & Sarah,

Why do we need = to add __init__.py in the template directory?
I didn't unders= tand the purpose of the adding __init__.py files in the template directorie= s.

NOTE: The headers in those files are not consis= tent with the other project files.

--

Thanks & Regards,

Ashesh Vashi
Ente= rpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi

=
Add ORDER B= Y into Copy Selection Feature test to ensure the results are retrieved alwa= ys in the same order
Renamed the Scenario of the=C2=A0xss_checks_= pgadmin_debugger_test and skip it for versions less than 9.1

Thanks

Joao & Sarah


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave PageBlog: http://pg= snake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company





--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers






--
=
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company



--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL C= ompany



<= /div>--
Akshay Joshi
Principal Software Engineer=C2=A0

=
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Akshay Joshi
Princ= ipal Software Engineer=C2=A0





--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter= : @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgre= SQL Company
--001a113ed3be188220054f018996--