MIME-Version: 1.0
In-Reply-To: 
 <CA+OCxowBzhOaJf1_w1gPhOR4TH3bdtKBsdqETAqSwK0n2GWezg@mail.gmail.com>
References: 
 <CAE+jjakOhMJBMqsUaQuL9w4an0V4Q4nvY51K3GqWzm8jbj9cog@mail.gmail.com>
 <CA+OCxowBzhOaJf1_w1gPhOR4TH3bdtKBsdqETAqSwK0n2GWezg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 9 Feb 2018 12:29:05 +0000
Message-ID: 
 <CA+OCxoyT9yQU-ayjRa94UMaekGP7QhB3CNqaJ_A-j8t+4Jb4FA@mail.gmail.com>
Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and
 Explain analyze plan an error is displayed
To: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="001a1146951ea6e1940564c6ac38"
Precedence: bulk

--001a1146951ea6e1940564c6ac38
Content-Type: text/plain; charset="UTF-8"

Hi Joao,

It looks like Jenkins has taken umbrage to this change, at least with
Python 3.x. Can you take a look please?

https://jenkins.pgadmin.org/

Thanks.

On Fri, Feb 9, 2018 at 11:54 AM, Dave Page <dpage@pgadmin.org> wrote:

> Thanks, patches applied.
>
> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira <
> jdealmeidapereira@pivotal.io> wrote:
>
>> Hi Hackers,
>> This is quite a big patch in order to solve the problem with the Explain
>> Plan.
>>
>> We sent 2 patches that have the following:
>> *- update-javascript-packages.diff *
>>     Add package:
>>      is-docker to select a specific setting when running the Chrome tests
>> in
>>      Docker
>>
>>     Upgrade the version of:
>>     - babel-loader
>>     - extract-text-webpack-plugin
>>     - jasmine-core
>>     - jasmine-enzyme
>>     - moment
>> *- explain-plan-greenplum.diff*
>>   Extract SQLEditor.execute and SQLEditor._poll into their own files and
>> add test around them
>>   Extract SQLEditor backend functions that start executing query to their
>> own files and add tests around it
>>   Move the Explain SQL from the front-end and now pass the Explain plan
>> parameters as a JSON object in the start query call.
>>   Extract the compile_template_name into a function that can be used by
>> the different places that try to select the version of the template and the
>> server type
>>
>>
>> Thanks
>> Joao
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1146951ea6e1940564c6ac38
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Joao,<div><br></div><div>It looks like Jenkins has take=
n umbrage to this change, at least with Python 3.x. Can you take a look ple=
ase?</div><div><br></div><div><a href=3D"https://jenkins.pgadmin.org/">http=
s://jenkins.pgadmin.org/</a><br></div><div><br></div><div>Thanks.</div></di=
v><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Fri, Feb 9, =
2018 at 11:54 AM, Dave Page <span dir=3D"ltr">&lt;<a href=3D"mailto:dpage@p=
gadmin.org" target=3D"_blank">dpage@pgadmin.org</a>&gt;</span> wrote:<br><b=
lockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px =
#ccc solid;padding-left:1ex"><div dir=3D"ltr">Thanks, patches applied.</div=
><div class=3D"gmail_extra"><div><div class=3D"h5"><br><div class=3D"gmail_=
quote">On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira <span dir=
=3D"ltr">&lt;<a href=3D"mailto:jdealmeidapereira@pivotal.io" target=3D"_bla=
nk">jdealmeidapereira@pivotal.io</a>&gt;</span> wrote:<br><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex"><div dir=3D"ltr">Hi Hackers,<div>This is quite a big patch in=
 order to solve the problem with the Explain Plan.</div><div><br></div><div=
>We sent 2 patches that have the following:</div><div><b>-=C2=A0update-java=
script-packages.d<wbr>iff=C2=A0</b></div><div><div>=C2=A0 =C2=A0 Add packag=
e:<br></div><div>=C2=A0 =C2=A0 =C2=A0is-docker to select a specific setting=
 when running the Chrome tests in</div><div>=C2=A0 =C2=A0 =C2=A0Docker</div=
><div><br></div><div>=C2=A0 =C2=A0 Upgrade the version of:</div><div>=C2=A0=
 =C2=A0 - babel-loader</div><div>=C2=A0 =C2=A0 - extract-text-webpack-plugi=
n</div><div>=C2=A0 =C2=A0 - jasmine-core</div><div>=C2=A0 =C2=A0 - jasmine-=
enzyme</div><div>=C2=A0 =C2=A0 - moment</div></div><div><b>-=C2=A0explain-p=
lan-greenplum.diff</b></div><div>=C2=A0 Extract SQLEditor.execute and SQLEd=
itor._poll into their own files and add test around them</div><div>=C2=A0 E=
xtract SQLEditor backend functions that start executing query to their own =
files and add tests around it</div><div>=C2=A0 Move the Explain SQL from th=
e front-end and now pass the Explain plan parameters as a JSON object in th=
e start query call.</div><div>=C2=A0 Extract the compile_template_name into=
 a function that can be used by the different places that try to select the=
 version of the template and the server type</div><div><br></div><div><br><=
/div><div>Thanks</div><span class=3D"m_3573413969006416924HOEnZb"><font col=
or=3D"#888888"><div>Joao</div></font></span></div>
</blockquote></div><br><br clear=3D"all"><div><br></div></div></div><span c=
lass=3D"">-- <br><div class=3D"m_3573413969006416924gmail_signature" data-s=
martmail=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.b=
logspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: =
@pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" ta=
rget=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQ=
L Company<br></div>
</span></div>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><div class=
=3D"gmail_signature" data-smartmail=3D"gmail_signature">Dave Page<br>Blog: =
<a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.bl=
ogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http=
://www.enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a><=
br>The Enterprise PostgreSQL Company<br></div>
</div>

--001a1146951ea6e1940564c6ac38--