Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eviNf-0004qQ-E0 for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 11:46:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eviNd-0007zv-LH for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 11:46:09 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eviNc-0007zl-TK for pgadmin-hackers@lists.postgresql.org; Tue, 13 Mar 2018 11:46:09 +0000 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eviNV-00074p-3X for pgadmin-hackers@postgresql.org; Tue, 13 Mar 2018 11:46:07 +0000 Received: by mail-wr0-x244.google.com with SMTP id d10so9284920wrf.3 for ; Tue, 13 Mar 2018 04:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=m4g7xN/2LYXx7SlbtoJ/gkkKlt1DykM+a6/VSsjLWTo=; b=dWgHZ+igekCEkqSa0GpEf9kFIzIfqIIYrYQrVwbuZsYKgT1SM/bPwQA9cSWGd0cX+i 47duKwgiE9df2pC0RTuW9P0TPHohmMJSMo0a6QdEUXG1eUqTPl4V0Trz7yVrKJQm1CTp S+MOrAsnVntTiSQ7Q49BTHjXt337BF4G8fsZnp6cIt5eD6XIpBKokhhQCVsnu+6SmwmV hgUdCCzJm/3KNs5IROi8MG/lLW91PfVY46WyqrOspdem/Ow3m8BzD8bGdir9YsL9Ki9O cGaHfO0e2z4AbTAbIl3aD3M7c5XU/vtPBsVS/TjYW/Sb0qBTRttDWxa8i7jpwADQZcmk Q3mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=m4g7xN/2LYXx7SlbtoJ/gkkKlt1DykM+a6/VSsjLWTo=; b=n/elmrOANRfKM+Oo9tLPomMRoWP7oBHm08TnbiSfv8vBfG0vRGiSzjX+Lem+9yhNQi v3HhFzIoN5D2xYxpQ6aERacu+hAkMcw0QiDpay7LikMbnSe5moFSYOJmTbmrbBjp6rGO gSVFK/jt/NLuJnsQkQavq87iTAuOGehy4N6wDDBlK+4xJWaAa7E76h8xWO8HM2VGrmNi IRTNkldS7DjP/Cs8dYxYCsW5yAdPxxV3GqIw08APagDCA1fznh9nJP+cBBdgW+Wpa7ZL gHPM6pFZYiVGLms/8Hkpl2fhf/JV7cBrri7ds9hs9gU1qDcwrM9xB3IWq1J+LyEXoTFU 98+w== X-Gm-Message-State: AElRT7G5n5++uINfBpnYaRldGtZYr7kbdTw22/NgW7Nzq9vh9lgT32Je 7M+LFLbEXVWTfIwIM4F1Wz0wMDWSS6I6fYU11Y5Z6A== X-Google-Smtp-Source: AG47ELugXqzfyaLM41pDXcMKZX87xS+zY+ypbqmpy879mBM2GZhVRqruSiwigsGd3RxU7Wkh0BdhTnkkduOKN/Dn/+I= X-Received: by 10.223.176.98 with SMTP id g31mr314945wra.256.1520941558282; Tue, 13 Mar 2018 04:45:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Tue, 13 Mar 2018 04:45:57 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 13 Mar 2018 07:45:57 -0400 Message-ID: Subject: Re: [pgAdmin4][RM#3140] Add service parameter To: Murtuza Zabuawala Cc: Ashesh Vashi , Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113c9c404e55c9056749cdd7" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113c9c404e55c9056749cdd7 Content-Type: text/plain; charset="UTF-8" On Tue, Mar 13, 2018 at 12:12 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Ashesh, > > I haven't implemented that intentionally because Khushboo is working on > the same for SSL and our code will conflict, So once Khushboo's patch gets > committed, I'll make changes for Service file as well. > Ashesh is right - this should have been finished (and I should have thought about this issue). Please fix ASAP. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113c9c404e55c9056749cdd7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Mar 13, 2018 at 12:12 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi Ashesh,

I haven't implemented that intentionally because Khushboo= is working on the same for SSL and our code will conflict, So once Khushbo= o's patch gets committed, I'll make changes for Service file as wel= l.

Ashesh is right - this shoul= d have been finished (and I should have thought about this issue).

Please fix ASAP.

Thanks.
=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--001a113c9c404e55c9056749cdd7--