MIME-Version: 1.0
References: 
 <CANNh3aUNwnmYAAzFLL_vt1JRy9TH_TNXRtEHpBVZ9wYVytSdaA@mail.gmail.com>
In-Reply-To: 
 <CANNh3aUNwnmYAAzFLL_vt1JRy9TH_TNXRtEHpBVZ9wYVytSdaA@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 21 Jun 2019 09:24:08 +0100
Message-ID: 
 <CA+OCxoyT_yAJi6JysUv_m3PqcJkPEatxUURtrJcZK6AN7ccF=A@mail.gmail.com>
Subject: Re: change to Docker entrypoint.sh
To: Andrew Coleman <penguincoder@gmail.com>
Cc: pgadmin-hackers <pgadmin-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000700502058bd13090"
Precedence: bulk

--000000000000700502058bd13090
Content-Type: text/plain; charset="UTF-8"

Hi

On Thu, Jun 20, 2019 at 5:31 PM Andrew Coleman <penguincoder@gmail.com>
wrote:

> Hi All!
>
> I am new to this, so I apologize beforehand if it's not entirely kosher,
> but I have a proposed change to the Dockerfile entrypoint.sh to allow for
> configurable servers.json filename path.
>
> The reasoning behind this is that I have a Kubernetes deployment of
> pgadmin where I build a ConfigMap sort of dynamically. I can make the file
> appear in /pgadmin4, but it removes the contents of the directory for me
> (helpful!). Instead, I put it into a separate directory and set a new
> environment variable that defaults to the old pathname
> (backwards-compatible!) but allows me to set a custom environment variable
> in my custom Helm chart for my deployment.
>

pgAdmin removes the content of the directory? I'm not sure how it would do
that - it doesn't delete anything like that.


>
> The code is here:
>
> https://github.com/penguincoder/pgadmin4/commit/0865400385ac0d03bf69d183e8cd9aaec6dcf318
>
> Is this something that anyone is interested in?
>

Sure.


> Does it meet your coding standards?
>

Looks fine to me.


> What do I do next?
>
> I would love to move back to the "official" pgadmin container.
>

Please raise a feature request at
https://redmine.postgresql.org/projects/pgadmin4/issues/new and attach the
patch (just use git diff against a checkout of the master branch). You can
send the patch here, but  we need the feature request in the tracker
anyway, so it's probably easier to attach it there.

Thanks!


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000700502058bd13090
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Thu, Jun 20, 2019 at 5:31 PM Andrew =
Coleman &lt;<a href=3D"mailto:penguincoder@gmail.com">penguincoder@gmail.co=
m</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin=
:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"=
><div dir=3D"ltr"><div>Hi All!</div><div><br></div><div>I am new to this, s=
o I apologize beforehand if it&#39;s not entirely kosher, but I have a prop=
osed change to the Dockerfile entrypoint.sh to allow for configurable serve=
rs.json filename path.</div><div><br></div><div>The reasoning behind this i=
s that I have a Kubernetes deployment of pgadmin where I build a ConfigMap =
sort of dynamically. I can make the file appear in /pgadmin4, but it remove=
s the contents of the directory for me (helpful!). Instead, I put it into a=
 separate directory and set a new environment variable that defaults to the=
 old pathname (backwards-compatible!) but allows me to set a custom environ=
ment variable in my custom Helm chart for my deployment.</div></div></block=
quote><div><br></div><div>pgAdmin removes the content of the directory? I&#=
39;m not sure how it would do that - it doesn&#39;t delete anything like th=
at.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin=
:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"=
><div dir=3D"ltr"><div><br></div><div>The code is here:</div><div><a href=
=3D"https://github.com/penguincoder/pgadmin4/commit/0865400385ac0d03bf69d18=
3e8cd9aaec6dcf318" target=3D"_blank">https://github.com/penguincoder/pgadmi=
n4/commit/0865400385ac0d03bf69d183e8cd9aaec6dcf318</a></div><div><br></div>=
<div>Is this something that anyone is interested in?</div></div></blockquot=
e><div><br></div><div>Sure.</div><div>=C2=A0</div><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex"><div dir=3D"ltr"><div>Does it meet your coding sta=
ndards?<br></div></div></blockquote><div><br></div><div>Looks fine to me.</=
div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div=
 dir=3D"ltr"><div></div><div>What do I do next?</div><div><br></div><div>I =
would love to move back to the &quot;official&quot; pgadmin container.</div=
></div></blockquote><div><br></div><div>Please raise a feature request at=
=C2=A0<a href=3D"https://redmine.postgresql.org/projects/pgadmin4/issues/ne=
w">https://redmine.postgresql.org/projects/pgadmin4/issues/new</a>=C2=A0and=
 attach the patch (just use git diff against a checkout of the master branc=
h). You can send the patch here, but=C2=A0=C2=A0we need the feature request=
 in the tracker anyway, so it&#39;s probably easier to attach it there.</di=
v><div><br></div><div>Thanks!</div></div><br clear=3D"all"><div><br></div>-=
- <br><div dir=3D"ltr" class=3D"gmail_signature">Dave Page<br>Blog: <a href=
=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.=
com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.=
enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The =
Enterprise PostgreSQL Company<br></div></div>

--000000000000700502058bd13090--