MIME-Version: 1.0
References: 
 <CAFOhELcvULp8TPxOGw_C7eQ6dmq6ddo=HGifCSW0EpHqD+d64g@mail.gmail.com>
In-Reply-To: 
 <CAFOhELcvULp8TPxOGw_C7eQ6dmq6ddo=HGifCSW0EpHqD+d64g@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 12 Jul 2019 11:36:59 +0100
Message-ID: 
 <CA+OCxoyU9pdK6LNv+zQD14SkbFcwU0tHiCXND6kN8btMuqv_mg@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch] : RE-SQL tests for Collation node
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000356348058d797e88"
Precedence: bulk

--000000000000356348058d797e88
Content-Type: text/plain; charset="UTF-8"

Hi

On Fri, Jul 12, 2019 at 10:46 AM Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch for the RE-SQL tests for collation node.
> This patch also includes the *modified SQL tests* as well as fixes for
> the RE-SQL in the collation node which I found while implementing this.
>
> To add the modified SQL tests, 2 optional parameters are introduced in the
> JSON file, i.e.
> *msql_endpoint* and *expected_msql_file.*
> These parameters need to be included in the Alter scenarios.
>
> I have modified the RE-SQL framework to support modified SQL.
>

This fails on EPAS 9.4:

 ... 2019-07-12 11:35:09,672: ERROR flask.app: Failed to execute query
(execute_scalar) for the server #5 - DB:test_db_18bdb (Query-id: 9091709):
Error Message:ERROR:  role "postgres" does not exist

Create Collation... FAIL
Traceback (most recent call last):
  File
"/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
205, in execute_test_case
    self.assertEquals(response.status_code, 200)
  File
"/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
line 1338, in deprecated_func
    return original_func(*args, **kwargs)
  File
"/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
line 839, in assertEqual
    assertion_func(first, second, msg=msg)
  File
"/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py",
line 832, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: 500 != 200
ERROR

I guess we need to create a role first?

Also, please keep your error messages consistent with the others, e.g. "...
FAIL" instead of " ..................FAIL".

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000356348058d797e88
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Fri, Jul 12, 2019 at 10:46 AM Khushb=
oo Vashi &lt;<a href=3D"mailto:khushboo.vashi@enterprisedb.com">khushboo.va=
shi@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex"><div dir=3D"ltr">Hi,<div><br></div><div>Please find the=
 attached patch for the RE-SQL tests for collation node.</div><div>This pat=
ch also includes the <i>modified SQL tests</i> as well as fixes for the RE-=
SQL in the collation node which I found while implementing this.</div><div>=
<br></div><div>To add the modified SQL tests, 2 optional parameters are int=
roduced in the JSON file, i.e.</div><div><i><b>msql_endpoint</b></i> and <i=
><b>expected_msql_file.</b></i></div><div>These parameters need to be inclu=
ded in the Alter scenarios.</div><div><br></div><div>I have modified the RE=
-SQL framework to support modified SQL.</div></div></blockquote><div><br></=
div><div>This fails on EPAS 9.4:</div><div><br></div><div>=C2=A0... 2019-07=
-12 11:35:09,672: ERROR	flask.app:	Failed to execute query (execute_scalar)=
 for the server #5 - DB:test_db_18bdb (Query-id: 9091709):<br>Error Message=
:ERROR: =C2=A0role &quot;postgres&quot; does not exist<br><br>Create Collat=
ion... FAIL<br>Traceback (most recent call last):<br>=C2=A0 File &quot;/Use=
rs/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py&quot;, line=
 205, in execute_test_case<br>=C2=A0 =C2=A0 self.assertEquals(response.stat=
us_code, 200)<br>=C2=A0 File &quot;/opt/local/Library/Frameworks/Python.fra=
mework/Versions/3.7/lib/python3.7/unittest/case.py&quot;, line 1338, in dep=
recated_func<br>=C2=A0 =C2=A0 return original_func(*args, **kwargs)<br>=C2=
=A0 File &quot;/opt/local/Library/Frameworks/Python.framework/Versions/3.7/=
lib/python3.7/unittest/case.py&quot;, line 839, in assertEqual<br>=C2=A0 =
=C2=A0 assertion_func(first, second, msg=3Dmsg)<br>=C2=A0 File &quot;/opt/l=
ocal/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittes=
t/case.py&quot;, line 832, in _baseAssertEqual<br>=C2=A0 =C2=A0 raise self.=
failureException(msg)<br>AssertionError: 500 !=3D 200<br>ERROR<br></div><di=
v><br></div><div>I guess we need to create a role first?</div><div><br></di=
v><div>Also, please keep your error messages consistent with the others, e.=
g. &quot;... FAIL&quot; instead of &quot; ..................FAIL&quot;.</di=
v><div><br></div><div>Thanks!</div><div>=C2=A0</div></div>-- <br><div dir=
=3D"ltr" class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgs=
nake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twi=
tter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.c=
om" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise Pos=
tgreSQL Company<br></div></div>

--000000000000356348058d797e88--