Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bmhRp-0007Ra-Kr for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Sep 2016 13:20:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bmhRp-0006iF-6R for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Sep 2016 13:20:25 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bmhRo-0006i7-0N for pgadmin-hackers@postgresql.org; Wed, 21 Sep 2016 13:20:24 +0000 Received: from mail-it0-x22f.google.com ([2607:f8b0:4001:c0b::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bmhRj-000139-Qb for pgadmin-hackers@postgresql.org; Wed, 21 Sep 2016 13:20:22 +0000 Received: by mail-it0-x22f.google.com with SMTP id 186so49911158itf.0 for ; Wed, 21 Sep 2016 06:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZI4BvYYwMBQ0xm8JNLzksEUTENAfh9VFJBOFgTM6Oe0=; b=Lo0K88lwDd8ozhrldbeof8TdJqr7op8+AlyJAtZ6Nkt0yliPTGO1NFPI4rTi05vQBU 8+2R9xOur2g8rc2kBTdkiwVF73+A6s8VpVjjxC2bzbVoyxW6N4P1zelJdB0hK2CrfZWz yh6ASkov8J55RJC8/KBy1MS2DJrLgVC/Oejr947dG2woty6gTai6jCCht0h89CiOt+Qe JGFzpOuYXFzPS6KvhgIvn9hFELQa9ZQIFMQifdyDnzznyfO+X0Ae7OcUqbPwHm9p5bZC kuzWyMNytF9CbTV3TtVS2oUN/qUH/wy3bC9bWPJlOH3UDX1EiKrgNOkSGrkfO2WAL5RJ ZrqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZI4BvYYwMBQ0xm8JNLzksEUTENAfh9VFJBOFgTM6Oe0=; b=Xcv/7K2BKZrvyBlXyRqJ9pfl17/iKSbjwRIsUjOG2R3bo6C6oUH7TbA3QKfJFwrQgq EINAjn7hmdi0iYY9YSVitwxmqL6x8e730cC8si1MN7uj0VTb8htp2PX9YRmPs6GaM6Ca ibEExinW50NiMJx3odGpUX62F+Pte9mBCs4xDVwewzR0dhoNBEe1kCEglVDJifHuQ+uK DpIoi+agrDkKUvsU0TdBKuH5EXhvPdC64RykTeyOxn6FIUU0NgpsPTjNJpy8/IK0yHFZ blrWKdsGzsl7Zqwr3maGaNDxbUdN+v24jjgdwiM7PZB45fw+ZOCMdyvuYGdzb7358a8P +GJw== X-Gm-Message-State: AE9vXwNnVnDESyx8jN3rPih4B1Ny7RoSSnvrjObhww1Rm2XBKA6kDfFnOGah03HODUQq/YX0evLNNOCGZgX2Fg== X-Received: by 10.36.127.87 with SMTP id r84mr4084039itc.4.1474464018209; Wed, 21 Sep 2016 06:20:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Wed, 21 Sep 2016 06:20:17 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 21 Sep 2016 14:20:17 +0100 Message-ID: Subject: Re: Patch for RM1720 [pgadmin4] To: Harshal Dhumal Cc: pgadmin-hackers , Navnath Gadakh Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Hi On Wed, Sep 21, 2016 at 1:57 PM, Harshal Dhumal wrote: > Hi, > > PFA patch for RM1720 > > > Issue: In pgAdmin4 we use server id (sid, which is id of server table in > sqlite db) as key to keep track of server connection (server manger). But > sqlite reuses these ids and therefore pgadmin4 connection manager assigns > connection details of one database server to another in some cases. > > To avoid this issue we now deleting server connection details (server > manger) when user drops server. Looks like it still needs some work I'm afraid (though, I think the approach is correct). Here's what I get running the regression tests: Interestingly; the error seen when running the test against PG 9.4 isn't detected as a failure. Can you look at that aspect please Navnath? (pgadmin4)piranha:web dpage$ python regression/runtests.py pgAdmin 4 - Application Initialisation ====================================== The configuration database - '/Users/dpage/.pgadmin/test_pgadmin4.db' does not exist. Entering initial setup mode... NOTE: Configuring authentication for SERVER mode. The configuration database has been created at /Users/dpage/.pgadmin/test_pgadmin4.db =============Running the test cases for 'Regression - PG 9.4'============= runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase) This function will add database under 1st server of tree node. (Check Databases Node URL) ... ok runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase) This function will delete the database. (Check Databases Node URL) ... ok runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase) This function will fetch added database. (Check Databases Node URL) ... ok runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase) This function will update the comments field of database. (Check Databases Node) ... ok runTest (pgadmin.browser.server_groups.servers.tests.test_server_add.ServersAddTestCase) This function will add the server under default server group. (Default Server Node url) ... ok runTest (pgadmin.browser.server_groups.servers.tests.test_server_delete.ServerDeleteTestCase) This function deletes the added server (Default Server Node url) ... 2016-09-21 14:15:58,737: ERROR pgadmin: 'NoneType' object has no attribute 'release' Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py", line 355, in delete get_driver(PG_DEFAULT_DRIVER).delete_manager(sid) File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line 1729, in delete_manager manager.release() AttributeError: 'NoneType' object has no attribute 'release' ok runTest (pgadmin.browser.server_groups.servers.tests.test_server_get.ServersGetTestCase) This function will fetch the added servers to object browser. (Default Server Node url) ... ok runTest (pgadmin.browser.server_groups.servers.tests.test_server_put.ServerUpdateTestCase) This function update the server details (Default Server Node url) ... ok runTest (pgadmin.browser.server_groups.tests.test_sg_get.SgNodeTestCase) This function will check available server groups. (Check Server Group Node) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating Incorrect_New_Password) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating New_Password_Less_Than_Min_Length) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating Empty_New_Password) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating Incorrect_Current_Password) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Changing Valid_Password) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (TestCase for Checking Invalid_Password) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Empty_Password) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Empty_Email) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Empty_Credentials) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Invalid_Email) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Invalid_Credentials) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Valid_Credentials) ... ok runTest (pgadmin.browser.tests.test_logout.LogoutTest) This function checks the logout functionality. (Logging Out) ... ok runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) This function checks reset password functionality. (TestCase for Validating Empty Email) ... ok runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) This function checks reset password functionality. (TestCase for Validating Invalid_Email) ... ok runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) This function checks reset password functionality. (TestCase for Validating Valid_Email) ... ok ---------------------------------------------------------------------- Ran 25 tests in 11.024s OK =============Running the test cases for 'Regression - PG 9.5'============= runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase) This function will add database under 1st server of tree node. (Check Databases Node URL) ... ok runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase) This function will delete the database. (Check Databases Node URL) ... FAIL runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase) This function will fetch added database. (Check Databases Node URL) ... ERROR runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase) This function will update the comments field of database. (Check Databases Node) ... ERROR runTest (pgadmin.browser.server_groups.servers.tests.test_server_add.ServersAddTestCase) This function will add the server under default server group. (Default Server Node url) ... ok runTest (pgadmin.browser.server_groups.servers.tests.test_server_delete.ServerDeleteTestCase) This function deletes the added server (Default Server Node url) ... ok runTest (pgadmin.browser.server_groups.servers.tests.test_server_get.ServersGetTestCase) This function will fetch the added servers to object browser. (Default Server Node url) ... ok runTest (pgadmin.browser.server_groups.servers.tests.test_server_put.ServerUpdateTestCase) This function update the server details (Default Server Node url) ... ok runTest (pgadmin.browser.server_groups.tests.test_sg_get.SgNodeTestCase) This function will check available server groups. (Check Server Group Node) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating Incorrect_New_Password) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating New_Password_Less_Than_Min_Length) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating Empty_New_Password) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating Incorrect_Current_Password) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Changing Valid_Password) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (TestCase for Checking Invalid_Password) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Empty_Password) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Empty_Email) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Empty_Credentials) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Invalid_Email) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Invalid_Credentials) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Valid_Credentials) ... ok runTest (pgadmin.browser.tests.test_logout.LogoutTest) This function checks the logout functionality. (Logging Out) ... ok runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) This function checks reset password functionality. (TestCase for Validating Empty Email) ... ok runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) This function checks reset password functionality. (TestCase for Validating Invalid_Email) ... ok runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) This function checks reset password functionality. (TestCase for Validating Valid_Email) ... ok ====================================================================== ERROR: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase) This function will fetch added database. (Check Databases Node URL) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_get.py", line 33, in runTest self.db_id) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py", line 142, in verify_database follow_redirects=True) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 788, in post return self.open(*args, **kw) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/testing.py", line 113, in open follow_redirects=follow_redirects) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 751, in open response = self.run_wsgi_app(environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 668, in run_wsgi_app rv = run_wsgi_app(self.application, environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 871, in run_wsgi_app app_rv = app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 2000, in __call__ return self.wsgi_app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app response = self.make_response(self.handle_exception(e)) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app response = self.full_dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request rv = self.handle_user_exception(e) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request rv = self.dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/views.py", line 84, in view return self.dispatch_request(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line 235, in dispatch_request return method(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/__init__.py", line 364, in connect conn = manager.connection(did=did, auto_reconnect=True) File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line 1448, in connection "Couldn't find the specified database." Exception: Couldn't find the specified database. ====================================================================== ERROR: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase) This function will update the comments field of database. (Check Databases Node) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_put.py", line 37, in runTest db_id) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py", line 142, in verify_database follow_redirects=True) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 788, in post return self.open(*args, **kw) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/testing.py", line 113, in open follow_redirects=follow_redirects) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 751, in open response = self.run_wsgi_app(environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 668, in run_wsgi_app rv = run_wsgi_app(self.application, environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 871, in run_wsgi_app app_rv = app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 2000, in __call__ return self.wsgi_app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app response = self.make_response(self.handle_exception(e)) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app response = self.full_dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request rv = self.handle_user_exception(e) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request rv = self.dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/views.py", line 84, in view return self.dispatch_request(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line 235, in dispatch_request return method(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/__init__.py", line 364, in connect conn = manager.connection(did=did, auto_reconnect=True) File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line 1448, in connection "Couldn't find the specified database." Exception: Couldn't find the specified database. ====================================================================== FAIL: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase) This function will delete the database. (Check Databases Node URL) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_delete.py", line 38, in runTest self.assertEquals(response.status_code, 200) AssertionError: 410 != 200 ---------------------------------------------------------------------- Ran 25 tests in 10.845s FAILED (failures=1, errors=2) =============Running the test cases for 'Regression - EPAS 9.5'============= runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_add.DatabaseAddTestCase) This function will add database under 1st server of tree node. (Check Databases Node URL) ... ok runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase) This function will delete the database. (Check Databases Node URL) ... FAIL runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase) This function will fetch added database. (Check Databases Node URL) ... ERROR runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase) This function will update the comments field of database. (Check Databases Node) ... ERROR runTest (pgadmin.browser.server_groups.servers.tests.test_server_add.ServersAddTestCase) This function will add the server under default server group. (Default Server Node url) ... ok runTest (pgadmin.browser.server_groups.servers.tests.test_server_delete.ServerDeleteTestCase) This function deletes the added server (Default Server Node url) ... ok runTest (pgadmin.browser.server_groups.servers.tests.test_server_get.ServersGetTestCase) This function will fetch the added servers to object browser. (Default Server Node url) ... ok runTest (pgadmin.browser.server_groups.servers.tests.test_server_put.ServerUpdateTestCase) This function update the server details (Default Server Node url) ... ok runTest (pgadmin.browser.server_groups.tests.test_sg_get.SgNodeTestCase) This function will check available server groups. (Check Server Group Node) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating Incorrect_New_Password) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating New_Password_Less_Than_Min_Length) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating Empty_New_Password) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Validating Incorrect_Current_Password) ... ok runTest (pgadmin.browser.tests.test_change_password.ChangePasswordTestCase) This function will check change password functionality. (TestCase for Changing Valid_Password) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (TestCase for Checking Invalid_Password) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Empty_Password) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Empty_Email) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Empty_Credentials) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Invalid_Email) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Invalid_Credentials) ... ok runTest (pgadmin.browser.tests.test_login.LoginTestCase) This function checks login functionality. (Valid_Credentials) ... ok runTest (pgadmin.browser.tests.test_logout.LogoutTest) This function checks the logout functionality. (Logging Out) ... ok runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) This function checks reset password functionality. (TestCase for Validating Empty Email) ... ok runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) This function checks reset password functionality. (TestCase for Validating Invalid_Email) ... ok runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase) This function checks reset password functionality. (TestCase for Validating Valid_Email) ... ok ====================================================================== ERROR: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase) This function will fetch added database. (Check Databases Node URL) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_get.py", line 33, in runTest self.db_id) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py", line 142, in verify_database follow_redirects=True) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 788, in post return self.open(*args, **kw) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/testing.py", line 113, in open follow_redirects=follow_redirects) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 751, in open response = self.run_wsgi_app(environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 668, in run_wsgi_app rv = run_wsgi_app(self.application, environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 871, in run_wsgi_app app_rv = app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 2000, in __call__ return self.wsgi_app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app response = self.make_response(self.handle_exception(e)) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app response = self.full_dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request rv = self.handle_user_exception(e) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request rv = self.dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/views.py", line 84, in view return self.dispatch_request(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line 235, in dispatch_request return method(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/__init__.py", line 364, in connect conn = manager.connection(did=did, auto_reconnect=True) File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line 1448, in connection "Couldn't find the specified database." Exception: Couldn't find the specified database. ====================================================================== ERROR: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_put.DatabasesUpdateTestCase) This function will update the comments field of database. (Check Databases Node) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_put.py", line 37, in runTest db_id) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py", line 142, in verify_database follow_redirects=True) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 788, in post return self.open(*args, **kw) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/testing.py", line 113, in open follow_redirects=follow_redirects) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 751, in open response = self.run_wsgi_app(environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 668, in run_wsgi_app rv = run_wsgi_app(self.application, environ, buffered=buffered) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 871, in run_wsgi_app app_rv = app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 2000, in __call__ return self.wsgi_app(environ, start_response) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app response = self.make_response(self.handle_exception(e)) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app response = self.full_dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request rv = self.handle_user_exception(e) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request rv = self.dispatch_request() File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/views.py", line 84, in view return self.dispatch_request(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line 235, in dispatch_request return method(*args, **kwargs) File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/__init__.py", line 364, in connect conn = manager.connection(did=did, auto_reconnect=True) File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/__init__.py", line 1448, in connection "Couldn't find the specified database." Exception: Couldn't find the specified database. ====================================================================== FAIL: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_delete.DatabaseDeleteTestCase) This function will delete the database. (Check Databases Node URL) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_delete.py", line 38, in runTest self.assertEquals(response.status_code, 200) AssertionError: 410 != 200 ---------------------------------------------------------------------- Ran 25 tests in 13.194s FAILED (failures=1, errors=2) Test Result Summary ============================ Regression - EPAS 9.5: 22 tests passed, 3 tests failed : DatabaseDeleteTestCase DatabasesGetTestCase DatabasesUpdateTestCase Regression - PG 9.5: 22 tests passed, 3 tests failed : DatabaseDeleteTestCase DatabasesGetTestCase DatabasesUpdateTestCase Regression - PG 9.4: 25 tests passed, 0 tests failed ============================ -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers