Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXLiJ-0002Ef-IR for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Oct 2021 11:00:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mXLiI-0008RM-GK for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Oct 2021 11:00:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXLiH-0008RD-25 for pgadmin-hackers@lists.postgresql.org; Mon, 04 Oct 2021 11:00:54 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mXLiD-00070a-MM for pgadmin-hackers@postgresql.org; Mon, 04 Oct 2021 11:00:52 +0000 Received: by mail-ed1-x535.google.com with SMTP id x7so61806235edd.6 for ; Mon, 04 Oct 2021 04:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p2ALU9cfxnkKoWbPER/OfR7JP2PS8OIjx2fOfgZYVrc=; b=Spb5Jm2d+fS7ar7OaYuVnQTdM7ZOksDHmIE25pQa1E90+Z7407AfqclgYeaxxJkWvl ybgOVKmlr6jeiqi9g8JL3iS7xzNvfxZBNc9pvayQ56bOJWPxEnBeBXWLlIVa/75hvcQL 6yvKjlavqL2Yh1GZiZcC7liCI6NTFXViqdPbgzwwYMmHpp3DMNiYfNSbYxfaWNb+AHyO Xv119+pAWQID+NUBw/rUsBHJuStwBoJtsEqkbtmpmaJqMlxpW+2OEl+RBw/A8Q9sXbIy 91lZkSmkfR8WqpPcry4m6WuJL5KMmjoNdw5Sb/9+1ZKh5rGqKGsnKF9mZ6qGlTgxepz7 62dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p2ALU9cfxnkKoWbPER/OfR7JP2PS8OIjx2fOfgZYVrc=; b=jcqGEzAWoQ8KhIS/WIniD2xX9f/vawCwRuiNiS+vfq1RX8zSCvuaIRirTFgOG+Hknu bsVkzSEE7UppP4toHjQ5a0Jy/RenZnrBLlQlp4UBP2xSU1Ve/W7+LJUDhrekeaSuLIQ9 fZ+B337ttvI8VHuWOXCNULzV6MwDtnitJ/BoAFXANeOCpNQ82U3hGyRqgWASAI2VX8jN 1F/Q6DUOfxFYRE4cY4Sapqr7+w7vRHKXd8bVLyrr86pn9o5/QN2lw0135LKLfvP/BZ15 h12l7/+hlczikiTpvQKgZgsFishKg2NiAZSHpKmwyWEiNIJYOOsHp3U+JV4/EJdfgg+S B37A== X-Gm-Message-State: AOAM533YYOxzXgHQyot7lim3toq95kF5T2O681HEWtjGO2BDO5AP4DWD UQD92cmksxoiojJB8XaRqogxTER3KIpHJc0QWnEzgg== X-Google-Smtp-Source: ABdhPJxeewTBMOWSGPyKvVgGAN57MjjsRhCprClhZ9ydW9e/2mFldGm2ToDcf6UBDqB84yBTrd1QqYzjv8aMjXSVzdY= X-Received: by 2002:a50:cf48:: with SMTP id d8mr17684019edk.293.1633345243139; Mon, 04 Oct 2021 04:00:43 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 4 Oct 2021 12:00:29 +0100 Message-ID: Subject: Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS To: Semab Tariq Cc: pgadmin-hackers , Sandeep Thakkar , Ashesh Vashi Content-Type: multipart/alternative; boundary="000000000000036ec705cd84d3ab" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000036ec705cd84d3ab Content-Type: text/plain; charset="UTF-8" Hi I've tagged 4.2.2. On Fri, Oct 1, 2021 at 11:22 AM Semab Tariq wrote: > (Adding Ashesh, Sandeep) > > Hi Team > > Do we have any possible date for the pgAgent-4.2.2 release? > I am interested in 4.2.2 because 4.2.1 doesn't have support to build > universal binaries on macOS but 4.2.2 will have this support because this > > commit is already pushed to the master branch > Also, we plan to release pgAgent for PG-14.0, and for this, we need > pgAgent-4.2.2(Due to its universal binaries support) > > Thanks & Regards, > Semab > > On Mon, Aug 2, 2021 at 1:27 PM Semab Tariq > wrote: > >> Great, thanks for letting me know. >> >> On Mon, Aug 2, 2021 at 1:12 PM Dave Page wrote: >> >>> Thanks, patch applied. >>> >>> On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq >>> wrote: >>> >>>> Hi Team >>>> >>>> In my previous email, I attached a link to the JIRA ticket and I was >>>> hoping that you can access that ticket and see the details about my patch >>>> but I was unaware that JIRA is not accessible to the community so now I am >>>> attaching the details here >>>> >>>> *Details about my patch* >>>> >>>> While trying to generate *pgAgent-4.2.1* universal binaries on *macOS >>>> BigSur x86_64* architecture via following command >>>> 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake. >>>> app/Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - >>>> DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" - >>>> DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D >>>> CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/ >>>> MacOSX11.1.sdk CMakeLists.txt >>>> >>>> I got this error in configure log >>>> 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" >>>> "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- >>>> Configuring incomplete, errors occurred! >>>> >>>> After some debugging, I found out that the >>>> *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double >>>> quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* condition >>>> so I added that, and now I am able to build pgAgent universal binaries >>>> successfully. If you don't have any concerns with my patch can someone >>>> please push the changes to the source? Thanks & Regards, >>>> Semab >>>> >>>> On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq < >>>> semab.tariq@enterprisedb.com> wrote: >>>> >>>>> Hi Team >>>>> >>>>> Can someone please push this patch to the *master* branch of *pgAgent* >>>>> repo? >>>>> For more details Please refer to JIRA PPS-310 >>>>> >>>>> >>>>> -- >>>>> Thanks & Regards, >>>>> Semab >>>>> >>>> >>>> >>>> -- >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: https://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EDB: https://www.enterprisedb.com >>> >>> >> >> -- >> Thanks & Regards, >> Semab >> > > > -- > > -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com --000000000000036ec705cd84d3ab Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

I've tagged 4.2.2.
On Fri, = Oct 1, 2021 at 11:22 AM Semab Tariq <semab.tariq@enterprisedb.com> wrote:
(Adding Ashesh, Sandeep)

H= i Team

Do we have any possible date for the pgAgent-4.2.2 release?<= /div>
I am interested in 4.2.2 because 4.2.1 doesn't have support t= o build universal binaries=C2=A0on macOS but 4.2.2 will have this support b= ecause this commit is already pu= shed to the master branch
Also, we plan to release pgAgent for PG= -14.0, and for this, we need pgAgent-4.2.2(Due to its universal binaries su= pport)

Thanks & Regards,
Semab

On = Mon, Aug 2, 2021 at 1:27 PM Semab Tariq <semab.tariq@enterprisedb.com> wro= te:
Great, thanks for letting me= know.=C2=A0

On Mon, Aug 2, 2021 at 1:12 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.

<= div class=3D"gmail_quote">
On Mon, Aug= 2, 2021 at 2:44 AM Semab Tariq <semab.tariq@enterprisedb.com> wrote:
<= /div>
Hi Team=C2=A0
In my previous email, I attached a link to the JIRA ticket and I was hopi= ng that you can access that ticket and see the details about my patch but I= was unaware=C2=A0that JIRA is not accessible to the community so now I am = attaching the details here

Details about my patch

While trying to generate pgAgent= -4.2.1 universal binaries on macOS BigSur x86_64 architecture= via following command

1BOOST_ROOT=3D/= tmp/PG-pgAgent PGDIR=3D/tmp/PG-= pgAgent /Applications<= span style=3D"font-family:unset;font-size:unset;font-variant-caps:unset;fon= t-weight:unset;font-stretch:unset;line-height:unset;font-feature-settings:u= nset;text-orientation:unset;writing-mode:unset;zoom:unset;background-image:= unset;background-size:unset;background-origin:unset;background-clip:unset;b= ackground-color:unset;background-blend-mode:unset;border:unset;border-top-l= eft-radius:unset;border-top-right-radius:unset;border-bottom-right-radius:u= nset;border-bottom-left-radius:unset;border-collapse:unset;box-sizing:unset= ;break-after:unset;break-before:unset;break-inside:unset;caption-side:unset= ;clear:unset;column-width:unset;column-count:unset;column-fill:unset;column= -rule-width:unset;column-rule-style:unset;column-rule-color:unset;column-sp= an:unset;display:unset;empty-cells:unset;float:unset;height:unset;image-ori= entation:unset;isolation:unset;letter-spacing:unset;line-break:unset;list-s= tyle:unset;margin:unset;max-height:unset;max-width:unset;min-height:unset;m= in-width:unset;mix-blend-mode:unset;object-fit:unset;object-position:unset;= opacity:unset;outline:unset;overflow:unset;padding:unset;quotes:unset;table= -layout:unset;text-align:unset;text-decoration:unset;text-indent:unset;text= -overflow:unset;text-transform:unset;text-underline-position:unset;vertical= -align:unset;border-spacing:unset;white-space:unset;width:unset;word-break:= unset;word-spacing:unset;background-position:unset;background-repeat:unset"= >/CMake.app/<= /span>Contents/bin/<= /span>cmake -DCMAKE_INSTALL_PREFIX=3D<= /span>/tmp/PG-pg= Agent -DCMAKE_OSX_ARCHITECTURES:STRING=3D"x86_64;arm64" -DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=3D10.14= -DSTATIC_BUILD=3DNO -= D CMAKE_OSX_SYSROOT:FILEPATH=3D/Lib= rary/Developer/CommandLineTools//MacOSX11.1.sdk CMak= eLists.txt

I got this error in configure log =

= 1CMake Error at CMakeLists.txt:43= (IF): 2 if given arguments= : 3 "= ;NOT" "x86_64" "arm64" "STREQUAL" "" 4 Unkno= wn arguments specified 5-- Configuring incomplete, errors occurred!

After some debugging, I found out that = the pgAgent-4.2.1-Source/CMakeLists.txt file doesn't have prop= er double quotes around CMAKE_OSX_ARCHITECTURES variable inside if condition so I added that, and now I am able to build pgAgent uni= versal binaries successfully.=20 If you don't have any concerns with my patch can someone please push th= e changes to the source? Thanks &= ; Regards,
Semab


On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq <semab.tariq@enterpr= isedb.com> wrote:
Hi Te= am

Can someone please push this patch to the master branch of= pgAgent repo?
For more details Please refer to JIRA PPS-310= =C2=A0

--
Thanks & Regards,Semab


--


--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake<= br>
EDB: http= s://www.enterprisedb.com



--
Thanks & Regards,=
Semab


--



--
--000000000000036ec705cd84d3ab--