Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7hu4-00076c-VR for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 12:36:41 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d7hu4-0002kM-HY for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 12:36:40 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d7hu4-0002kC-4k for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 12:36:40 +0000 Received: from mail-io0-x230.google.com ([2607:f8b0:4001:c06::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d7htw-0002bj-Jf for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 12:36:38 +0000 Received: by mail-io0-x230.google.com with SMTP id f102so48237891ioi.2 for ; Mon, 08 May 2017 05:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZPgX0CXsBqOku/dxNBTAeSs/YP2eZzyaCyvzl2SS/cQ=; b=M3qfvyrDhCItGNXU1BQnvst3m5QLRx70TnpYsD3Zn5YkBdsFClIg/Xi3g2u+uC5Y9m za0wQ1chBf2McUhFFm6wNr3pQsKnkNZX4WEsYXDhQRAyXdKvtDhbbioQdafT/zy5DrxD ZrXtvmVWVjynonhdKD3Bvp2qkMVmQduF4T5pdVqHb520djyPMnbBI2zCTTTZhQzVbe7b vsm01zZzdelq7gC2GIu5Tsh8Z/feSRiBOKb5d5rzTWz3Snshby1ft+6wZMKSU6xvFJ2m PqNOGRsX17ia0B5CYzUGhF2+JOI33qdMP8yagE/2ImiRrEdbCXaLF+S/DvPjh0bBld01 h1Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZPgX0CXsBqOku/dxNBTAeSs/YP2eZzyaCyvzl2SS/cQ=; b=LlrHwZyPZ9DhqweXDJXi/1xw24gNd6ruUPoUFJEWW+T993Sn8FIUoEW8ECPZbb7ncB 4MM0+FpFJ25VXdcXjWAlvsgR57JTbBBZq1rxSFdpiX5y0s3jhqSMYq4f33QbT9EcdNsD ESYtJnv5CFl/Tf24fDuU0TwmVJK3r0gFBS5SSfvbHyXh9eSQ+dPoJ7QRMk8dYKiK7Hhb 8OA9SWmJsPdBpvYXJ4WqaKKgLLu1xnsVyiHX66Iyo55o2tdvSbo89lijPi0HJYebpDxf avktsjrpW39GudfsdzkCZj5kHAmGsVb5oDbeOuGFk/vG2iJ6JuyXy3A53vvwhB0kw3It Q3vA== X-Gm-Message-State: AODbwcB0guxhYUm++no/nMdEDh3Cuh4F+bGWtUTgHcA6RuWYQFwb5p+r topGu5sQHLvTNNjqBxoyuOs1ueCqeA== X-Received: by 10.107.51.14 with SMTP id z14mr3439967ioz.84.1494246991766; Mon, 08 May 2017 05:36:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Mon, 8 May 2017 05:36:30 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 8 May 2017 13:36:30 +0100 Message-ID: Subject: Re: [pgAdmin4][PATCH] To fix the issues with CSV file download To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113a8bc826e188054f027d0a X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113a8bc826e188054f027d0a Content-Type: text/plain; charset=UTF-8 Thanks, patch applied. On Mon, May 8, 2017 at 1:14 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > Please find the patch to fix the issues in CSV file download feature, > > 1) To handle non-ascii filenames which we set from table name > RM#2314 > > 2) To handle non-ascii query data > RM#2353 > > 3) To dump JSON type columns properly in csv > RM#2360 > > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113a8bc826e188054f027d0a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.
On Mon, May 8, 2017 at 1:14 PM, Murtuza Zabuawa= la <murtuza.zabuawala@enterprisedb.com> wro= te:
Hi,

Please find the patch to fix the issues in CSV file download feature,

1) To handle non-ascii filenames which we set from t= able name
RM#2314

2) To h= andle non-ascii query data
RM#2353

3= ) To dump JSON type columns properly in csv
RM#2360

Please review.

--
Regards,Murt= uza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y
=


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
--001a113a8bc826e188054f027d0a--