Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erlqU-0005eb-9i for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 14:39:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erlqT-0008VN-7F for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 14:39:37 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erlqS-0008VC-Lv for pgadmin-hackers@lists.postgresql.org; Fri, 02 Mar 2018 14:39:37 +0000 Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erlqO-0002xS-Qt for pgadmin-hackers@postgresql.org; Fri, 02 Mar 2018 14:39:35 +0000 Received: by mail-wr0-x235.google.com with SMTP id k9so10302444wre.9 for ; Fri, 02 Mar 2018 06:39:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=h2fBpMaHsjOkCZDpAyVHD0fGYl5UwugV2WnRybXuLbA=; b=lDTkG30kd7Ym4CNmjK6wYWLCIL5E2I0ql5B11lN+aR2HJIROFhxduAjt/k0NL8Hios 8DZxnXwHewNlQJUmbtYB9gHGlwBcODcWPNXo9BDDEXZza+1PLzXS6XBmeJeEBwJJBKuT DorSEqd5EFA5Dvf+eZ54qrJJFwyCnrGi9zNMuumRgh2ohBx90PnqVNKG0IPDN38sENhu 00KYIo85YSZ432BpQ7smNJvs61QcRnpOFUI27Zkh85ONPAT7W2UDmwr/yCRntJTHlO/7 K/tx55Qhvkp6OxOuuX7pyPzz8LOCGaP1zhOuLNRvU2JM1Is4OhAkbWQNiDttyu046d+b QbJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=h2fBpMaHsjOkCZDpAyVHD0fGYl5UwugV2WnRybXuLbA=; b=RxetpQ0L52KGOQFIwI/+b5RvoxG1rPnA1YTDlODH4o+VWYrvz83zDh6RlwxBThMBa1 GGpNIKjzlD3FrgVm0FHxDuuIlLu87JEQJ2r4JccJRW5o4corpUYyyE0oCOLGDfPhYF8g gxmYQqdU6lztvOmGgg35Ap5wqdQjqJhXrdRFQXSuuJL6ZiWwpHyCLK4ws8oGZ7OWtb4Y 7uXVQqdkg5twtixt+I/ZKwy8L2EqEgzMzJ0EgEwdLESczYb4Pbtofoz1SmdSTgz/BpfY hQkpQ8cCJj8yuNnJvHJNPk4H3mYkkeiX09CkNyctJMGzk7SeIU4vAZuJrS9xmw8wOg2l bSww== X-Gm-Message-State: APf1xPAwFuzVK0wPt3O4YnsO0ihs63cPqfOSz1hcPA9+5XMQK7ZInXq+ 3Ri4e4NFd2ppV2LlNfXWapiWSoml4Y/eLN0f/iIubg== X-Google-Smtp-Source: AG47ELuMZMgiS3JYMu/R0Jtcd4yVwyKFIH8JHemnUoTeQMucg9rWAPqLNPTeUzCfZVbH8ZFYEMSSWi2DoEIRGWDqz4I= X-Received: by 10.223.178.206 with SMTP id g72mr4884564wrd.135.1520001569765; Fri, 02 Mar 2018 06:39:29 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Fri, 2 Mar 2018 06:39:28 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 2 Mar 2018 14:39:28 +0000 Message-ID: Subject: Re: Bug #2309 fix To: Neethu Mariya Joy Cc: Murtuza Zabuawala , Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045cf6b89fccb005666ef182" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045cf6b89fccb005666ef182 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Fri, Mar 2, 2018 at 9:05 AM, Neethu Mariya Joy wrote: > Hi, > > A similar workaround fixed #3137 too. I'm attaching the patch below. > > Sincerely, > Neethu > > On Fri, Mar 2, 2018 at 9:45 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Neethu, >> >> Patch looks good. >> >> We are facing similar issue on dashboard as well where users are not able >> to copy the sql from server activity table, I've attached screenshot for >> your reference. >> Bug: https://redmine.postgresql.org/issues/3137 >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Fri, Mar 2, 2018 at 3:35 AM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hello Neethu, >>> >>> We run the patch though our test pipeline and all tests are green. >>> Everything looks good with this patch >>> >>> Thanks >>> Joao >>> On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy < >>> neethumariyajoy@gmail.com> wrote: >>> >>>> Hi, >>>> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer >>>> Science at BITS Pilani. >>>> >>>> I've attempted to fix https://redmine.postgresql.org/issues/2309. >>>> Codemirrors catches all the keyboard and mouse events when 'readOnly' >>>> option is set to 'noCursor' and does not allow copying. >>>> So, I've set 'readOnly' option to true. In order to hide the cursor, >>>> I've added a class 'hide-cursor-workaround' and applied css styles to hide >>>> the cursor. >>>> >>>> I'm attaching my patch as bug2309.diff below as per the contribution >>>> guidelines. >>>> >>>> Hope this helps. Thank you for your consideration! >>>> >>>> Sincerely, >>>> Neethu Mariya Joy >>>> GitHub | Linkedin >>>> >>>> >>>> >>>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045cf6b89fccb005666ef182 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Fri, Mar 2, 2018 at 9:05 AM, Neethu Mariya Joy <neethumariyajoy@gmail.com> wrote:
Hi,

A similar workaround = fixed #3137 too. I'm attaching the patch below.

Sincerely,
Neethu

On Fri, M= ar 2, 2018 at 9:45 AM, Murtuza Zabuawala <murtuza.zabuawa= la@enterprisedb.com> wrote:
Hi Neethu,

Patch looks good.

We are facing similar issue= on dashboard as well where users are not able to copy the sql from server = activity table, I've attached screenshot for your reference.
Bug: https://redmine.postgresql.org= /issues/3137


--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= /font>


On Fri, Mar 2, 2018 at 3:35 AM, Joao De Alme= ida Pereira <jdealmeidapereira@pivotal.io> wrote:=
Hello Neethu,

<= div>We run the patch though our test pipeline and all tests are green. Ever= ything looks good with this patch

Thanks
Joao
On Thu, Mar 1, 2018 at= 10:37 AM Neethu Mariya Joy <neethumariyajoy@gmail.com> wrote:
Hi,
I am Neethu Mariya = Joy, an undergraduate pursuing BE in Computer Science at BITS Pilani.
=

I've attempted to fix=C2=A0https://redmine.postgresql= .org/issues/2309. Codemirrors catches all the keyboard and mouse e= vents when 'readOnly' option is set to 'noCursor' and does = not allow copying.
So, I've set 'readOnly' option to = true. In order to hide the cursor, I've added a class 'hide-cursor-= workaround' and applied css=C2=A0styles to hide the cursor.
<= br>
I'm attaching my patch as bug2309.diff below as per the c= ontribution guidelines.

Hope this helps. Thank you= for your consideration!

Sincerely,
Neet= hu Mariya Joy
GitHub=C2=A0|=C2=A0Linkedin
<= /div>

<= /div>





--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--f403045cf6b89fccb005666ef182--