MIME-Version: 1.0
In-Reply-To: 
 <CACCA4P3b2MskMggrE=GiL5_MNhGPfaMr1u1u-XvsYHvNOuF+aA@mail.gmail.com>
References: 
 <CACCA4P3b2MskMggrE=GiL5_MNhGPfaMr1u1u-XvsYHvNOuF+aA@mail.gmail.com>
Date: Mon, 18 Apr 2016 13:39:37 +0100
Message-ID: 
 <CA+OCxoyWHjtFiDU6GbexDtCDqyfgMndE29rfVesmdiheWBTvkg@mail.gmail.com>
Subject: Re: [pgAdmin4][patch]: String evaluation issue
From: Dave Page <dpage@pgadmin.org>
To: Neel Patel <neel.patel@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=089e0129483a4f09c20530c1a7dc
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--089e0129483a4f09c20530c1a7dc
Content-Type: text/plain; charset=UTF-8

Thanks, applied.

On Monday, April 18, 2016, Neel Patel <neel.patel@enterprisedb.com> wrote:

> Hi,
>
> Please find attached patch file containing the fix for the below issue.
> This issue is reported by Dave during the debugger code review and we have
> removed the same issue from other files where we used.
>
> *Issue :- *
>
> When we use below string to form the error message then it will not work
> because Jinja will evaluate the string " + err.errormsg + " before it gets
> evaluated as JS by the browser.
>
>            *alertify.error("{{ _('" + err.errormsg + "') }}");*
>
>
> Do review it and let us know for any comments.
>
> Thanks,
> Neel Patel
>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--089e0129483a4f09c20530c1a7dc
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Thanks, applied.<br><br>On Monday, April 18, 2016, Neel Patel &lt;<a href=
=3D"mailto:neel.patel@enterprisedb.com">neel.patel@enterprisedb.com</a>&gt;=
 wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bor=
der-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi,<div><br></di=
v><div>Please find attached patch file containing the fix for the below iss=
ue.</div><div>This issue is reported by Dave during the debugger code revie=
w and we have removed the same issue from other files where we used.</div><=
div><br></div><div><b>Issue :-=C2=A0</b></div><div><b><br></b></div><div>Wh=
en we use below string to form the error message then it will not work beca=
use Jinja will evaluate the string &quot; + err.errormsg + &quot; before it=
 gets evaluated as JS by the browser.</div><div><br></div><div>=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<b>alertify.error(&quot;{{ _(&#39;&quot; + e=
rr.errormsg + &quot;&#39;) }}&quot;);</b><br></div><div><br></div><div><br>=
</div><div>Do review it and let us know for any comments.</div><div><br></d=
iv><div>Thanks,</div><div>Neel Patel</div><div><br></div></div>
</blockquote><br><br>-- <br>Dave Page<br>Blog: <a href=3D"http://pgsnake.bl=
ogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @=
pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" tar=
get=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL=
 Company<br><br>

--089e0129483a4f09c20530c1a7dc--