MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D8fkGNhktgspPc2wS78EEnxtzgCaQsaXADcn0oV=dLhoA@mail.gmail.com>
References: 
 <CAM5-9D8fkGNhktgspPc2wS78EEnxtzgCaQsaXADcn0oV=dLhoA@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 19 Sep 2016 17:09:19 +0100
Message-ID: 
 <CA+OCxoyYCburKQM=5WcUKA1NdiJUSLuTvESS1xr+s+d5mKjgBA@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: Slickgrid loading issue in
 Query tool
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks, applied.

On Mon, Sep 19, 2016 at 2:58 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Issue:
> Slick-grid libraries loads when an instance of query tool is opened. But
> sometimes it throws exception "jQuery is not defined" and it doesn't opens
> up.
>
> Solution:
> As per my understanding, In datagrid/index.html file, we set the order of
> loading libraries such as
> require(['jquery', 'pgadmin', 'pgadmin.sqleditor'])
> but it still loads pgadmin.sqleditor.js file before jQuery for unknown
> reason.
>
> To fix this, we load pgadmin.sqleditor.js file using require([],
> function(){}) module loader which ensures that the code within function(){}
> will be executed when pgadmin.sqleditor.js is loaded.
>
> Please find attache patch.
> This issue is fixed by Ashesh Vashi.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers