Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewVV4-000677-4L for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 16:13:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewVV2-0003a3-VF for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 16:13:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewVV2-0003Zt-K9 for pgadmin-hackers@lists.postgresql.org; Thu, 15 Mar 2018 16:13:04 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewVUz-0007I2-4Y for pgadmin-hackers@postgresql.org; Thu, 15 Mar 2018 16:13:04 +0000 Received: by mail-wm0-x244.google.com with SMTP id t6so11607056wmt.5 for ; Thu, 15 Mar 2018 09:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LXnMqUgVQHaMNxud/qsbp/1x3tpIbyb3YQz8kIlbe/I=; b=0ejBH6X1tjg2D8A7Pbh1k1ASsUUfmWtfASupFXOmd2B0j5kJBDxQDwciek1zArkIVt QUBVy86XFHjLIM5nGaEF7kqFs+2tbGsqdfCB55ZCLK2xbKOZNdyUGZRxpxtwFnGIZBfQ xUQhjNGTojGdqWiIRHpjpxXATTED8ZKZ1N5zGgNnThFPVJOwpWT5E8+uAcwvaGZPpJbP 4G8vK7SP6xwe9eHK+tIY9vMCI2oz86PDcBqypdR7wB30vEl5+aKqS6sHxl++E/gb13ed 3kKOn9+HqX3VIhijW/Sclsmuh5iSM2GTAzEMokqASwYTbe5B2VkJLtuTlmZYjj1n5HhK YksQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LXnMqUgVQHaMNxud/qsbp/1x3tpIbyb3YQz8kIlbe/I=; b=GJyefa3RmTjOpqk+Ia1Hi+iIuGEQizcgUIrFi6KbCw/RGcC3Wt2IlVXpLFF9WGdWg7 S3hfRW+gt+ElADqG3+UO63OfZdr2CJR+Wb1I2m3oKGgm7bwXbGpDeEjodhdto4AK1r0k ObSbS9v3A7Tj5Qj1/wQKBlkPfHKjWkz211PEXcv9bIQ3N0OTj1Nv1mLxZRsLtf/8lDbQ MOy045hYypgWPYG0lCONHuO34L3vWT2WBhkT2FjUMSTiUQyYJZUDXTa23bKTNKyy2v55 ylBfgn6gyFNCfxvNNNArV6Fe3QRV9ikC+dVi4iB4gCGaYevBU2xUKWARaqNzg0GGpv9/ pYow== X-Gm-Message-State: AElRT7Gf1c9tvffZuw4Htm6M1efi2G8HP7oImVXNmYDawxu3IKuAo4ZT DMAaqcwBiSJFRe+zzIjJXX9tms5MvzLySDnTbWqs7w== X-Google-Smtp-Source: AG47ELvoB8JDsX8agcH/YJ48l2xX8LTUd2RpR55VjXMaXmAVrqLgADEfov+1GnN4MnMB8vDcVqGetl1P4x+P1oL6OfU= X-Received: by 10.28.130.9 with SMTP id e9mr4982337wmd.161.1521130379638; Thu, 15 Mar 2018 09:12:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Thu, 15 Mar 2018 09:12:58 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 15 Mar 2018 12:12:58 -0400 Message-ID: Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn To: Murtuza Zabuawala Cc: Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a11444b44ef94c6056775c3a7" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a11444b44ef94c6056775c3a7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> I have just noticed, we're ignoring migrations directory too. >>> Should we not also check code styling for migrations directory? >>> >> >> Yeah, I was going to ask about that :-). Is there a specific reason why >> we're ignoring the migrations Murtuza? >> > =E2=80=8BTo ease writing long SQL's. > > Perhaps we could just skip the long line check for those files? > >> >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page wrote: >>> >>>> Ignore config_local.py and config_distro.py when running PEP-8 checks. >>>> >>>> Branch >>>> ------ >>>> master >>>> >>>> Details >>>> ------- >>>> https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdif >>>> f;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe >>>> >>>> Modified Files >>>> -------------- >>>> web/.pycodestyle | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a11444b44ef94c6056775c3a7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala &l= t;m= urtuza.zabuawala@enterprisedb.com> wrote:
On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <= span dir=3D"ltr" style=3D"font-family:arial,sans-serif;color:rgb(34,34,34)"= ><dpage@pgadmin.o= rg> wrote:
Hi

On= Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@en= terprisedb.com> wrote:
Hi,

I have just noticed, we're ign= oring migrations directory too.
Should we not also check code sty= ling for migrations directory?

<= div>Yeah, I was going to ask about that :-). Is there a specific reason why= we're ignoring the migrations Murtuza?
=E2=80=8BTo ease writing long SQL's.
=C2=A0=

Perhaps we could j= ust skip the long line check for those files?
=C2=A0
=C2=A0=

--=

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company=

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Ignore config_local.py and config_distro.py when running PEP-8 checks.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcom= mitdiff;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe

Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: = @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQ= L Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a11444b44ef94c6056775c3a7--