Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgadmin-hackers-owner+archive@lists.postgresql.org>)
	id 1evY0Z-00052P-LX
	for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 00:41:40 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgadmin-hackers-owner+archive@lists.postgresql.org>)
	id 1evY0W-0006yf-Vr
	for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 00:41:36 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <dpage@pgadmin.org>)
	id 1evY0W-0006yV-6N
	for pgadmin-hackers@lists.postgresql.org; Tue, 13 Mar 2018 00:41:36 +0000
Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <dpage@pgadmin.org>)
	id 1evY0R-0001Nq-Sj
	for pgadmin-hackers@postgresql.org; Tue, 13 Mar 2018 00:41:34 +0000
Received: by mail-wr0-x242.google.com with SMTP id z12so17799227wrg.4
        for <pgadmin-hackers@postgresql.org>;
 Mon, 12 Mar 2018 17:41:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=pgadmin-org.20150623.gappssmtp.com; s=20150623;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc;
        bh=AuHkfmJ96HK7v0zjkHzVqoZnX7DJ7P5gfBMMHqw/D4A=;
        b=GEBOdI22TcpRdSprEHz6vWy9RZPcV7dBOKL8gEEwkHW340kqGFunZn/hqwb70kenax
         +n0iH0DRk5SpHNbYfO2vU18/pcDXPUWmYvrwLFrRAj9Zhy2Wsie/An3G4r1tPhuI6JXT
         Aaa/86jGg2xRwWBUsYhUIgXu4GcziCb0Hn0PN6KR1gj5jH5vbgawOdkL8PM52fCgZfCJ
         r+il+Kd9Od9Zj6WF8OzM0GnLyCgeWZcenFNX6BRSyp5yjkB8w8ZGdRN6XyGKmsDZde4N
         4z1Qic5eS9IwvPm55uAD2D0fOYcBMpts9RlL6Y2S5diud0N4v2p8sKzBu4aYvcaWoPgV
         wo/w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=AuHkfmJ96HK7v0zjkHzVqoZnX7DJ7P5gfBMMHqw/D4A=;
        b=MMPiaasLJUY6BWul+69RNLiybNjP/TXIF9jftlEXGdMTyMFGhLEwW6Y6PRaHXtD07J
         1Br+cvuedmXsbYBoNgTPo3V6Bbwp3H+fTfAciIKKvDF3Ak/O1UXL061DxplnLnfijJb3
         wI6eb3omHHqRKyMCwEIWx4YaOB8tX9pDCDs8sWqRZmCTMjOwpnpPMFH4JEO1H5Td2RaT
         mwKiwSUJy/l2pGmfCOaKvb489hfOyd9RjauOa1J8O7jpQR9kCpNExKdP+UXiePWQPs+l
         ZJlag0JprdjRzm9JKkA/MvyVk854HJgFA1oWD7zQ2acRCTGbjw7dYGeFlXpt0VxXn8WE
         t3CA==
X-Gm-Message-State: AElRT7G/eM9+ENmEttFp398MkR+OkcQo5BPVjF2oFWOeeJ37lgdKGnbo
	4f1K8ej+afQX+kmDc72ftYHdtFYPgDG+6vkBUzKY/A==
X-Google-Smtp-Source: 
 AG47ELvoEmDuJ7CZQs4Nx/7y5MVkLh/WAQ0ZO7Bu8dnqNsNm6ZnLQO3RbWqu9vpS3xbXxBmHcCOSCiyCypT4EsIwh4o=
X-Received: by 10.223.176.98 with SMTP id g31mr2771104wra.256.1520901688445;
 Mon, 12 Mar 2018 17:41:28 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.28.109.7 with HTTP; Mon, 12 Mar 2018 17:41:27 -0700 (PDT)
In-Reply-To: 
 <CAKKotZSDVNp73-NJ3WFJi=SBNNQ7Mu0SjfLmOcLcGTdFFxbmow@mail.gmail.com>
References: 
 <CAKKotZSDVNp73-NJ3WFJi=SBNNQ7Mu0SjfLmOcLcGTdFFxbmow@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 12 Mar 2018 20:41:27 -0400
Message-ID: 
 <CA+OCxoyZpBo4M9LqGF=3p6sQLZ4xZfgFB=+1sRh1dQN7XwOoug@mail.gmail.com>
Subject: Re: [pgAdmin4][RM#3139] Create proper template path if Windows
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="001a113c9c40e0d6680567408498"
List-Id: <pgadmin-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgadmin-hackers@lists.postgresql.org>
List-Owner: <mailto:pgadmin-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgadmin-hackers>
Precedence: bulk

--001a113c9c40e0d6680567408498
Content-Type: text/plain; charset="UTF-8"

Hi

On Mon, Mar 12, 2018 at 10:15 AM, Murtuza Zabuawala <
murtuza.zabuawala@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to correct the template path generation logic incase of Windows
> system.
>

Seems like it would be better to fix it the other way round to me - e.g.
update the template loader to use os.path.join.

Any reason not to do that?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113c9c40e0d6680567408498
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<div class=3D"gmail_extra"><br><div class=3D"gmail_quote=
">On Mon, Mar 12, 2018 at 10:15 AM, Murtuza Zabuawala <span dir=3D"ltr">&lt=
;<a href=3D"mailto:murtuza.zabuawala@enterprisedb.com" target=3D"_blank">mu=
rtuza.zabuawala@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex"><div dir=3D"ltr"><div style=3D"font-family:verdana,sans-serif=
;color:#444444">Hi,</div><div style=3D"font-family:verdana,sans-serif;color=
:#444444"><br></div><div style=3D"font-family:verdana,sans-serif;color:#444=
444">PFA patch to correct the template path generation logic incase of Wind=
ows system.</div></div></blockquote><div><br></div><div>Seems like it would=
 be better to fix it the other way round to me - e.g. update the template l=
oader to use os.path.join.</div><div><br></div><div>Any reason not to do th=
at?=C2=A0</div></div><div><br></div>-- <br><div class=3D"gmail_signature" d=
ata-smartmail=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsn=
ake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twit=
ter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.co=
m" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise Post=
greSQL Company<br></div>
</div></div>

--001a113c9c40e0d6680567408498--