MIME-Version: 1.0
References: 
 <CAFOhELeCi7Dyp_T5EeKQXWLc1H580u5o13BKQeFxAZPpjRmhTw@mail.gmail.com>
In-Reply-To: 
 <CAFOhELeCi7Dyp_T5EeKQXWLc1H580u5o13BKQeFxAZPpjRmhTw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 17 Mar 2020 10:12:01 +0000
Message-ID: 
 <CA+OCxoyZvHAxNTDXYDNVE0irEFwYnJ0z-5KXKuJ_1Bc9aEYTWA@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication
 sources [LDAP]
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000603b1b05a10a2b94"
Precedence: bulk

--000000000000603b1b05a10a2b94
Content-Type: text/plain; charset="UTF-8"

Hi

30 second read of the first version of the patch...

- Please move the configuration into config.py. Users should never have to
modify a distributed file (it messes up packaging). I don't see any reason
to use a different file just for auth config.

- I think all config options should be prefixed with LDAP_ as we may have
things like CERT_FILE for other purposes too.

- I don't see any test cases.

Thanks.


On Tue, Mar 17, 2020 at 8:55 AM Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to support LDAP Authentication in Server
> mode.
> To test the patch, config_auth.py needs to be configured for LDAP
> configurations. The config settings are explained in this file in detail.
> After configuring the parameters, start the pgadmin server in Server mode
> and connect with LDAP server with the valid user via login page.
>
> I have tested this patch with ldap and ldap + ssl/tls. With the TLS, I
> have used the default config of ldap3 without certificates.
>
> @Dave, can you please review this patch, as you have a better
> understanding of LDAP and you can easily pointed out if I have missed
> anything.
>
> Note: For the document update I will create the task and assign to Nidhi
> for the same.
>
> Thanks,
> Khushboo
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000603b1b05a10a2b94
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<div><br></div><div>30 second read of the first version =
of the patch...</div><div><br></div><div>- Please move the configuration in=
to config.py. Users should never have to modify a distributed file (it mess=
es up packaging). I don&#39;t see any reason to use a different file just f=
or auth config.</div><div><br></div><div>- I think all config options shoul=
d be prefixed with LDAP_ as we may have things like CERT_FILE for other pur=
poses too.</div><div><br></div><div>- I don&#39;t see any test cases.</div>=
<div><br></div><div>Thanks.</div><div><br></div></div><br><div class=3D"gma=
il_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Mar 17, 2020 at 8:5=
5 AM Khushboo Vashi &lt;<a href=3D"mailto:khushboo.vashi@enterprisedb.com" =
target=3D"_blank">khushboo.vashi@enterprisedb.com</a>&gt; wrote:<br></div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi,<div><=
br></div><div>Please find the attached patch to support LDAP Authentication=
 in Server mode.</div><div>To test the patch, config_auth.py needs to be co=
nfigured for LDAP configurations. The config settings are explained in this=
 file in detail. After configuring the parameters, start the pgadmin server=
 in Server mode and connect with LDAP server with the valid user via login =
page.</div><div><br></div><div>I have tested this patch with ldap and ldap=
=C2=A0+ ssl/tls. With the TLS, I have used the default config of ldap3 with=
out certificates.</div><div><br></div><div>@Dave, can you please review thi=
s patch, as you have a better understanding of LDAP and you can easily poin=
ted out if I have missed anything.</div><div><br></div><div>Note: For the d=
ocument update I will create the task and assign to Nidhi for the same.</di=
v><div></div><div><br></div><div>Thanks,</div><div>Khushboo</div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
>Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_blan=
k">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB=
 UK: <a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.e=
nterprisedb.com</a><br>The Enterprise PostgreSQL Company<br></div>

--000000000000603b1b05a10a2b94--