public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Nikhil Mohite <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website
Date: Thu, 20 Aug 2020 09:07:42 +0100
Message-ID: <CA+OCxoy_TUdmca3pB1hgnRKniwQ8-XsKD_2uVTZW9BnTiVuGEA@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0AOcPNT69=Eqd22sNChWUGz6HpMt1qXrs4_pgCP6sO0H7Q@mail.gmail.com>
References: <CAOBg0ANnFFsknDcF6NfLaDVc6x1EFwf_KUO+gbKtR7qvyfAY5A@mail.gmail.com>
<CAOBg0AOcPNT69=Eqd22sNChWUGz6HpMt1qXrs4_pgCP6sO0H7Q@mail.gmail.com>
Hi
On Wed, Aug 19, 2020 at 10:20 AM Nikhil Mohite <
[email protected]> wrote:
> Hi Dave/Team,
>
> As per discussion with the UX team, Few updates on style-guide patch.
> 1. I have missed removing the "proposed" keyword from the "High-Contract"
> theme name.
>
Right.
> 2. I have not added the "Writing Style" section in the style guide as we
> don’t have the information for it (UX design is also pending due to this). @Dave
> Page <[email protected]> can you provide some inputs on it.
>
Sure; not sure how to deal with that yet - we'll proceed without it for now.
A couple of other issues I found:
- Random scrollbars:
[image: Screenshot 2020-08-20 at 09.00.38.png]
- On the Menu section, there is a subsection for "Sub menus" (I realise
you didn't design that, but...). That doesn't seem right; what is described
as a sub menu there is actually a tab set. Can you move it to a separate
section please?
There are a few wording changes I'd like as well, but I can deal with that
when I'm committing.
Nice work - thanks!
>
> Regards,
> Nikhil Mohite.
>
> On Wed, Aug 19, 2020 at 11:40 AM Nikhil Mohite <
> [email protected]> wrote:
>
>> Hi Team,
>>
>> I have updated the style guide for the pgAdmin 4 website as per RM-5990
>> <https://redmine.postgresql.org/issues/5690;.
>> Details :
>> 1. The updated style-guide section as per the new UI design.
>> 2. Added new icons as per font-awesome 5.14.0.
>> 3. Added custom icons of pgAdmin4.
>>
>> PFA the patch.
>>
>>
>> Regards,
>> Nikhil Mohite.
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
Attachments:
[image/png] Screenshot 2020-08-20 at 09.00.38.png (57.0K, 3-Screenshot%202020-08-20%20at%2009.00.38.png)
download | view image
view thread (13+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website
In-Reply-To: <CA+OCxoy_TUdmca3pB1hgnRKniwQ8-XsKD_2uVTZW9BnTiVuGEA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox