Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXScc-00040T-Nu for pgadmin-hackers@arkaria.postgresql.org; Mon, 25 Jun 2018 14:37:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fXSca-0000ap-NT for pgadmin-hackers@arkaria.postgresql.org; Mon, 25 Jun 2018 14:37:36 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXSca-0000ai-F9 for pgadmin-hackers@lists.postgresql.org; Mon, 25 Jun 2018 14:37:36 +0000 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fXScW-0001NN-9c for pgadmin-hackers@postgresql.org; Mon, 25 Jun 2018 14:37:35 +0000 Received: by mail-wr0-x244.google.com with SMTP id w10-v6so13944708wrk.9 for ; Mon, 25 Jun 2018 07:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sx5Ki3TOJIgSPeBSLTlKF7zcbo2JGpU+AVWg8fh69/s=; b=DUcQyudkPDq4vxwy6A4dj1yC/prQsfDsys915yDJa9FoCJrEyysRBgHU6446+I8Fz5 e9iKNxEq9vmPRKFp5mJW2lxbO4VBZMvT8uxzHQLYP3e0dG48h0VI4ndXyV0MWuyX/5xn dfflU7X6iSjb6IORR0cnz8XWM1KapYahksd8NmNrvWGy9nCMHO28+jbTYPXUerXmIWho ITpEcQ0MBl4yKZqX8MAp5Jt4jaOI8NZ3Rdy+RqT98ESo0uaUDUV8IyJarJRPOB5Q5P1h sUNkHnvXOcLDx+Niihpmgph7qaalIouFzZH+7gAQiwLDH/kaL822ZhYpdpE2opNnF+QT VDBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sx5Ki3TOJIgSPeBSLTlKF7zcbo2JGpU+AVWg8fh69/s=; b=pRW/NszBFd3ngUarhPz22wIbxFMzoc28NhHOwYBhQClVtyaQdxTSDFcL2TIHfDBzxT dba7r5u6NjhozR1j7tFQDF60ept7MOMiR0efx4JH/5NmwhgFvDtf8oTlMxJ9A43TNIPi Di9axQZaqctfsFJDQVbS8IoxgpsmGDuwAjL8i+FvFMSXhVF2ZPaBi2yWw7RUn8dEjPWs V4sljEMNkxNG+tOHoy6sjt748Pg8rfbUJ6oAH0FPuqp7KECfSMOfC0XQbjvz0op0yr/D V37cz4dw8wGt7LYShgU15xskkrLqfmMw9rlX6Y5JYMxFO3Xqci6dDdn7BoT/jO1d1SBy Pndw== X-Gm-Message-State: APt69E1jMuVkgDgWkt6ToFDU6j7FhyKWzU1HaLB8/z6xw4t3UsbznmJZ fx0ouvfn+6iTwYDkTOBCbZzasDR2+sV0Z/ruCgNjDDN1 X-Google-Smtp-Source: AAOMgpfmFNOoSRnCVoGLrfPDFMU6LYHBVEP2WStT21Z3q2I9P/mFgefT8cP+nLRi0mQr4XqVLMuCtMcCg10sND2XFes= X-Received: by 2002:adf:8227:: with SMTP id 36-v6mr7060374wrb.144.1529937450917; Mon, 25 Jun 2018 07:37:30 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Mon, 25 Jun 2018 07:37:29 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 25 Jun 2018 15:37:29 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000004a78ca056f7852b1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004a78ca056f7852b1 Content-Type: text/plain; charset="UTF-8" On Mon, Jun 25, 2018 at 3:33 PM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Mon, 25 Jun 2018, 19:47 Dave Page, wrote: > >> Hi >> >> On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch for RM #3309 - Backup does not work with >>> --format=d. >>> >>> Fixes in the patch : >>> >>> 1. Format = directory fix for Backup and Restore utilities >>> 2. Test cases for format = directory >>> 2. File manager fix - The selected directory was not properly populated >>> in the text box >>> >> >> The patch disables the file picker button if you select Directory format. >> This seems like poor behaviour; I think we need to modify the dialogue to >> allow a directory to be selected. >> >> > In the directory format, which ever the folder name given, that will be > created by pg_dump, so I have disabled it. > Sure, but I can't even browse to the location I want to put it now - I have to manually type in the path. We just need to allow selection of the directory that will contain the directory. > 3. Refactoring of File manager JS file >>> >> >> That's somewhat more readable. Can we add tests? >> > Will look into it. > Thanks. > >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000004a78ca056f7852b1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Jun 25, 2018 at 3:33 PM, Khushboo Vashi <<= a href=3D"mailto:khushboo.vashi@enterprisedb.com" target=3D"_blank">khushbo= o.vashi@enterprisedb.com> wrote:


On Mon, 25 Jun 2018, 19:47 Dave Page, <dpage@pgadmin.org> wrot= e:
Hi

On Mon, Jun 25, 2018 at 1:= 23 PM, Khushboo Vashi <khushboo.vashi@ent= erprisedb.com> wrote:
=
Hi,

Please find the attached patch for = RM #3309 - Backup does not work with --format=3Dd.

Fixes in the patch :

1. Format =3D directory fix = for Backup and Restore utilities
2. Test cases for format =3D dir= ectory
2. File manager fix - The selected directory was not prope= rly populated in the text box

T= he patch disables the file picker button if you select Directory format. Th= is seems like poor behaviour; I think we need to modify the dialogue to all= ow a directory to be selected.
=C2=A0
In the directory format, whic= h ever the folder name given, that will be created by pg_dump, so=C2=A0 I h= ave disabled it.

Sure, but I ca= n't even browse to the location I want to put it now - I have to manual= ly type in the path. We just need to allow selection of the directory that = will contain the directory.
=C2=A0
3. Refactoring of File manager JS file

That's somewhat more readable. Can we add tests= ?=C2=A0
<= div dir=3D"auto">Will look into it.

=
Thanks.
=C2=A0

--
Dave Page
Blog: ht= tp://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: = http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--0000000000004a78ca056f7852b1--