Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1snzbh-007TfH-HZ for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 Sep 2024 12:04:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1snzbh-00CFTI-9i for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 Sep 2024 12:04:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1snzbg-00CFT9-WF for pgadmin-hackers@lists.postgresql.org; Tue, 10 Sep 2024 12:04:29 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1snzbc-000Szc-J5 for pgadmin-hackers@postgresql.org; Tue, 10 Sep 2024 12:04:28 +0000 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-53653ee23adso5325038e87.3 for ; Tue, 10 Sep 2024 05:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; t=1725969865; x=1726574665; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L9e27ChfPNHtvL/joOMl2PpKuf7gcsAzp+Uo/eESue0=; b=OE1oWkLoHhcqNjfx0LlSsw4f5Io3liXMFonEGAJE7eqJcV1qUXaEg1Mt0tLwCIk/Rm 9nULK1gD1x6/uCIK4OCPXVzmRCRE9DRYSIlIMO26vZUclh+JU3DisTlZpywGSyVmRFvQ GDjvypgzM2SuRLUZs4zDd16xy+ao4AkvIFR55gKyp3J9DGRigUM1qPwPNsg86aJqUBa7 Ae5M4hJnaiVBS0reCNt+kaEdfQ3tWk+0M2Fsd0bbStxFtgjLeKCQyd9mOu0wOCCnZq21 JpUTU3RmjBrivoQ2LUPji2MacAXBZ+WKCOO4v0kThIhZsBvcnFmpIYGFJn7awnpC1P1D AoZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725969865; x=1726574665; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L9e27ChfPNHtvL/joOMl2PpKuf7gcsAzp+Uo/eESue0=; b=wFokB5N9TJBqZeMyyoc57pBsHyVA8ZofC+JmTpxDcUH2vCFeaOQxohFuKLoYHNVJ7I R83IYUoOSfmYqxp78uUN8/P7z1YzrpgJSCgn8q+Ic8u7A+SSk+Bxe8fhYsYAM1xk0bRC ske8f4PZI1CUzBSOKfgEOoB087VyINEGDMo2M3gnlqg8ILVD10+I66A3p28e7fyljSfR DQQZSyCQ1W8VGouynwyGuh191d8ISsP72UDnX8T+5LjT4HaKP1aVn8zfhqoGln2SGRiD rYAKpiOHn4arwofpyuR0i2JnJsyWDAlVb3oRhC5orfaUsb0d4gx2BkldDyT0h9pm2mOb zSpw== X-Gm-Message-State: AOJu0YwLnz5V6N+b19tirkKLkcL4U7MGTQttaMa0fpsoXON3cPizFf5t y8Fugtw3UCREcDxbq4lGXjyJxbmptsFYj4W9BzAGbXLBIIJ7oUngPRVnm8B5Ijbn78HBfjts0Kc p2dx7MrFz5+GUtDVKINWanl4s4zckyjQMBqcO X-Google-Smtp-Source: AGHT+IFRnYDG2+OUd8QsvFfBroi13IWajE1ZvogWVoGC1M+LyIImsUmuBJ2/yJHtJTB9JkJpm+i1ZuZZ/EEPFV5vH+4= X-Received: by 2002:a05:6512:3baa:b0:52f:d69e:bb38 with SMTP id 2adb3069b0e04-536587aa59fmr8272683e87.2.1725969864401; Tue, 10 Sep 2024 05:04:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 10 Sep 2024 13:04:13 +0100 Message-ID: Subject: Re: Require suggestions for Issue #2874 To: Rohit Bhati Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="000000000000a9444f0621c2ac44" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000a9444f0621c2ac44 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Tue, 10 Sep 2024 at 12:43, Rohit Bhati wrote: > Hi Dave, > > I have made some changes and made the header and serial number row > column color the same. > > Please once check the attached images. > I think that looks much better! Thanks. > > Thanks > > On Tue, Sep 10, 2024 at 2:42=E2=80=AFPM Dave Page wro= te: > >> Hi >> >> Shadow is more visible, but it doesn't really follow the material UI >> styling which is flat rather than 3D. >> >> I think Anil's idea is worth exploring; remove the alternating colour fo= r >> the row number column, and use a different background shade for it entir= ely. >> >> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati >> wrote: >> >>> Hi Dave, >>> >>> I have added shadow to make the text more distinct and attached >>> screenshots based on themes. >>> Please once check and let me know if we can go ahead with this or >>> provide suggestions if need to make changes. >>> >>> Thanks & Regards >>> Rohit Bhati >>> >>> >>> On Mon, Sep 9, 2024 at 4:11=E2=80=AFPM Rohit Bhati >>> wrote: >>> >>>> I already set weight to 900. >>>> If we need to be more distinct then I think we can have some shadow or >>>> if anything else please suggest. >>>> >>>> On Mon, Sep 9, 2024 at 3:29=E2=80=AFPM Dave Page w= rote: >>>> >>>>> Hi >>>>> >>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati < >>>>> rohit.bhati@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> I have made changes as per your suggestions. >>>>>> I have attached screenshots showing how the updates look across all >>>>>> themes for your reference. >>>>>> >>>>>> If the current changes does not fit well with the theme or if you >>>>>> have any suggestions for improvements, please let me know. >>>>>> >>>>> >>>>> The colours etc. look correct now (ie. there are no weird borders), >>>>> but I still don't think the row number looks visually distinct from t= he >>>>> rest of the data. The bold text simply isn't very bold - I think it s= till >>>>> needs more weight. >>>>> >>>>> >>>>> >>>>>> >>>>>> Thanks >>>>>> Rohit Bhati >>>>>> EnterpriseDB >>>>>> >>>>>> >>>>>> On Fri, Sep 6, 2024 at 2:01=E2=80=AFPM Dave Page = wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati < >>>>>>> rohit.bhati@enterprisedb.com> wrote: >>>>>>> >>>>>>>> I have made some more changes with changing background color. >>>>>>>> >>>>>>> >>>>>>> Yeah, that looks weird again, specifically on the selected rows. I >>>>>>> believe the issue is that we should not highlight the row number co= lumn >>>>>>> when a row is selected at all. That makes sense, as we should only = be >>>>>>> highlighting the columns that would get copied in a copy/paste oper= ation >>>>>>> anyway. >>>>>>> >>>>>>> Also, the bold still doesn't look bold. I think the weight needs to >>>>>>> be increased. >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> I have attached screenshots showing how the updates look across al= l >>>>>>>> themes. >>>>>>>> >>>>>>>> On Fri, Sep 6, 2024 at 1:51=E2=80=AFPM Dave Page wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati < >>>>>>>>> rohit.bhati@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> I have removed the border and background color, just made the ro= w >>>>>>>>>> numbers bold. >>>>>>>>>> >>>>>>>>>> I have attached screenshots showing how the updates look across >>>>>>>>>> all themes. >>>>>>>>>> >>>>>>>>> >>>>>>>>> That doesn't look bold at all to me - and I think we still need >>>>>>>>> some other visual distinction, such as the column background colo= ur. >>>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Sep 6, 2024 at 12:35=E2=80=AFPM Khushboo Vashi < >>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11=E2=80=AFPM Dave Page >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi >>>>>>>>>>>> >>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati < >>>>>>>>>>>> rohit.bhati@enterprisedb.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> I have made changes for issue #7863 >>>>>>>>>>>>> based >>>>>>>>>>>>> on theme requirements. >>>>>>>>>>>>> >>>>>>>>>>>>> I have attached screenshots showing how the updates look >>>>>>>>>>>>> across all themes for your reference. >>>>>>>>>>>>> >>>>>>>>>>>>> If the current color does not fit well with the theme or if >>>>>>>>>>>>> you have any suggestions for improvements, please let me know= . >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Is the colour contrast high enough on the row numbers for >>>>>>>>>>>> selected rows in the high contrast theme? The black on grey se= ems like it >>>>>>>>>>>> might not be to me, but I haven't tested. >>>>>>>>>>>> >>>>>>>>>>>> I wonder also if we should make the row numbers bold all the >>>>>>>>>>>> time. Thoughts? >>>>>>>>>>>> >>>>>>>>>>> We can check how it looks. Also the cell border doesn't look >>>>>>>>>>> good to me. >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Dave Page >>>>>>>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>>>>>>> EDB: https://www.enterprisedb.com >>>>>>>>>>>> >>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>>>> EDB: https://www.enterprisedb.com >>>>>>>>> >>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>>>> >>>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>> EDB: https://www.enterprisedb.com >>>>>>> >>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>> >>>>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> pgAdmin: https://www.pgadmin.org >>>>> PostgreSQL: https://www.postgresql.org >>>>> EDB: https://www.enterprisedb.com >>>>> >>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>> >>>>> >> >> -- >> Dave Page >> pgAdmin: https://www.pgadmin.org >> PostgreSQL: https://www.postgresql.org >> EDB: https://www.enterprisedb.com >> >> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >> >> --000000000000a9444f0621c2ac44 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi


On Tue, 10 Sep 2024 at 12:43, Rohit= Bhati <rohit.bhati@ente= rprisedb.com> wrote:
Hi D= ave,

I have made some changes and made the header and serial number = row column=C2=A0color the same.

Please once check the attached image= s.

I think = that looks much better!

= Thanks.

=

Thanks

On Tue, Sep 10, 2024 at 2:42=E2=80=AFPM Dave Page <dpage@pgadmin.org>= wrote:
Hi

Shadow is more visible, but it doesn't really follow the mater= ial UI styling which is flat rather than 3D.

I thi= nk Anil's idea is worth exploring; remove the=C2=A0alternating colour f= or the row number column, and use a different background shade for it entir= ely.

On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <rohit.bhati@enterprisedb.com&= gt; wrote:
Hi=C2=A0Dave,

= I have added shadow to make the text=C2=A0more distinct and attached screenshots based on themes.
Please = once check and let me=C2=A0know if we can go=C2=A0ahead with this or provid= e suggestions if need to make changes.

Thanks & Regards
Rohit= Bhati


On Mon, Sep 9, 2024 at 4:11=E2=80=AFPM Rohit Bhati <rohit.bhati@e= nterprisedb.com> wrote:
I= already set weight to 900.
If we need to be more distinct then I think = we can have some shadow or if anything else please suggest.

On Mon, Sep = 9, 2024 at 3:29=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <= ;rohit.bh= ati@enterprisedb.com> wrote:
Hi Dave,

I have made changes as per your suggestions.
I have = attached screenshots showing how the updates look across all themes for you= r reference.

If the current changes does not fit well with the theme= or if you have any suggestions for improvements, please let me=C2=A0know.<= br>

The colours etc. look correct now= (ie. there are no weird borders), but I still don't think the row numb= er looks visually distinct from the rest of the data. The bold text simply = isn't very bold - I think it still needs more weight.

=C2=A0

Thanks
Rohit B= hati
EnterpriseDB


On Fri, Sep 6, 2024 at 2:01=E2=80=AFPM Dave P= age <dpage@pgadmi= n.org> wrote:


On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <rohit.bhati@enterprisedb.com= > wrote:
I have made some= more changes with changing background color.
Yeah, that looks weird again, specifically=C2=A0on the selecte= d rows. I believe the issue is that we should not highlight the row number = column when a row is selected at all. That makes sense, as we should only b= e highlighting the columns that would get copied in a copy/paste operation = anyway.

Also, the bold still doesn't look bold= . I think the weight needs to be increased.
=C2=A0

I have atta= ched screenshots showing how the updates look across all themes.

On Fri, Sep 6, 2024 at 1:51=E2=80= =AFPM Dave Page <= dpage@pgadmin.org> wrote:
Hi

On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:

That doesn't look bold at all to me - and I think we still need some o= ther visual distinction, such as the column background colour.




On Thu, Sep 5, 2024 at 7:11=E2=80=AFPM Dave = Page <dpage@pgadm= in.org> wrote:
Hi
On = Thu, 5 Sept 2024 at 14:38, Rohit Bhati <rohit.bhati@enterprisedb.com> wrot= e:
Hi,

I have made chang= es for issue #7863=C2=A0based on theme requirements.

I ha= ve attached screenshots showing how the updates look across all themes for = your reference.

If the current color does not fit well with the them= e or if you have any suggestions for improvements, please let me know.
<= /div>

Is the colour contrast high eno= ugh on the row numbers for selected rows in the high contrast theme? The bl= ack on grey seems like it might not be to me, but I haven't tested.
=C2=A0
I wonder also if we should make the row numbers bol= d all the time. Thoughts?
We can check h= ow it looks. Also the cell border doesn't look good to me.


--
Dave PagepgAdmin: https://www= .pgadmin.org
PostgreSQL: https://www.postgresql.org

PGDay UK 2024, 11th September, London:= https://2024.pgday.uk= /



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/

--000000000000a9444f0621c2ac44--