Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkq5V-0003qb-La for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Sep 2016 10:09:41 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bkq5V-0008J5-8a for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Sep 2016 10:09:41 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bkq5H-0007pS-NV for pgadmin-hackers@postgresql.org; Fri, 16 Sep 2016 10:09:27 +0000 Received: from mail-it0-x230.google.com ([2607:f8b0:4001:c0b::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bkq5E-000106-Kk for pgadmin-hackers@postgresql.org; Fri, 16 Sep 2016 10:09:26 +0000 Received: by mail-it0-x230.google.com with SMTP id x192so9523602itb.0 for ; Fri, 16 Sep 2016 03:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RU9kx8syE1/tS/whT0OxrrOaD6kZ5MacM1Ebcsiqiyo=; b=z37arQT+xGIzqEo1iFXjzKpOUJEih17i4ChUv+WNGR1CmXcDSRyJd29tGP9LQbStpm n2ruFRYQIQ9Gyoo2Ensb6QLslelynfPikGoxeDQz4fSbsI9dCsxsmXBud+cxVGAm3ROM CDkhIParm/XfF0oZh7hvxbmRbxNIiFRQttTjXM0qYPYAJag0vVaqErN2Ht0RhDzjQuli 7vl8lffOxIPpMWgu0O5pIMZohEV8zolOZjXAHqz4HLtVDX3c7NTcUWjs0R/0j0Vc//OI hzE1mH4ExLrXaTOXrCENt0kI7ah8jGB6gFBRKjR+ywSGuou1vsqQy9OLXHwwdpF89OoZ 2srA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RU9kx8syE1/tS/whT0OxrrOaD6kZ5MacM1Ebcsiqiyo=; b=SPMo4vfdtoEQj28tCvYDs0kxnF9LB8ZDNrWbaSTCYV0/vlcbNW22cwhYHY8HBpyBbx gIv3fDe0Gi9vccfsBFSqo8s3PBy1JZOmLwVVuROEM48UWLh0ezggNK4wHG8jDCn3l52u u2kVnUQjfEvrrmWpoupwa2iDe0JZIb4HaL6hYr+PjlxYnV6N2mF5Hltm2rg4iFgrlGzt JuRljb3NJwe3VqvU1zDTbAttdT5jy9RyIjVfBe/zYLZH/83pjGFGI8ExdRaUJQz2GZrw IVNfk7rLK72thpFhc5xG1lujKtoNCQ0edBmOOMvmYk/fhCOiE4jBLdCDIE7xfUesOqGi 1N+A== X-Gm-Message-State: AE9vXwNSdLw5tXZlKHBajKyAfQ67xxgtgk9nq3pTS7LFkhYVEb4yC8nYCeW8dnsu45E9UvffvN2FvSXif5ULZw== X-Received: by 10.36.249.129 with SMTP id l123mr4475981ith.103.1474020563317; Fri, 16 Sep 2016 03:09:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Fri, 16 Sep 2016 03:09:22 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 16 Sep 2016 11:09:22 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1669 - Cannot remove nor change length definition on column in "The Table Dialog" To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks, committed. On Thu, Sep 15, 2016 at 11:21 AM, Surinder Kumar wrote: > Hi > > Please find attached patch. >> >> Add proper check for the column length and precision in Jinja template. > > > Please review. > > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers