Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpUow-000236-Ph for pgadmin-hackers@arkaria.postgresql.org; Mon, 22 Jul 2019 09:41:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hpUou-0001g9-Vy for pgadmin-hackers@arkaria.postgresql.org; Mon, 22 Jul 2019 09:41:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpUou-0001g2-Dw for pgadmin-hackers@lists.postgresql.org; Mon, 22 Jul 2019 09:41:24 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hpUon-00063O-5r for pgadmin-hackers@postgresql.org; Mon, 22 Jul 2019 09:41:23 +0000 Received: by mail-wm1-x341.google.com with SMTP id v19so34626576wmj.5 for ; Mon, 22 Jul 2019 02:41:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6PrH6d49p5dzCxBguf/3Cszje/emVJNgS/RwpS71GG8=; b=dXq6iv0+U5cZMavyywJPs5WVz13IjAwbVVpVLW9+BMi+Q16J+HDXWQ8yPHFB34popE 8hItGuTDyqajiP7G2TPZY+rAhooDOfcDUfCYEV4WAqTUC6cgRwyl3iX8A3Em87Lg3Mok 25E+V9vjlnyKTqaSG4E4VQWLUzbuuwQ39REuALGnMRa9RQLtGM2B4M/kjCscDHasP+eP sRAe7jeg6tUPc3kmixYjoVWA2SwcxiQXA9IprU6bt9shr1OQCfhyoWn/7ThXFyD/dvFS +chKm4zFVIp4IjibFbv2+ho6qU2JqBt6JoK8J/ETiiEvbmbNZuRJERivoC/w0rqETUxG xF4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6PrH6d49p5dzCxBguf/3Cszje/emVJNgS/RwpS71GG8=; b=PmtVQxpXOCyjZcUi2SV1lgi7pbQFNX1t+uKyt+yTvSBjlTwIqhSEUTEqKSQqEkwIcG Z3zWTDy9vLclfPLCdSi1UX21L99mWRMep6QEW4gyKWL5/J85Q4mTVX/sljrTp2fQsVz2 BNwj7TrtqcPO3cnjN6r//raOtgECSVKaogS/fRcJyq8JEdpbnjqRz2heZC0ITVEv/pKa JwV5GPAoUvDnr5xZKXbR6CriiIoTCtPc06Y8X9/90P07mCMPr9IndYPwCO5GPExx4A/r paozkJUDwo1w4cPl3ArbM/MS9NQieVFW8B/7tk2ZXcQtZ3ZPWAYE2ZrXVWQ9s49A6/lm 61tg== X-Gm-Message-State: APjAAAUFlIn9mF8YhZlIhURJQP2IFtpQ48Wm81K00crYaCSveED2/qDd KsL4IVZ326Cm3XpyfovisCpkP9uFQf2C533cXTYZIULhtmE= X-Google-Smtp-Source: APXvYqwYEoebj+g58c6SLYGM3nSwXpCdUMY/J9nuQu3Gh9ED6ztkDGsmZMedW2KKWW3aguSBINkulGTIadEOvjiYgZE= X-Received: by 2002:a1c:7f08:: with SMTP id a8mr11872078wmd.1.1563788473129; Mon, 22 Jul 2019 02:41:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 22 Jul 2019 10:41:00 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM #4333 - Add support for function selectivity. To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000071f276058e41e0e6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000071f276058e41e0e6 Content-Type: text/plain; charset="UTF-8" On Mon, Jul 22, 2019 at 9:59 AM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Mon, Jul 22, 2019 at 2:07 PM Dave Page wrote: > >> Hi >> >> In the Trigger and Type dialogues when selecting a function we give a >> combo box listing all the functions in the database that match the required >> signature. Can't we do this here as well? >> > Support function should have specific arguments and return type (i.,e. > internal), and the user needs to write the code for that function in the C. > So, what should we consider here? > Not sure what you're asking. I suggest we list all functions that match the required signature and are written in C, much as we do elsewhere. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000071f276058e41e0e6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Jul 22, 2019 at 9:59 AM Khush= boo Vashi <khushboo.v= ashi@enterprisedb.com> wrote:


On Mon, Jul 22, = 2019 at 2:07 PM Dave Page <dpage@pgadmin.org> wrote:
Hi
<= /div>

In the Trigger and Type dialogues when selec= ting a function we give a combo box listing all the functions in the databa= se that match the required signature. Can't we do this here as well?
Support function should have specific arguments = and return type (i.,e. internal), and the user needs to write the code for = that function in the C.
So, what should we consider here?

Not sure what you're asking.= I suggest we list all functions that match the required signature and are = written in C, much as we do elsewhere.
=C2=A0
--
<= div dir=3D"ltr" class=3D"gmail_signature">Dave Page
Blog: http://pgsnake.blogspot.com=
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company
--00000000000071f276058e41e0e6--