MIME-Version: 1.0
In-Reply-To: 
 <CANxoLDeuyz5d1+kKmpXiSdDMmtRGnKV+6dNmvtHeBTPjw6XV3w@mail.gmail.com>
References: 
 <CANxoLDeuyz5d1+kKmpXiSdDMmtRGnKV+6dNmvtHeBTPjw6XV3w@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 16 Dec 2016 11:52:50 +0000
Message-ID: 
 <CA+OCxoye7d0F8dt8UKAQan2b+fzVB=v919=MTkwVZ4R-wx3Hug@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM #1807 Query Tool Does Not
 Recognize When File Changes Have Been Saved
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=001a114abd02a236930543c535a5
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a114abd02a236930543c535a5
Content-Type: text/plain; charset=UTF-8

Hi

On Fri, Dec 16, 2016 at 8:47 AM, Akshay Joshi <akshay.joshi@enterprisedb.com
> wrote:

> Hi All
>
> Please find the attached patch to fix the RM #1807 Query Tool Does Not
> Recognize When File Changes Have Been Saved.
>

If I open a file with the patch applied, and make a change (add a space to
the end), it's correctly detected.

If I then undo the change by deleting the space, the file is still marked
as dirty.

If I then clear the window entirely, the save button is disabled, but the
tab still shows the file is dirty (the *).

Also - the patch seems to undo the change I made
in 4a280b251755091af9bf56bcdee964601df104ae.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a114abd02a236930543c535a5
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Fri, Dec 16, 2016 at 8:47 AM, Akshay Joshi <span dir=3D"ltr">&lt;<=
a href=3D"mailto:akshay.joshi@enterprisedb.com" target=3D"_blank">akshay.jo=
shi@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20=
4);padding-left:1ex"><div dir=3D"ltr"><span style=3D"font-size:13px">Hi All=
</span><div style=3D"font-size:13px"><br></div><div style=3D"font-size:13px=
">Please find the attached patch to fix the RM=C2=A0#1807 Query Tool Does N=
ot Recognize When File Changes Have Been Saved.</div></div></blockquote><di=
v><br></div><div>If I open a file with the patch applied, and make a change=
 (add a space to the end), it&#39;s correctly detected.=C2=A0</div><div><br=
></div><div>If I then undo the change by deleting the space, the file is st=
ill marked as dirty.=C2=A0</div><div><br></div><div>If I then clear the win=
dow entirely, the save button is disabled, but the tab still shows the file=
 is dirty (the *).</div><div><br></div><div>Also - the patch seems to undo =
the change I made in=C2=A04a280b251755091af9bf56bcdee964601df104ae.</div></=
div><div><br></div>-- <br><div class=3D"gmail_signature">Dave Page<br>Blog:=
 <a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.b=
logspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"htt=
p://www.enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a>=
<br>The Enterprise PostgreSQL Company<br></div>
</div></div>

--001a114abd02a236930543c535a5--