Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aYcau-000310-4t for pgadmin-hackers@arkaria.postgresql.org; Wed, 24 Feb 2016 16:47:20 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aYcat-0001ck-JQ for pgadmin-hackers@arkaria.postgresql.org; Wed, 24 Feb 2016 16:47:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aYcat-0001cZ-09 for pgadmin-hackers@postgresql.org; Wed, 24 Feb 2016 16:47:19 +0000 Received: from mail-io0-x230.google.com ([2607:f8b0:4001:c06::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aYcap-0007Lr-8R for pgadmin-hackers@postgresql.org; Wed, 24 Feb 2016 16:47:18 +0000 Received: by mail-io0-x230.google.com with SMTP id l127so50928754iof.3 for ; Wed, 24 Feb 2016 08:47:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=oTPwrOPWKy/Mb+Hse3LcahTHkc28n+AZS0pJZJD9P3c=; b=JqnhuiCov5C8qg0D9RHGSi3tCImC1sHURBQZpOHPtLV1pE5axZVyyVILgchE/OBWj1 S4cWx/Szl+jyOOaktn0mpj6A3X+qAbUPiLUQCUbx3gznQ8wXnqe/2sdjLUKM+mpvlFlx QyW1+ko0NOHdYSyHvV8hjs1m3JKb7Dxxoj0gEb98n47Oyj2frPne1osGj1pQA0Kx5UJr GqE5qBU+Yce39KdiLCVrDwRtVmqBkAMKArZd9afHvbq79K2tXaf/RC45xvGy1yCMgY3L +FccPXdxdNiASputg/cgtZf7tvnnfF8LDnNou2FgF7Ygwmuw5VYrP/SsyAKGoqhGOO1S z/lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=oTPwrOPWKy/Mb+Hse3LcahTHkc28n+AZS0pJZJD9P3c=; b=mufklYrTXlPuiH+X000Ti8wJSwcGHYgi8FZcP3/BJB+mM6cjtZV8F26ZpiVVgQ7deH wwXkGUn3gtnxoCpGWdF9HT6kgQTgDCwJTWR5yfL8NUeih2SFd//jkMMfFoZ93QEJmmK2 FovjRRY4vsEpG/hxovcpqLUHEWZ7ohTMnaPPh/qZaq7s/IJq80EfOCrEx0rM1/uL97uX tjhuhK51AT1rj/U08Vl3b83fENzsTFJzPtwCSn0u7BObju5oSPtuQkhoM3YQuFsp3wCO 48y4kCzd6ajuvHcp+oa7AefZaIyzAqN7bNwjne/m5cLSwIEBEXFj2wX0UQurZuLsk89p slfA== X-Gm-Message-State: AG10YOTWuP3wIPBJ2CNQFOLSJfHfL73H6T7ePiF69yyA1DbbsZSBGk/24LNchpu9ShSRBpNR2zRx7H/VvMDP2A== MIME-Version: 1.0 X-Received: by 10.50.73.133 with SMTP id l5mr23020351igv.69.1456332432703; Wed, 24 Feb 2016 08:47:12 -0800 (PST) Received: by 10.64.90.3 with HTTP; Wed, 24 Feb 2016 08:47:12 -0800 (PST) In-Reply-To: References: Date: Wed, 24 Feb 2016 16:47:12 +0000 Message-ID: Subject: Re: [pgAdmin4] [Patch]: Extension Module From: Dave Page To: Surinder Kumar Cc: Neel Patel , pgadmin-hackers Content-Type: multipart/alternative; boundary=089e0129483a539f30052c86d1f3 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e0129483a539f30052c86d1f3 Content-Type: text/plain; charset=UTF-8 Thanks - committed. On Tue, Feb 23, 2016 at 11:07 AM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi, > > PFA patch with changes suggested by Dave > > Please review the patch and let me know for any comments. > > On Mon, Feb 15, 2016 at 4:37 PM, Dave Page wrote: > >> Hi >> >> On Mon, Feb 15, 2016 at 9:55 AM, Surinder Kumar < >> surinder.kumar@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch with following changes: >>> >>> 1. Added "Create Extension" menu item in context menu of Database >>> node. >>> 2. Added a new method "node_node" in ExtensionModule class. If a >>> node has child, returns True, otherwise False. >>> 3. Fixed an issue in which icon won't display in create extension >>> link in context menu. >>> 4. Added Docstring for the class and methods in python file and >>> proper commenting in js file. >>> 5. Followed PEP-08 coding conventions. >>> >>> >> I haven't tested this, but a few initial comments: >> >> - The commenting of the JS code is better than I've seen in other patches >> \o/, but the commenting style is inconsistent. We should use /* */ for >> multi-line comments, and // for single line. >> - The JS code could use some carefully introduced blank lines to help >> make it more readable. >> > Done > >> - s/}else{/} else {/ >> > Done > >> - Dependency/depends display is missing (see previous email to Akshay). >> This is essential for this node! >> > Implemented dependency and depends > >> - There's no pydoc comment introducing __init__.py >> > Added pydoc > >> - Shouldn't "data='-- Modified SQL --'," be "data=gettext('-- Modified >> SQL --'),"? >> > Yes, it should be. Fixed. > >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --089e0129483a539f30052c86d1f3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks - committed.

On Tue, Feb 23, 2016 at 11:07 AM, Surinder Kumar <= span dir=3D"ltr"><surinder.kumar@enterprisedb.com> wrote:
Hi,

PFA patch with changes suggested by Dave

Please review the patch and let me know fo= r any comments.

On Mon, Feb 15, 2016 at 4:37 PM, Dave Page <dpage@pgadmin.org&g= t; wrote:
Hi

On Mon, Feb 15, 2016 at 9:55 A= M, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,=C2=A0

<= div>PFA patch with following changes:
  1. Added "Create = Extension" menu item in context menu of Database node.
  2. Added a= new method "node_node" in ExtensionModule class. If a node has c= hild, returns True, otherwise False.
  3. Fixed an issue in which icon w= on't display in create extension link in context menu.
  4. Added Do= cstring for the class and methods in python file and proper commenting in j= s file.
  5. Followed PEP-08 coding conventions.

I haven't tested this, but a few = initial comments:

- The commenting of the JS code = is better than I've seen in other patches \o/, but the commenting style= is inconsistent. We should use /* */ for multi-line comments, and // for s= ingle line.
- =C2=A0The JS code could use some carefully introduc= ed blank lines to help make it more readable.
Done=C2=A0
- s/}= else{/} else {/
Done=C2=A0<= /div>
- Dependency/depends display is mis= sing (see previous email to Akshay). This is essential for this node!
=
Implemented dependency and depen= ds=C2=A0
- There's no pydoc com= ment introducing __init__.py
Added pydoc
- Shouldn't "= ;data=3D'-- Modified SQL --'," be "data=3Dgettext('--= Modified SQL --'),"?
<= div>Yes, it should be. Fixed.=C2=A0
=




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y
--089e0129483a539f30052c86d1f3--