Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hacxZ-0002i2-Vl for pgadmin-hackers@arkaria.postgresql.org; Tue, 11 Jun 2019 09:20:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hacxX-0000Ml-CB for pgadmin-hackers@arkaria.postgresql.org; Tue, 11 Jun 2019 09:20:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hacxX-0000ME-17 for pgadmin-hackers@lists.postgresql.org; Tue, 11 Jun 2019 09:20:51 +0000 Received: from mail-it1-x144.google.com ([2607:f8b0:4864:20::144]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hacxP-00006K-O2 for pgadmin-hackers@postgresql.org; Tue, 11 Jun 2019 09:20:49 +0000 Received: by mail-it1-x144.google.com with SMTP id m138so3682617ita.4 for ; Tue, 11 Jun 2019 02:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oPCJBOQ9VS3nOMkWLSrSpBdVB9HoSYRHX3E5gdWBFeg=; b=cOcFTIj5iiGXcujbn4uYB12TPaVlpY3h4f9b/5jVcR+rPUmfBsYVpTnxUAftof1pYo ZLSgn76jjlw1vGGg9V4wU5SUx1elbQr2dCvZEllhYFokCxYj4aDikgH2FjWlV3Ba3mX5 B4NA96sS4J7DldqO/svAI5VbD1668W4bAze9c9yIDN6k0wzvdwOqVej+gwVXYeJrSHZF omNRCotnCEALEQLZUkYFBk1hZmkt/xs2D+QE7hLvKJSfQdgvwMLkwSX+Pzs69o3JAcVu srQ+U0nPflqqye5Pt4dxkGxivubKwRhrYlfz7eRjihQxyatQTMkN8MU6Zwvvmia0tm/D 2Gcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oPCJBOQ9VS3nOMkWLSrSpBdVB9HoSYRHX3E5gdWBFeg=; b=BuYBFTYSp0snSuoFKncZKHMhHz278W0dBwlE89ao8lOV1JaSlZoAtLj0jZpEHQX4Hc FUxLOY2WT/XP90fw3WnOhN/eb7AxA9z5OP6DJpXZd+yb5NoMGnX8aOjYbx7WudLn0KPL nIySaT71gqae9yeF1qbbnJQrhOHiw3FPwuFsLhz0JY2JWWlXKAX4CrTeXEnShGfnGyWx vmhXyFpXi+H83k+5ju/oO4I+pNZY5q9c9OPEWpIFPae+DNRTSQsD+/IkoxxHCtToiknu 58+OSn4nLM8P8VNEWgA4x/KD0cFznkB5Ba+FCNUj81aT2qkQ2kKtUKMRBqvT0bBX01UG D2Hw== X-Gm-Message-State: APjAAAVHs0VvnGe7KC3Jo4TXcP/LcxcjPOr4jm0LxrKHH2gds4OgycVw sBWDEuPNxYYs4J6zzi1G6/QhwGAbLTke8qbU0YpjcGZExC7j8A== X-Google-Smtp-Source: APXvYqz1RX1JZdPlIYHNRJ4Am9uWmiIGc2PxX2PkMZnNmewdJQkqziQSnLG2/kK5OoIguJIfWDPJBO/x4nTwrIiOJu8= X-Received: by 2002:a05:660c:c1:: with SMTP id q1mr16457658itk.103.1560244842778; Tue, 11 Jun 2019 02:20:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 11 Jun 2019 10:20:31 +0100 Message-ID: Subject: Re: [pgAdmin][RM4228] Incorrect table listed in panel header To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000009de7ca058b08cfa2" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009de7ca058b08cfa2 Content-Type: text/plain; charset="UTF-8" Hi This doesn't pass the feature tests: ====================================================================== ERROR: runTest (pgadmin.feature_tests.browser_tool_bar_test.BrowserToolBarFeatureTest) Browser tool bar feature test ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/browser_tool_bar_test.py", line 55, in runTest self.test_filtered_rows_tool_button() File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/browser_tool_bar_test.py", line 112, in test_filtered_rows_tool_button ".alertify .ajs-header[data-title='Data Filter']") File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 305, in find_by_css_selector lambda driver: driver.find_element_by_css_selector(css_selector) File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 485, in wait_for_element self._wait_for("element to exist", element_if_it_exists) File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line 560, in _wait_for "Timed out waiting for " + waiting_for_message File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.7/site-packages/selenium/webdriver/support/wait.py", line 80, in until raise TimeoutException(message, screen, stacktrace) selenium.common.exceptions.TimeoutException: Message: Timed out waiting for element to exist On Tue, Jun 11, 2019 at 8:35 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix incorrect label on panels when using filtered > rows. > I've also moved redundant code for filter data in datagrid.js to > show_data.js, reusing the existing code of view/edit data. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000009de7ca058b08cfa2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

This doesn't pass the feature te= sts:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D
ERROR: runTest (pgadmin.feature_tests.browser_tool_bar_t= est.BrowserToolBarFeatureTest)
Browser tool bar feature test
--------= --------------------------------------------------------------
Traceback= (most recent call last):
=C2=A0 File "/Users/dpage/git/pgadmin4/we= b/pgadmin/feature_tests/browser_tool_bar_test.py", line 55, in runTest=
=C2=A0 =C2=A0 self.test_filtered_rows_tool_button()
=C2=A0 File &quo= t;/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/browser_tool_bar_test= .py", line 112, in test_filtered_rows_tool_button
=C2=A0 =C2=A0 &qu= ot;.alertify .ajs-header[data-title=3D'Data Filter']")
=C2= =A0 File "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadm= in_page.py", line 305, in find_by_css_selector
=C2=A0 =C2=A0 lambda= driver: driver.find_element_by_css_selector(css_selector)
=C2=A0 File &= quot;/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py= ", line 485, in wait_for_element
=C2=A0 =C2=A0 self._wait_for("= ;element to exist", element_if_it_exists)
=C2=A0 File "/Users/= dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py", line= 560, in _wait_for
=C2=A0 =C2=A0 "Timed out waiting for " + wa= iting_for_message
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/l= ib/python3.7/site-packages/selenium/webdriver/support/wait.py", line 8= 0, in until
=C2=A0 =C2=A0 raise TimeoutException(message, screen, stackt= race)
selenium.common.exceptions.TimeoutException: Message: Timed out wa= iting for element to exist


On Tue, Jun 11, 2019 at = 8:35 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

At= tached is the patch to fix incorrect label on panels when using filtered ro= ws.
I've also moved redundant code for filter data in= datagrid.js to show_data.js, reusing the existing code of view/edit data.<= /div>
=
Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2= =A0Pune
<= div>"D= on't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--0000000000009de7ca058b08cfa2--