MIME-Version: 1.0
References: 
 <CAM9w-_kU7FWKee=BB7wZYnN5cNt0AQ=bZX-0jS3BdMs8rpUPjw@mail.gmail.com>
In-Reply-To: 
 <CAM9w-_kU7FWKee=BB7wZYnN5cNt0AQ=bZX-0jS3BdMs8rpUPjw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 1 Nov 2019 15:22:40 +0000
Message-ID: 
 <CA+OCxoyemtZ7k9Kgrf70xopLDE+Bo3LSp-eAa82=c5+aV4Xs5w@mail.gmail.com>
Subject: Re: [pgAdmin][RM4451]Cannot construct SQL script for composite type
 having only one field variable
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000273d2205964a8aa0"
Precedence: bulk

--000000000000273d2205964a8aa0
Content-Type: text/plain; charset="UTF-8"

Thanks, patch applied.

On Fri, Nov 1, 2019 at 9:54 AM Aditya Toshniwal <
aditya.toshniwal@enterprisedb.com> wrote:

> Hi Hackers,
>
> pgAdmin allows to create composite type only with 2 or more members.
> Attached is the patch to remove the restriction as PostgreSQL allows zero
> or more and fix the issue where SQL is not generated for types having less
> than 2 members.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000273d2205964a8aa0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks, patch applied.</div><br><div class=3D"gmail_quote"=
><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Nov 1, 2019 at 9:54 AM Adity=
a Toshniwal &lt;<a href=3D"mailto:aditya.toshniwal@enterprisedb.com">aditya=
.toshniwal@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gm=
ail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,=
204,204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_default" st=
yle=3D"font-family:verdana,sans-serif">Hi Hackers,</div><div class=3D"gmail=
_default" style=3D"font-family:verdana,sans-serif"><br></div><div class=3D"=
gmail_default" style=3D"font-family:verdana,sans-serif">pgAdmin allows to c=
reate composite type only with 2 or more members.</div><div class=3D"gmail_=
default" style=3D"font-family:verdana,sans-serif">Attached is the patch to =
remove the restriction as PostgreSQL allows zero or more and fix the issue =
where SQL is not generated for types having less than 2 members.</div><div =
class=3D"gmail_default" style=3D"font-family:verdana,sans-serif"><br></div>=
<div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">Kindl=
y review.</div><div><br></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><div=
><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><font size=3D=
"2" color=3D"#000000" face=3D"verdana, sans-serif">Thanks and Regards,</fon=
t><div><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2" c=
olor=3D"#000000" face=3D"verdana, sans-serif">Aditya Toshniwal</font></span=
></div><div><font face=3D"verdana, sans-serif"><span style=3D"background-co=
lor:rgb(255,255,255)"><font size=3D"2" color=3D"#000000">Sr. Software Engin=
eer |=C2=A0EnterpriseDB India |=C2=A0</font></span><span style=3D"color:rgb=
(0,0,0)">Pune</span></font></div><div><font color=3D"#38761d" face=3D"verda=
na, sans-serif" size=3D"1">&quot;Don&#39;t Complain about Heat, Plant a TRE=
E&quot;</font></div></div></div></div></div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blo=
gspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @p=
gsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" targ=
et=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL =
Company<br></div>

--000000000000273d2205964a8aa0--