public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: Joao De Almeida Pereira <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Experiencing issues
Date: Fri, 23 Mar 2018 10:14:27 +0000
Message-ID: <CA+OCxoyf1cdYfNqX_NemaaJ_3mn6MiaoJocyjcZqxDwOyo_ZhA@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELdtE9dJz9Raw3nXJ3qgo+ZjVRUmdNta7Bk5Pf3=O137eQ@mail.gmail.com>
References: <CAE+jja=24CGbB8kBXnKNNRT4n=t=f1hNYAi+iMNgZPhvtaJ_kQ@mail.gmail.com>
<CAFOhELdND4ZwmPk2D+MDYERWsiFqUHjLBwLUJ0ZasgYqva+ZSg@mail.gmail.com>
<CAE+jjamAJh82ZPN59R+-4bFROQccARKwG8YPS3Xtt9M8qm_mww@mail.gmail.com>
<CAKKotZT2M1q=0mfYrw13DSD8Og3ZYsfzt3sc8Y2sRiy7565uVA@mail.gmail.com>
<CAE+jjamnndMfhN-tnQmczY6NrNRVRdyeVVQ3RcE8SiKcg_HhSA@mail.gmail.com>
<CAFOhELdroDKmtNFS4T=ha=d35knfw8dmr2G6Cx0+5gmDqC+eKw@mail.gmail.com>
<CAE+jjanHFe7Di5HASmQUQRWzCg+qQMpZEK7K9GmD7mQVC1bPMA@mail.gmail.com>
<CAFOhELconM+iXeEAxeYNt5XU3UoE640tLK8V5839q4i4rtGoYA@mail.gmail.com>
<CAE+jja=LBv-u5oXt=8JucnUC7NdYq06FqP6K6-w199ozg0emOQ@mail.gmail.com>
<CAFOhELcfBBU30Qnzj6O-XtwwMBT-fN1AewX+MFsfa6_VL0rmmA@mail.gmail.com>
<CAE+jjak5GMg3cOvX5PLVO56r1HhdwwoF6frRq4GzNeF_9zX32A@mail.gmail.com>
<CA+OCxozhkY_s1YC0BmrYrwfV59QCF8pCXyNiErDmf7ebj+tJWw@mail.gmail.com>
<CAFOhELdtE9dJz9Raw3nXJ3qgo+ZjVRUmdNta7Bk5Pf3=O137eQ@mail.gmail.com>
On Fri, Mar 23, 2018 at 6:17 AM, Khushboo Vashi <
[email protected]> wrote:
> Hi,
>
> On Wed, Mar 21, 2018 at 9:31 PM, Dave Page <[email protected]> wrote:
>
>>
>>
>> On Wed, Mar 21, 2018 at 3:57 PM, Joao De Almeida Pereira <
>> [email protected]> wrote:
>>
>>> Sorry I did not understand what you said.
>>> This configuration:
>>>
>>> DEFAULT_SERVER = '0.0.0.0'
>>> SESSION_COOKIE_DOMAIN = DEFAULT_SERVER
>>> COOKIE_DEFAULT_DOMAIN = DEFAULT_SERVER
>>>
>>> If the application lives in the domain pgadmin.somedomain.com do I need
>>> to have in config_local:
>>> DEFAULT_SERVER = '0.0.0.0'
>>> SESSION_COOKIE_DOMAIN = 'pgadmin.somedomain.com'
>>> COOKIE_DEFAULT_DOMAIN = 'pgadmin.somedomain.com'
>>> ?
>>>
>>> Does this mean that if for some reason I have a second domain like
>>> pgadmin.somedomain2.com that I want to use I cannot?
>>>
>>> The issue of 127.0.0.1 to localhost is very cumbersome, and somehow we
>>> should be able to disable this, because when we are developing doesn't make
>>> sense to not being able to use localhost and 127.0.0.1
>>>
>>
>> +1. I didn't realise we'd added this restriction when I tested the patch.
>>
>> Perhaps a better approach would be to leave the default cookie handling
>> as it was, and just expose the domain and path via config options that the
>> user can set if appropriate for their installation.
>>
>> Please find the attached updated patch as discussed.
>
> If one has to set cookie domain and path then below *config variables*
> should be changed.
>
> COOKIE_DEFAULT_PATH
> COOKIE_DEFAULT_DOMAIN
> SESSION_COOKIE_DOMAIN
>
Thanks, applied.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (22+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Experiencing issues
In-Reply-To: <CA+OCxoyf1cdYfNqX_NemaaJ_3mn6MiaoJocyjcZqxDwOyo_ZhA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox