MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D9Nwm2SKkaRpWpMy=95RhKO+qm1O9TvhXE8dmCiUFe1Cw@mail.gmail.com>
References: 
 <CAM5-9D9Nwm2SKkaRpWpMy=95RhKO+qm1O9TvhXE8dmCiUFe1Cw@mail.gmail.com>
Date: Fri, 18 Mar 2016 15:28:14 +0000
Message-ID: 
 <CA+OCxoyfVBMqgLC7EevtULMg_pGu5voMmfST6k_eZ7rFsy=omg@mail.gmail.com>
Subject: Re: Control for displaying "auto vacuum" fields
 into grid
From: Dave Page <dpage@pgadmin.org>
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

On Fri, Mar 18, 2016 at 10:37 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi,
>
> PFA control for displaying auto vacuum fields into grid. This control is
> common for
> Materialized View Node and Table Node.
>
> Usage:
>
> {
>   id: 'vacuum_table', label: '{{ _("Vacuum Table") }}',
>   model: VacuumTableModel, editable: false, type: 'collection',
>   canEdit: true, group: '{{ _("Table") }}',
>   mode: ['edit', 'create'], url: 'get_vacuum_defaults',
>   control: Backform.VacuumCollectionControl.extend({
>     grid_columns :[
>       {
>         name: 'label', label: '{{ _("Label") }}',
>         cell: 'string', editable: false
>       },
>       {
>         name: 'value', label: '{{ _("Value") }}',
>         cellFunction: cellFunction, editable: function(m) {
>           if(m.handler.has('autovacuum_enabled')) {
>             return m.handler.get('autovacuum_enabled');
>           }
>           return !m.handler.isNew();
>         }
>       },
>       {
>         name: 'setting', label: '{{ _("Default value") }}',
>         cellFunction: cellFunction, editable: false
>       }
>     ]
>   }),
>
>
> When using this control, provide following parameters in schema:
> 1. model
> 2. url - to fetch default values for auto vacuum fields.
> 3. grid columns - Name of the columns to display in the grid.
>
>
> Please review the patch.

It's hard to review this without being able to test. Do you have a
simple test case?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers