Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bsUmi-0001D0-4R for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 13:01:56 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bsUmh-00035n-NZ for pgadmin-hackers@arkaria.postgresql.org; Fri, 07 Oct 2016 13:01:55 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bsUmh-00033k-07 for pgadmin-hackers@postgresql.org; Fri, 07 Oct 2016 13:01:55 +0000 Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bsUmc-0006QT-Ns for pgadmin-hackers@postgresql.org; Fri, 07 Oct 2016 13:01:53 +0000 Received: by mail-io0-x236.google.com with SMTP id r30so46155735ioi.1 for ; Fri, 07 Oct 2016 06:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CMy3N2VTmLXWVEZx1+WwKhF5wT1Ua7wBvCIc+/HVESw=; b=0M+DoST1g3rAKGevQdkuH52kStQ2vVW4wXwe/Pp8mAeWoeMaRub55bf0USh1gXqpLS SWl4pmpwbhkDhz92QBzTzEcZirmiviNY7SVEmtXaLh5QoMQrRRfgBMX2/1SaKZLqsHMO pYYMsoKxmqwsob2sj3u3+rKKZJHFqyk8C8pd7UVKTi/0wOZOZ4LktHMiPbD76uJpMsax EGqLjEaXi2JwSeX6CV8uAXOFZYvh/NSYgaqfy6sZHCcEp1I5EwwHMTM/PzPBCkcLXb9E ne+8d938U6+XQkZ3Q9wwD2T9mrxHg0j969DqplW/06k2o8a1EwaEbNLmxFL2QaOr6usz irVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CMy3N2VTmLXWVEZx1+WwKhF5wT1Ua7wBvCIc+/HVESw=; b=K9KN20GYlTSgNp1tUABISL0Ed5Z1c8Ddxmk0UQPIiXeGIL8ICrkG+KMU7wXtfEuVTq fVjdjGMNvPFFXwHdbTUhps6Sy7FofyDwjqLeYNwn1RxYU94o9ZNepovYVFHmJ7lmc1mk T4OJrtqBn9GL6HyCmmqGfo4GLkiVc5CZfGGlI5KXlYifwDmFdPsRQAbWwrjydSh2NPsl QOLaCWLO1p36jgCAKk/ZEJnrKI/Lb9JhXddA88x9PpqeBM+qTOl3825f7zi1Q0x05Lef J1VSvLtfgVGyFwt+zWyQHL6BAe15DEvf5PvuhQQvACSrv/VU/0u6qdAPG3bZXcLY4qyG 3V4g== X-Gm-Message-State: AA6/9RmyjVAD+u0ZtXypxyk8nqtQ1jJcel3iJvNxU63JKkeX/WJgA+YQRgz1dox53vi5YmIDCnQ6yiXp9pz/iHb+rPIfetLDZZnN2qBOfQ6FwUP1rRwcc3oGQ/p3UUOGetIyjYhLMjpGqa58KNwsFcPq74aYah3aU/1+JevR4ODFv9F+l5BqcQhZ+fnJl4WQnX/xJC9Jfg== X-Received: by 10.107.143.13 with SMTP id r13mr24203655iod.24.1475845309207; Fri, 07 Oct 2016 06:01:49 -0700 (PDT) Received: from mail-it0-f45.google.com (mail-it0-f45.google.com. [209.85.214.45]) by smtp.gmail.com with ESMTPSA id i102sm7616559iod.10.2016.10.07.06.01.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Oct 2016 06:01:48 -0700 (PDT) Received: by mail-it0-f45.google.com with SMTP id o19so15539577ito.1 for ; Fri, 07 Oct 2016 06:01:48 -0700 (PDT) X-Received: by 10.36.6.130 with SMTP id 124mr19695369itv.94.1475845307699; Fri, 07 Oct 2016 06:01:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Fri, 7 Oct 2016 06:01:47 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 7 Oct 2016 14:01:47 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: pgAdminIV : Regression tests code cleanup To: Navnath Gadakh Cc: pgadmin-hackers , Kanchan Mohitey Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.1 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Awesome - the test suite just found it's first bug! There was a code path that referenced a variable that hadn't been defined, added in a patch that I committed earlier without spotting the issue. The associated tests failed, and I pretty quickly spotted (and fixed) the bug as a result :-D Patch applied! On Fri, Oct 7, 2016 at 1:43 PM, Navnath Gadakh wrote: > Hi Dave, > Please find the patch of test framework, which contains > 1. Code changes (due to drop objects functionality). > 2. Quoting for database names in drop databases. > 3. Code changes for import errors for pickle_path and advanced_config > variables. > > Run test suite by this command: > python runtests.py > > Thanks. > -- > Regards, > Navnath Gadakh > > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers