Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQAKC-0001C0-I9 for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Oct 2020 14:21:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kQAKB-0005tp-9C for pgadmin-hackers@arkaria.postgresql.org; Wed, 07 Oct 2020 14:21:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPlY3-0004Fs-Hb for pgadmin-hackers@lists.postgresql.org; Tue, 06 Oct 2020 11:54:27 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kPlY0-0007VZ-Mj for pgadmin-hackers@postgresql.org; Tue, 06 Oct 2020 11:54:26 +0000 Received: by mail-ej1-x62e.google.com with SMTP id ly6so15927072ejb.8 for ; Tue, 06 Oct 2020 04:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IqB19AezN8lCqUw0ALVQMBlzUJgvm2Y/RyZ/V8zAttE=; b=AUuxU37swxzHN3dJvF3opi/EGHGLqP4ze8bhiECkqwI7BCMlyMLgw69sG9TDNGHLSb IYUZxrzgCsxVCUjvBXNZ3/4geV0Gq6Jm4tKJb4m+zm+lEooJ9+w+XtRge8ZXz4nWLGbL mbJpouc4erZwVITjeV7llBoQD6DO6J2GjUAqSYc+/scG6bydOiNiQmv3pwCSERa5vNyT y3eeR1OxsDrmlUrb6PpYQ4dsZdE1/33DfNt8ErmV2VYKCU4Ij5gjiYNuHbBC5M6uIjBc x+DO59KHTxMwvrPoaRdziFcVTzfTRh0607mLugqHa32hJG70QeG9VHRVsberpvzhYBRi OIwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IqB19AezN8lCqUw0ALVQMBlzUJgvm2Y/RyZ/V8zAttE=; b=ne5TFKYuHfA+IZHsPq8N8kqvkkxzRbgQ+LwJK+/CndkQj+zQI0o66q+My7C/7gkmin HBWytv3WLIa91OS3/6veKp4+WbEgk8Th/vxXTQg1h1bnyVhic4cOO//5Lk+JW6rEVBsz trsPosH9N1R/fMzQ+V48get53gHZIA3uNYYAyS/XDO4leUe+3CiINY8/e9JWDsMWzVN1 K/uuEcCcfze3m7TWpzrNbm2qQh3+TfeyjSAfedm6DiarkOlPFJZUfac574b6zmBXSxK4 MplkYTKVk/brmKgF3y/MhQBRKalnvKNqxVlzNFImCCym6ek4B8/gOVtvIZ8jbVGmKW0M ePKg== X-Gm-Message-State: AOAM531gQ/JP8hOfEiOfd+PrbC9zqthZ1i3nqozICjKa3iK1mi1+61Iz rChqa53DdMu47vybLRkAhx0AnuxmuIYfolidB90milZxjwGbPx89uovBWeT2tGTdvDznPQ0XJb5 K4ks5AQ7SL1Ztiq0G2kHQINJpvb/UT0FA2GKPHJrT5OppOZFhH4SRTd5G+vv3aIs6HLKB6uurHc mcOAHqYGEOhVTs4zNyJCceTQQPhwA37+NcQNxg2O7ezMvwRkhDmjI0i7HEYnMD0NlWreNyL3qMt 7bt7HdIQXf1yr7O7RC71/6/au6xz6eA+mmXF72XEQ== X-Google-Smtp-Source: ABdhPJx1bExgIUUfpWbLLCAkwZrqUNoHavNwF5OBVdt+K/cNEnZT+0DjxsnZRq0WdJ/VuXV4HGvgnQ== X-Received: by 2002:a17:906:d045:: with SMTP id bo5mr4695587ejb.320.1601985261753; Tue, 06 Oct 2020 04:54:21 -0700 (PDT) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com. [209.85.218.51]) by smtp.gmail.com with ESMTPSA id k26sm1960510ejq.13.2020.10.06.04.54.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Oct 2020 04:54:21 -0700 (PDT) Received: by mail-ej1-f51.google.com with SMTP id u8so17219599ejg.1 for ; Tue, 06 Oct 2020 04:54:20 -0700 (PDT) X-Received: by 2002:a17:907:366:: with SMTP id rs6mr4758906ejb.352.1601985260387; Tue, 06 Oct 2020 04:54:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Tue, 6 Oct 2020 12:54:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab To: Murtuza Zabuawala Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000619aca05b0ff42a0" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000619aca05b0ff42a0 Content-Type: text/plain; charset="UTF-8" On Tue, Oct 6, 2020 at 12:51 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Akshay, > > We have used aysnc=False in most ajax calls with this feature, It is > causing UI hang in case of slow server response. > You can try adding a time.sleep() call at the python side response and > check the UI hang, I think we should avoid sync calls as much as possible. > I consider a sync ajax call to be a bug. > > > -- > Regards, > Murtuza Zabuawala > *EDB* > *POWER TO POSTGRES* > https://www.edbpostgres.com > > > On Thu, Oct 1, 2020 at 1:31 PM Akshay Joshi > wrote: > >> Thanks, patch applied. >> >> On Thu, Oct 1, 2020 at 10:42 AM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> I have resolved the sonarQube issues, PFA updated patch for the same. >>> >>> >>> Regards, >>> Nikhil Mohite. >>> >>> >>> On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Nikhil >>>> >>>> Your patch introduces 1 new Bug and 13 new code smells, please fix >>>> those and resend the patch. >>>> >>>> On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite < >>>> nikhil.mohite@enterprisedb.com> wrote: >>>> >>>>> Hi Akshay, >>>>> >>>>> I have resolved code conflict issues and sonarqube issues. >>>>> PFA updated patch. >>>>> >>>>> Regards, >>>>> Nikhil Mohite. >>>>> >>>>> On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Nikhil >>>>>> >>>>>> The patch is not applying, rebase, and send it again. Please check >>>>>> your code should not create any new SonarQube issues. >>>>>> >>>>>> On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite < >>>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Akshay, >>>>>>> >>>>>>> I have resolved all the review comments and also updated the test >>>>>>> cases as per the new implementation. >>>>>>> >>>>>>> PFA updated patch. >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi < >>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Nikhil >>>>>>>> >>>>>>>> Following are the initial review comments: >>>>>>>> >>>>>>>> - Open View/Edit data on any table and click on the same >>>>>>>> database connection and then click on the Execute button. Got >>>>>>>> "get_primary_keys() takes 1 positional argument but 2 were given" error. >>>>>>>> - In my opinion, we should hide the option to change the >>>>>>>> database connection for View/Edit Data. >>>>>>>> - If the user clicks on the same database connection multiple >>>>>>>> times then no need to change the backend connection and transaction id. Add >>>>>>>> validation at the backend, no action required in this case. >>>>>>>> - The role option is missing from the "connect to server" >>>>>>>> dialog. >>>>>>>> - The Password field should not be there on the "connect to >>>>>>>> server" dialog. Sometimes we saved the password so asking a password every >>>>>>>> time is not correct. Check the pgAdmin 3 behavior. >>>>>>>> >>>>>>>> Code review still remains. >>>>>>>> >>>>>>>> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite < >>>>>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Team, >>>>>>>>> >>>>>>>>> Regarding RM-3794 >>>>>>>>> allow the user to change the database connection from an open query tool: >>>>>>>>> I have implemented the feature and also added documentation for it. >>>>>>>>> >>>>>>>>> PFA patch. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Thanks & Regards,* >>>>>>>>> *Nikhil Mohite* >>>>>>>>> *Software Engineer.* >>>>>>>>> *EDB Postgres* >>>>>>>>> *Mob.No: +91-7798364578.* >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Thanks & Regards* >>>>>>>> *Akshay Joshi* >>>>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>>>> *EDB Postgres * >>>>>>>> >>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> *Thanks & Regards* >>>>>> *Akshay Joshi* >>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>> *EDB Postgres * >>>>>> >>>>>> *Mobile: +91 976-788-8246* >>>>>> >>>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Sr. Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > -- Dave Page VP & Chief Architect, Database Infrastructure EDB: http://www.enterprisedb.com Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --000000000000619aca05b0ff42a0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Oct 6, 2020 at 12:51 PM Murtu= za Zabuawala <murt= uza.zabuawala@enterprisedb.com> wrote:
Hi Akshay,

We have used aysnc=3DFalse in= most ajax calls with this feature, It is causing=C2=A0UI hang in case of s= low server response.
You can try adding a time.sleep() call at the python side = response and check the UI hang, I think we should avoid sync calls as much = as possible.

I consider a sync = ajax call to be a bug.
=C2=A0


--
Regards,
Murtuza Zabuawala
<= div>EDB
POWER TO POSTGRES

<= br>
On Thu,= Oct 1, 2020 at 1:31 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrot= e:
Thanks, patch applied.

On Thu, Oct 1, 2020 at 10:42 AM Nikhil Mohite= <ni= khil.mohite@enterprisedb.com> wrote:
Hi Akshay,

<= div>I have=C2=A0resolved the sonarQube issues, PFA updated patch for the sa= me.


Regards,
Nikhil Mohit= e.


On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi <akshay.jos= hi@enterprisedb.com> wrote:
Hi=C2=A0Nikhil

Your = patch introduces 1 new Bug and 13 new code smells, please fix those and res= end the patch.

On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite <nikhil.mohit= e@enterprisedb.com> wrote:
Hi Akshay,

I have= resolved code conflict issues and sonarqube issues.
PFA updated = patch.

Regards,
Nikhil Mohite.

On M= on, Sep 28, 2020 at 5:58 PM Akshay Joshi <akshay.joshi@enterprisedb.com> = wrote:
Hi=C2=A0Nikhil

The patch is not applying, rebas= e, and send it again. Please check your code should not create any new Sona= rQube issues.

On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite <nikhil.mohit= e@enterprisedb.com> wrote:
Hi Akshay,

I have= resolved all the review comments and also updated the test cases as per th= e new implementation.

PFA updated patch.



On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi <= akshay.j= oshi@enterprisedb.com> wrote:
Hi=C2=A0Nikhil

Fol= lowing are the initial review comments:
  • Open View/Edit data on = any table and click on the same database connection and then click on the E= xecute button. Got "get_primary_keys() takes 1 positional argument but= 2 were given" error.
  • In my opinion, we should hide the option= to change the database connection for View/Edit Data.
  • If the user = clicks on the same database connection multiple times then no need to chang= e the backend connection and transaction id. Add validation at the backend,= no action required in this case.
  • The role option is missing from t= he "connect to server" dialog.
  • The Password field should = not be there on the "connect to server" dialog. Sometimes we save= d the password so asking a password every time is not correct. Check the pg= Admin 3 behavior.
Code review still remains.

=
On Thu, Se= p 17, 2020 at 4:15 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wro= te:
Hi Team,

Regarding RM-3794 allow the=C2=A0user to= change the database connection from an open query tool:
I have i= mplemented the feature and also added documentation for it.

<= /div>
PFA patch.

--
Thanks & Regards,
Nikhil Mohite
Software Engineer.=
= Mob.No: +91-7798364578.
=


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Dave Page
VP & Chie= f Architect, Database Infrastructure
EDB: http://www.enterprisedb.com

Blog: http://pgsnake.blog= spot.com
Twitter: @pgsnake
--000000000000619aca05b0ff42a0--