Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZaMC-0003db-CO for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 09:40:40 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cZaMB-0000c9-Vf for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 09:40:40 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cZaMB-0000c3-5m for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 09:40:39 +0000 Received: from mail-it0-x231.google.com ([2607:f8b0:4001:c0b::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cZaM8-0000Gq-3f for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 09:40:38 +0000 Received: by mail-it0-x231.google.com with SMTP id r185so8332786ita.0 for ; Fri, 03 Feb 2017 01:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VcA7bJU+gn6KyxcUU9NiCcB9LqQ72aZlSqj+xKkP+sc=; b=ytFNhIeXhvq2WlXK4cIa5e3vtA30eNNLqPTU+5wLpeR9FohHOFBR6Sncrj5ms43QXK WE9fs3Eq0EWErOxRwq4EQ9puvvbhc6HwkzEcI0B6P7rNOLNThz+3IF7tVfwvjr5M+V6y JYy7dVn+t+Z9+9W0Z1JhNMv1xMIfgUB3mHQdBnlaBcdGvfx4Sicmc2fw4sKDnRx0xgsA 3iC10gNnC+8lq1vVpnXuHoX5linL3BywvZbxpdEBTFP8r/Y/LWM4hb/vqztXZ+Kodn7k BZu5RNPhzPFgk+oFDReUHTA7PdJoZ0xYLDumhUP7yGxcFZ82IGm/mBZt3iCgH7Bl1YDl oomA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VcA7bJU+gn6KyxcUU9NiCcB9LqQ72aZlSqj+xKkP+sc=; b=dmNas/Vtsjqv+qUflXl09hTioDpVItrQAKvBDQiEPTK7acqCY+VALsZwnVsWbn2pkq U/GR5S8UX3F2kONdfHMDwbCX9yMM/XpCc5k9zrESgIcJrey4xnRugFilwoKJwhAgmRIi N/j9bXxepxEiMRAX0kvrOWOAUKAVJwE8evst+iHwKYQhH12sNRwAPRiqgUDbkv/ZrY9h +01RRO1xHhbOp54XKdTctSo38JCJCIslPJs5DPrbmQdQZwDfXzmHbz92z+methfqW9xa o8zSpbfTnE7i7YwGkBmwYguF1jzfUik6nfAfBxQHCJ5Gtn9TXQ+6xzVMh4Yw4Ssx4F6g 2nJQ== X-Gm-Message-State: AIkVDXIdDntXMVZwh+EuFoZ5a+WZTplznQYj7rIQP7m0h/TIcTkHj/O4FNTIqw9lufr+Fvpqqz16OYZpymkxlQ== X-Received: by 10.36.200.9 with SMTP id w9mr323981itf.113.1486114835380; Fri, 03 Feb 2017 01:40:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.224.198 with HTTP; Fri, 3 Feb 2017 01:40:34 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 3 Feb 2017 09:40:34 +0000 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties To: Khushboo Vashi Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c057e14dc130f05479d12ca X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c057e14dc130f05479d12ca Content-Type: text/plain; charset=UTF-8 Akshay, I'll leave you to review/commit this. Please ensure that any tickets that patches close have the target version set to 1.2 (if they don't, please update them). That way the roadmap will reflect all the changes in the release. Thanks. On Fri, Feb 3, 2017 at 7:47 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Fri, Feb 3, 2017 at 1:08 PM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Khushboo >> >> After applying latest patch I found one error(refer attached screenshot) >> when clicking on "Materialized Views" collection node. >> >> Fixed > >> On Fri, Feb 3, 2017 at 12:14 PM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Fri, Feb 3, 2017 at 11:53 AM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Please find the attached rebased patch. >>>> >>>> This patch also include fix for RM 2139: Message (Connection to the >>> server has been lost.) displayed with Materialized view and view under sql >>> tab >>> >>> >>> >>>> Thanks, >>>> Khushboo >>>> >>>> On Mon, Jan 30, 2017 at 6:20 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> Can you rebase this please? >>>>> >>>>> Thanks. >>>>> >>>>> On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi >>>>> wrote: >>>>> > Hi, >>>>> > >>>>> > Please find the attached updated patch. >>>>> > >>>>> > Thanks, >>>>> > Khushboo >>>>> > >>>>> > On Fri, Jan 20, 2017 at 5:31 PM, Dave Page >>>>> wrote: >>>>> >> >>>>> >> On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi >>>>> >> wrote: >>>>> >> > Hi, >>>>> >> > >>>>> >> > Please find the attached patch to fix the RM 2069 - Wrong >>>>> tablespace >>>>> >> > displayed in table properties. >>>>> >> > >>>>> >> > When the table is created without a tablespace, the "pg_default" >>>>> >> > tablespace >>>>> >> > gets selected rather than the default tablespace (the current >>>>> database >>>>> >> > tablespace). >>>>> >> > So, this issue has been fixed. >>>>> >> >>>>> >> Unfortunately more work is required. I started hacking on it (see >>>>> >> attached), but there is more effort needed and I'm out of time. >>>>> >> Specifically: >>>>> >> >>>>> >> - We need to remove 'pg_default' as the default tablespace when >>>>> >> creating objects. Let's have no default, and let PG automatically >>>>> pick >>>>> >> the right tablespace, unless the user specifically overrides it. My >>>>> >> updated patch removes that default, and fixes some of the SQL to >>>>> >> handle it. >>>>> >> >>>>> > Done >>>>> >> >>>>> >> - Matviews don't list the correct tablespace in their properties >>>>> list. >>>>> >> >>>>> > Done >>>>> >> >>>>> >> - Unique constraints ignore the tablespace option if the user >>>>> selects >>>>> >> pg_default, even if the database's default is something different. >>>>> >> >>>>> > Done >>>>> >> >>>>> >> So I think to complete this we need to review all objects that use >>>>> >> tablespaces (databases, tables, matviews, indexes, index-backed >>>>> >> constraints) and ensure: >>>>> >> >>>>> > Done >>>>> >> >>>>> >> - No default tablespace is selected when creating an object. >>>>> >> >>>>> > Done >>>>> >> >>>>> >> - If the user selects a tablespace, the CREATE SQL must handle it >>>>> >> properly. Similarly, if they leave it to the default. >>>>> >> >>>>> > Done >>>>> >> >>>>> >> - The Properties views must display the actual tablespace in use, >>>>> >> whether it is specific to the object, or the database default. >>>>> >> >>>>> > Done >>>>> >> >>>>> >> Thanks. >>>>> >> >>>>> >> -- >>>>> >> Dave Page >>>>> >> Blog: http://pgsnake.blogspot.com >>>>> >> Twitter: @pgsnake >>>>> >> >>>>> >> EnterpriseDB UK: http://www.enterprisedb.com >>>>> >> The Enterprise PostgreSQL Company >>>>> > >>>>> > >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 >> <+91%2097678%2088246>* >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c057e14dc130f05479d12ca Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Akshay, I'll leave you to review/commit this. Please e= nsure that any tickets that patches close have the target version set to 1.= 2 (if they don't, please update them). That way the roadmap will reflec= t all the changes in the release.

Thanks.

On Fri, Feb 3, 2017 = at 7:47 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com<= /a>> wrote:
Hi= Akshay,

Please find the attached updat= ed patch.

Thanks,
Khushboo
<= div class=3D"gmail_extra">
O= n Fri, Feb 3, 2017 at 1:08 PM, Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
Hi Khushboo

After applying latest patch I fo= und one error(refer attached screenshot) when clicking on "Materialize= d Views" collection node.
<= div class=3D"m_5905792288685670632h5">
Fixed=C2=A0
On Fri, Feb 3, 2017 at 12:14 PM, Khushboo Vash= i <khushboo.vashi@enterprisedb.com> wrote= :
Hi,

On Fri, Feb 3, 2017 at 11:= 53 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com<= /a>> wrote:

=

On M= on, Jan 30, 2017 at 6:20 PM, Dave Page <dpage@pgadmin.org> w= rote:
Hi

Can you rebase this please?

Thanks.

On Fri, Jan 27, 2017 at 11:53 AM, Khushboo Vashi
&= lt;khu= shboo.vashi@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached updated patch.
>
> Thanks,
> Khushboo
>
> On Fri, Jan 20, 2017 at 5:31 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi
>> <khushboo.vashi@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > Please find the attached patch to fix the RM 2069 - Wrong tab= lespace
>> > displayed in table properties.
>> >
>> > When the table is created without a tablespace, the "pg_= default"
>> > tablespace
>> > gets selected rather than the default tablespace (the current= database
>> > tablespace).
>> > So, this issue has been fixed.
>>
>> Unfortunately more work is required. I started hacking on it (see<= br> >> attached), but there is more effort needed and I'm out of time= .
>> Specifically:
>>
>> - We need to remove 'pg_default' as the default tablespace= when
>> creating objects. Let's have no default, and let PG automatica= lly pick
>> the right tablespace, unless the user specifically overrides it. M= y
>> updated patch removes that default, and fixes some of the SQL to >> handle it.
>>
> Done
>>
>> - Matviews don't list the correct tablespace in their properti= es list.
>>
> Done
>>
>> - Unique constraints ignore the tablespace option if the user sele= cts
>> pg_default, even if the database's default is something differ= ent.
>>
> Done
>>
>> So I think to complete this we need to review all objects that use=
>> tablespaces (databases, tables, matviews, indexes, index-backed >> constraints) and ensure:
>>
> Done
>>
>> - No default tablespace is selected when creating an object.
>>
> Done
>>
>> - If the user selects a tablespace, the CREATE SQL must handle it<= br> >> properly. Similarly, if they leave it to the default.
>>
> Done
>>
>> - The Properties views must display the actual tablespace in use,<= br> >> whether it is specific to the object, or the database default.
>>
> Done
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
= Akshay Joshi
Principal Software Engineer= =C2=A0

=

+91 20-3058-9517
Mobile: +91 976-788-8246




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--94eb2c057e14dc130f05479d12ca--