MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZRidfdPkSe=2wiaDsz_F3sAXdWZs_1SQLFks1YeP24UTQ@mail.gmail.com>
References: 
 <CAKKotZRidfdPkSe=2wiaDsz_F3sAXdWZs_1SQLFks1YeP24UTQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 3 Apr 2018 15:13:43 +0100
Message-ID: 
 <CA+OCxoygT-+xezSAboURa9E9myQCX2GbO4DCFg7yY+umHhEa5g@mail.gmail.com>
Subject: Re: [pgAdmin4][RM#3235] Code refactoring in Query tool
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="089e082d11a06a9c290568f250b7"
Precedence: bulk

--089e082d11a06a9c290568f250b7
Content-Type: text/plain; charset="UTF-8"

HI

On Tue, Apr 3, 2018 at 12:27 PM, Murtuza Zabuawala <
murtuza.zabuawala@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to extract the common code from query tool to handle ajax errors
> & connection handling, Also added unit tests around extracted code.
>

Looks good to me, except, I wonder if we should rename
is_new_transaction_required.js/is_new_transaction_required_spec.js to
something a little more generic; maybe conn_tx_handler_funcs.js? Not sure I
like that though.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--089e082d11a06a9c290568f250b7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">HI<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Tue, Apr 3, 2018 at 12:27 PM, Murtuza Zabuawala <span dir=3D"ltr">=
&lt;<a href=3D"mailto:murtuza.zabuawala@enterprisedb.com" target=3D"_blank"=
>murtuza.zabuawala@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;p=
adding-left:1ex"><div dir=3D"ltr"><div style=3D"font-family:verdana,sans-se=
rif;color:#444444">Hi,</div><div style=3D"font-family:verdana,sans-serif;co=
lor:#444444"><br></div><div style=3D"font-family:verdana,sans-serif;color:#=
444444">PFA patch to extract the common code from query tool to handle ajax=
 errors &amp; connection handling, Also added unit tests around extracted c=
ode.=C2=A0</div></div></blockquote><div><br></div><div>Looks good to me, ex=
cept, I wonder if we should rename is_new_transaction_required.js/<span sty=
le=3D"color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font=
-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-w=
eight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-trans=
form:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,=
255);text-decoration-style:initial;text-decoration-color:initial;float:none=
;display:inline">is_new_transaction_required_spec.js to something a little =
more generic; maybe conn_tx_handler_funcs.js? Not sure I like that though.<=
/span></div></div><br clear=3D"all"><div><br></div>-- <br><div class=3D"gma=
il_signature" data-smartmail=3D"gmail_signature">Dave Page<br>Blog: <a href=
=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.=
com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.=
enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The =
Enterprise PostgreSQL Company<br></div>
</div></div>

--089e082d11a06a9c290568f250b7--