MIME-Version: 1.0
References: 
 <CAOBg0AMsjjfovd9tpdikhwrqYMq_v51jNyqPQFc1WofxjaDU_Q@mail.gmail.com>
 <CANxoLDdMuF+p9kHnioFgjzDwrvR+aKTzpa7EZEDSZVszrTBJ7g@mail.gmail.com>
In-Reply-To: 
 <CANxoLDdMuF+p9kHnioFgjzDwrvR+aKTzpa7EZEDSZVszrTBJ7g@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 14 Jan 2021 09:08:10 +0000
Message-ID: 
 <CA+OCxoyghzW2OJyxC2MpyHX3=T=pSJm1s5nxG8qZO_e6Hm08SA@mail.gmail.com>
Subject: Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add
 an older date in account expires.
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: Nikhil Mohite <nikhil.mohite@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000e9d1f305b8d89847"
Precedence: bulk

--000000000000e9d1f305b8d89847
Content-Type: text/plain; charset="UTF-8"

On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Thanks, patch applied.
>
> On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite <
> nikhil.mohite@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> Please find the attached patch for RM-6120
>> <https://redmine.postgresql.org/issues/6120>: Adding/updating user
>> should not allow to add an older date in account expires.
>> Added UI validation if a user enters the account expiration date manually.
>>
>
I think this needs to be reverted (and the UI fixed to allow an older date
to be selected).

Selecting a past expiry date is a perfectly valid way to create an account
that is effectively locked, for example, to allow pre-creation of roles for
staff that are yet to join.

PostgreSQL doesn't prevent this - why should we?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

--000000000000e9d1f305b8d89847
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jan 14, 2021 at 8:18 AM Aksha=
y Joshi &lt;<a href=3D"mailto:akshay.joshi@enterprisedb.com">akshay.joshi@e=
nterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad=
ding-left:1ex"><div dir=3D"ltr">Thanks, patch applied.</div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jan 14, 2021=
 at 11:28 AM Nikhil Mohite &lt;<a href=3D"mailto:nikhil.mohite@enterprisedb=
.com" target=3D"_blank">nikhil.mohite@enterprisedb.com</a>&gt; wrote:<br></=
div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi T=
eam,<div><br></div><div>Please find the attached patch for <a href=3D"https=
://redmine.postgresql.org/issues/6120" target=3D"_blank">RM-6120</a>:=C2=A0=
Adding/updating user should not allow to add=C2=A0an older date in account =
expires.</div><div>Added UI validation if a user enters the account expirat=
ion date manually.</div></div></blockquote></div></blockquote><div><br></di=
v><div>I think this needs to be reverted (and the UI fixed to allow an olde=
r date to be selected).</div><div><br></div><div>Selecting a past expiry da=
te is a perfectly valid way to create an account that is effectively locked=
, for example, to allow pre-creation of roles for staff that are yet to joi=
n.</div><div><br></div><div>PostgreSQL doesn&#39;t prevent this - why shoul=
d we?</div><div><br></div><div>--=C2=A0=C2=A0</div></div><div dir=3D"ltr" c=
lass=3D"gmail_signature"><div dir=3D"ltr">Dave Page<br>Blog: <a href=3D"htt=
p://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a>=
<br>Twitter: @pgsnake<br><br>EDB: <a href=3D"http://www.enterprisedb.com" t=
arget=3D"_blank">http://www.enterprisedb.com</a><br><br></div></div></div>

--000000000000e9d1f305b8d89847--