Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ghX9h-000072-5y for pgadmin-hackers@arkaria.postgresql.org; Thu, 10 Jan 2019 10:01:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ghX9f-0000YZ-SX for pgadmin-hackers@arkaria.postgresql.org; Thu, 10 Jan 2019 10:01:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ghX9f-0000YS-En for pgadmin-hackers@lists.postgresql.org; Thu, 10 Jan 2019 10:01:39 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ghX9T-0002gB-PF for pgadmin-hackers@postgresql.org; Thu, 10 Jan 2019 10:01:38 +0000 Received: by mail-wm1-x342.google.com with SMTP id a62so10614377wmh.4 for ; Thu, 10 Jan 2019 02:01:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=22xwNRUlUtAbHb+tQnO5+FbRj66kVIiRzSAKhksP48w=; b=ZE+tUT5ymtAFwvZ6Ck39svUsDeU1V0NfvjCf1vR8CpV664QXkuYg4xGRKYmNoBKGQ/ uVp8cUvmMbKWfaAncPTWMp4ZH2MGUV8kfCg4r7Atjtb7EhPHt4iQ7fW1ktmJJF6w/Lph yEl+mRjia6Gs6T8AemAW+M6otsBsYup47H5yGAGvr3Tu9BpMI1lPxEpXQlliTko0E7EW PpctM9CJ7NOMEKzNykZdxyfHJPkJnxw7a4Svo9ro0x0uWGx4JpHMzkHyOS5tJHsOeZwZ /wUHhuCKMlTQGahk6rskvqEGDVTYZ0hEGJJqlX8JXgOmvOCAczOLnDG3IJGDn8NuPE/m ui7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=22xwNRUlUtAbHb+tQnO5+FbRj66kVIiRzSAKhksP48w=; b=tghiSX92zjyF1oAf+FEx08u4ZNNgLKQVkwUqgLzXSAZiol4eUIKDCEWakceR37zQTI n/kdsnU4lPLNs/UORZFAovUg2gO/UM+AbZK7q+oM6g8JoMmX5ZZH9ghmj+fas/pWURdw dTTPBimo2o7sZmjlSqNWBbWmvfp3X//e/ZKVjEf+LKtu4089AqRvRvjUwpVzKv7PWdVv hH8lgUxbE9I57WofhGOGz7dz8PgLXD+aurPAzcrIBIrbOQFr/p72f37Fm1MlDyUi2Vav c8t8NKliwnHiPHlW6TL/YDNmpPr+O2IyjeHTWJFehca4wAfu3CisKXYZRdbvdMJsLEvI bdHg== X-Gm-Message-State: AJcUukciNuMG+C/Y0uxy2+nRBxSUO4vtWGyurFuzSrgESnvFtJMoqLna YlRm25Prwa8TiJSC2IsSdeg31ckB41o22CAqSyoIlA== X-Google-Smtp-Source: ALg8bN7tIJCwBwIE+2n/C0o/WmBaKVIXC0uflVOZuvMcX7WGUnGzIqNglgo5vNMci6VQ8Ert0FqePdN8awP4iuq/reo= X-Received: by 2002:a1c:bb04:: with SMTP id l4mr9198052wmf.142.1547114486194; Thu, 10 Jan 2019 02:01:26 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 10 Jan 2019 15:31:14 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 3836 VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on PostgreSQL 11 To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000607d4c057f17a9a3" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000607d4c057f17a9a3 Content-Type: text/plain; charset="UTF-8" Thanks - applied! On Thu, Jan 10, 2019 at 12:48 PM Akshay Joshi wrote: > Hi > > Attached is the modified patch. I have fixed the similar code for Backup > and Restore as well along with this patch. > > On Thu, Jan 10, 2019 at 12:26 PM Dave Page wrote: > >> Hi >> >> On Wed, Jan 9, 2019 at 6:46 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix RM #3836 VACUUM FULL FREEZE ANALYZE VERBOSE >>> syntax error on PostgreSQL 11. Order of commands has been changed in >>> PostgreSQL 11 "https://github.com/postgres/postgres >>> /commit/921059bd66c7fb1230c705d3b1a65940800c4cbb" >>> >>> Please review it. >>> >> >> I tried to test this, and got what looks like the same issue that we >> looked at the other day with Import/Export. Can you look at it please? >> >> 2019-01-10 12:25:02,044: INFO werkzeug: 127.0.0.1 - - [10/Jan/2019 >> 12:25:02] "POST /maintenance/job/2/12669 HTTP/1.1" 500 - >> 2019-01-10 12:25:02,051: ERROR werkzeug: Error on request: >> Traceback (most recent call last): >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py", >> line 270, in run_wsgi >> execute(self.server.app) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py", >> line 258, in execute >> application_iter = app(environ, start_response) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py", >> line 1997, in __call__ >> return self.wsgi_app(environ, start_response) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py", >> line 1985, in wsgi_app >> response = self.handle_exception(e) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py", >> line 1540, in handle_exception >> reraise(exc_type, exc_value, tb) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/_compat.py", >> line 33, in reraise >> raise value >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py", >> line 1982, in wsgi_app >> response = self.full_dispatch_request() >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py", >> line 1614, in full_dispatch_request >> rv = self.handle_user_exception(e) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py", >> line 1517, in handle_user_exception >> reraise(exc_type, exc_value, tb) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/_compat.py", >> line 33, in reraise >> raise value >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py", >> line 1612, in full_dispatch_request >> rv = self.dispatch_request() >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py", >> line 1598, in dispatch_request >> return self.view_functions[rule.endpoint](**req.view_args) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask_login.py", >> line 792, in decorated_view >> return func(*args, **kwargs) >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/tools/maintenance/__init__.py", line >> 179, in create_maintenance_job >> data = json.loads(data['data'][0], encoding='utf-8') >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/simplejson/__init__.py", >> line 535, in loads >> return cls(encoding=encoding, **kw).decode(s) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/simplejson/decoder.py", >> line 370, in decode >> obj, end = self.raw_decode(s) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/simplejson/decoder.py", >> line 400, in raw_decode >> return self.scan_once(s, idx=_w(s, idx).end()) >> simplejson.errors.JSONDecodeError: Expecting property name enclosed in >> double quotes or '}': line 1 column 2 (char 1) >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000607d4c057f17a9a3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks - applied!

On Thu, Jan 10, 2019 at 12:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> = wrote:
Hi=C2=A0

Attached is the modified patch. I have= fixed the similar code for Backup and Restore as well along with this patc= h.=C2=A0=C2=A0

O= n Thu, Jan 10, 2019 at 12:26 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

= On Wed, Jan 9, 2019 at 6:46 PM Akshay Joshi <akshay.joshi@enterprisedb.com&g= t; wrote:
Hi Hackers,

Attached is the patch to fix RM #3836= =C2=A0VACUUM FULL FREEZE ANALYZE VERBOSE syntax error on PostgreSQL 11. Order of commands has been changed in PostgreSQL 11 "https://github.com/postgres/postgres/commit/921059bd66c7fb1230c705d3b1a659408= 00c4cbb"

Please review it.
<= /div>

I tried to test this, and got what lo= oks like the same issue that we looked at the other day with Import/Export.= Can you look at it please?

2019-01-10 12:25:02,04= 4: INFO werkzeug: 127.0.0.1 - - [10/Jan/2019 12:25:02] "P= OST /maintenance/job/2/12669 HTTP/1.1" 500 -
2019-01-10 12:2= 5:02,051: ERROR werkzeug: Error on request:
Tracebac= k (most recent call last):
=C2=A0 File "/Users/dpage/.virtua= lenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py", line = 270, in run_wsgi
=C2=A0 =C2=A0 execute(self.server.app)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-pa= ckages/werkzeug/serving.py", line 258, in execute
=C2=A0 =C2= =A0 application_iter =3D app(environ, start_response)
=C2=A0 File= "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask= /app.py", line 1997, in __call__
=C2=A0 =C2=A0 return self.w= sgi_app(environ, start_response)
=C2=A0 File "/Users/dpage/.= virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py", line 1= 985, in wsgi_app
=C2=A0 =C2=A0 response =3D self.handle_exception= (e)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/pyth= on3.6/site-packages/flask/app.py", line 1540, in handle_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File = "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/= _compat.py", line 33, in reraise
=C2=A0 =C2=A0 raise value
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6= /site-packages/flask/app.py", line 1982, in wsgi_app
=C2=A0 = =C2=A0 response =3D self.full_dispatch_request()
=C2=A0 File &quo= t;/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.= py", line 1614, in full_dispatch_request
=C2=A0 =C2=A0 rv = =3D self.handle_user_exception(e)
=C2=A0 File "/Users/dpage/= .virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py", line = 1517, in handle_user_exception
=C2=A0 =C2=A0 reraise(exc_type, ex= c_value, tb)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4= /lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
=C2=A0 =C2=A0 raise value
=C2=A0 File "/Users/dpage/= .virtualenvs/pgadmin4/lib/python3.6/site-packages/flask/app.py", line = 1612, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.dispatch= _request()
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/l= ib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_reque= st
=C2=A0 =C2=A0 return self.view_functions[rule.endpoint](**req.= view_args)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/l= ib/python3.6/site-packages/flask_login.py", line 792, in decorated_vie= w
=C2=A0 =C2=A0 return func(*args, **kwargs)
=C2=A0 Fil= e "/Users/dpage/git/pgadmin4/web/pgadmin/tools/maintenance/__init__.py= ", line 179, in create_maintenance_job
=C2=A0 =C2=A0 data = =3D json.loads(data['data'][0], encoding=3D'utf-8')
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-= packages/simplejson/__init__.py", line 535, in loads
=C2=A0 = =C2=A0 return cls(encoding=3Dencoding, **kw).decode(s)
=C2=A0 Fil= e "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/simp= lejson/decoder.py", line 370, in decode
=C2=A0 =C2=A0 obj, e= nd =3D self.raw_decode(s)
=C2=A0 File "/Users/dpage/.virtual= envs/pgadmin4/lib/python3.6/site-packages/simplejson/decoder.py", line= 400, in raw_decode
=C2=A0 =C2=A0 return self.scan_once(s, idx=3D= _w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting pr= operty name enclosed in double quotes or '}': line 1 column 2 (char= 1)
=C2=A0

--
= Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB = UK: http://www.en= terprisedb.com
The Enterprise PostgreSQL Company


--
=
Akshay Joshi
Sr. Software Architect

=
Phone: +91 20-3058-9517
Mobil= e: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000607d4c057f17a9a3--