Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dB0Oz-0006RN-73 for pgadmin-hackers@arkaria.postgresql.org; Wed, 17 May 2017 14:58:13 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dB0Oy-0004ve-QI for pgadmin-hackers@arkaria.postgresql.org; Wed, 17 May 2017 14:58:12 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dB0Oy-0004vS-Bz for pgadmin-hackers@postgresql.org; Wed, 17 May 2017 14:58:12 +0000 Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dB0Ov-0003TR-FN for pgadmin-hackers@postgresql.org; Wed, 17 May 2017 14:58:11 +0000 Received: by mail-io0-x236.google.com with SMTP id f102so10827785ioi.2 for ; Wed, 17 May 2017 07:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jpfLoDn7Pri/wDgHy6PF43NQjvbRptV9Oiy2Bbgwyrw=; b=QVO4WqkfAVY43L4z9CKscf7ndn5cfw2VJWSNYLl7wRMAtiUOIRJxyZGfcrGGekYSB7 uBr4seqED66ddP7PpJpsWOcbMkYqLFpd/huHSGz9jwEgFN2Qrp5+iPbRwFe4aT+e1cPK j8bLR0YE2vf6guwtK8Ez7gt8th7PUEoOVyplsoXMVHFj5lXBpucWfizsTWklBJ2OvKIL cFeYJC2w4qdhKytMLVz7HWjSz85bj1JC0u5otwAVWZ8+aKMYhcudpmjBqxxQ/58ikaXn qUxzpC1lT82wT+BhPkbS/4Ljgs9Tbgn6zl43OZZ6VtASwzZSpr2j0OGhUQYTCNYXLZQo CFZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jpfLoDn7Pri/wDgHy6PF43NQjvbRptV9Oiy2Bbgwyrw=; b=AqABch3vIEHGOvkGfEDTKYq02PfoNQ0FtM8DyapWBF0qds7m5TlNYErg37VSJK1t37 OmMlcQP2ubYOurxWxXumQi1va/velrqBaaBT5DrrwImjZ2bpUnzH6W+98ZUYQlLbxFte 1Y/NwEd8rJcUM9BUbU8zFqh4Z5v3oNFQGhxQEpfkL2S3qPffDKPRZBgaxF6gYiO2CKy7 54BAc0mxvUPWzmKYaDK3cMr4iKZoPmodXlg0ysB5/cUefqonJI1LU+QTq+Vq4OnKN/zB eyE+0zRzrtVtw7P3U4HncvSAEQtRKje9UBN5iiHXKkOsV7FUQ0ZN+LLIga8O8YFV7tm0 Jg2Q== X-Gm-Message-State: AODbwcA9z/uuqPWFALEDAjLRwE1OTGw/gCccuPRK2Obu3VxJBcdEEEG7 O1OF0LKMs8eQ/NqQoPtYpf9MXMM5VRWZ X-Received: by 10.107.35.210 with SMTP id j201mr3512511ioj.144.1495033083746; Wed, 17 May 2017 07:58:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.147 with HTTP; Wed, 17 May 2017 07:58:03 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 17 May 2017 15:58:03 +0100 Message-ID: Subject: Re: [pgAdmin4][PATCH] To fix the issue in server group node To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1140c59ee27563054fb98386" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140c59ee27563054fb98386 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, May 17, 2017 at 8:28 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the in server group node, If you user > creates/update server group name which is already present in tree then it > fails and it does not provide clear informative error message regarding > failure. > > Issue found during testing node rename issue :) > RM#2414 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1140c59ee27563054fb98386 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.
On Wed, May 17, 2017 at 8:28 AM, Murtuza Zabuaw= ala <murtuza.zabuawala@enterprisedb.com> wr= ote:
Hi,

PFA minor patch to fix the in server group node,=C2= =A0If you user creates/update server group name which is already present in= tree then it fails and it does not provide clear informative error message= regarding failure.

Issue found during testing node rename issue :)
RM#2414

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.comTh= e Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
--001a1140c59ee27563054fb98386--