MIME-Version: 1.0
References: 
 <CAOBg0AMGqtR9QVkaJuu2x7fccCpFWOzAz56DHAgGdx1-=us7dg@mail.gmail.com>
In-Reply-To: 
 <CAOBg0AMGqtR9QVkaJuu2x7fccCpFWOzAz56DHAgGdx1-=us7dg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 15 Jun 2023 10:40:43 +0100
Message-ID: 
 <CA+OCxoymw-hKw8nYbt-nTi=6h7tB_dRPyaQL-ib2s2uPzcoxTQ@mail.gmail.com>
Subject: Re: Required inputs in issue #6138
To: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000632c8105fe27dd62"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxoymw-hKw8nYbt-nTi%3D6h7tB_dRPyaQL-ib2s2uPzcoxTQ%40mail.gmail.com>
Precedence: bulk

--000000000000632c8105fe27dd62
Content-Type: text/plain; charset="UTF-8"

On Wed, 14 Jun 2023 at 13:43, Nikhil Mohite <nikhil.mohite@enterprisedb.com>
wrote:

> Hi Hacker,
>
> I am currently working on issue #6138
> <https://github.com/pgadmin-org/pgadmin4/issues/6138>, which was fixed
> earlier but the fix was not correct so working on it again.
> Steps to reproduce the issue:
> 1. Open *View/Edit Data *for *table1*
> 2. Open the PSQL tool delete the same *table1 *and recreates the same
> name table *table1* and try to re-execute the query from the
> already opened *View/Edit data *panel.
> 3. pgAdmin throws an error in the Messages tab *List index out of range *(pgAdmin
> query to get table columns from Postgres based on *table oid* which was
> deleted and the return result is empty which is not handled in pgAdmin)*.*
>
> Approach to fix this issue:
> 1. If the user re-executes the query from already opened *View/Edit data* we
> should fetch the table details by using *schema and table name (not using
> table oid)* and show the newly created table records in the result.
> (This will only fix an issue with *View/Edit Data *however if the user
> switches to properties or some other panel it user will still get an error
> notification with content *"could not find the specified table."*)
>

I think this is fine. The View/Edit data window shows the query with
table/schema name after all, so the user should expect it to work.

-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

--000000000000632c8105fe27dd62
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, 14 Jun 2023 at 13:43, Nikhil =
Mohite &lt;<a href=3D"mailto:nikhil.mohite@enterprisedb.com">nikhil.mohite@=
enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:s=
olid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">=
Hi Hacker,<div><br></div><div>I am currently working on issue <a href=3D"ht=
tps://github.com/pgadmin-org/pgadmin4/issues/6138" target=3D"_blank">#6138<=
/a>, which was fixed earlier but the fix was not correct so working on it a=
gain.</div><div>Steps=C2=A0to reproduce=C2=A0the issue:</div><div>1. Open=
=C2=A0<i>View/Edit Data </i>for <i>table1</i></div><div>2. Open the PSQL to=
ol delete the same <i>table1 </i>and recreates the same name table <i>table=
1</i> and try to re-execute=C2=A0the query from the already=C2=A0opened=C2=
=A0<i>View/Edit data </i>panel.</div><div>3. pgAdmin throws an error in the=
 Messages tab <i>List index out of range </i>(pgAdmin query to get table co=
lumns from Postgres based on <i>table oid</i> which was deleted and the ret=
urn result is empty which is not handled in pgAdmin)<i>.</i></div><div><i><=
br></i></div><div>Approach=C2=A0to fix this issue:</div><div>1. If the user=
 re-executes=C2=A0the query from already=C2=A0opened <i>View/Edit data</i>=
=C2=A0we should=C2=A0fetch the table details=C2=A0by using <i>schema and ta=
ble name (not using table oid)</i>=C2=A0and show the newly created table re=
cords in the result.</div><div>(This will only fix an issue with <i>View/Ed=
it Data </i>however if the user switches to properties or some other panel =
it user will still get an error notification with content=C2=A0<i>&quot;cou=
ld not find the specified table.&quot;</i>)</div></div></blockquote><div><b=
r></div><div>I think this is fine. The View/Edit data window shows the quer=
y with table/schema name after all, so the user should expect it to work.=
=C2=A0</div></div><div><br></div><span class=3D"gmail_signature_prefix">-- =
</span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Dave=
 Page<br>Blog: <a href=3D"https://pgsnake.blogspot.com" target=3D"_blank">h=
ttps://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EDB: <a href=3D=
"https://www.enterprisedb.com" target=3D"_blank">https://www.enterprisedb.c=
om</a><br><br></div></div></div>

--000000000000632c8105fe27dd62--