Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bWj2K-0007Gv-Hy for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Aug 2016 11:48:04 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bWj2K-0005qf-4M for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Aug 2016 11:48:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bWj26-0005Le-Gl for pgadmin-hackers@postgresql.org; Mon, 08 Aug 2016 11:47:50 +0000 Received: from mail-it0-x232.google.com ([2607:f8b0:4001:c0b::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bWj1n-0008RF-Sd for pgadmin-hackers@postgresql.org; Mon, 08 Aug 2016 11:47:48 +0000 Received: by mail-it0-x232.google.com with SMTP id f6so79485094ith.0 for ; Mon, 08 Aug 2016 04:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8xYr1zor+Z5UIlEMtTk5yqok1AeYy2YrdOzZadVVml0=; b=C0YSdBxALesVUuSQ5X35VOIrlqpNn+yhK8eCsy4yOtmuvQ/cX6tuAR9vTGGib9XXEI JeAn8MiTelhz3OTkO9mtRz7gdEBGxUMk0ZwYR9V0rv7/TztW4HXLUL2QXTfw1ChougnN nPX7j5IPuTsLmOadzRMpiwxmJwRFz22eYL2EMKlOes5fwZJPJjYj2pHFUpmQEAimkkbp Eb0QoOMq/Tlo83Z3xkJWoW+QCtaEvlJcFP0qwoVuy8ccpdUAH2HMb6ggM1wdzcmLjCZt wsTx0OGrXIz4flaFnE1TFY8kw1uB83k78uTPABL68wB8YeEytDV20iVAIcDtVe2n6KFh bn5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8xYr1zor+Z5UIlEMtTk5yqok1AeYy2YrdOzZadVVml0=; b=gAIvzftABgijKC+XbWRqVU5ZCxBJ51OtQ9PyfsWuoZTevgX2t0GXsCxfiau36/C6Xm 13VD1fyG9AieqT9VfxsHzQguzryeQ9VJKXtTJ/xx96jWkE5tD0QaKEqc+X/z+wex2yJ5 xtfC+c7LXNJ/xoIlKLYP2boXSKaJ9XOZETp9bkZvng1x0jLsqOltVMCIbWHwZz0UwsH6 BRiQW71tFRJ9Hs6XIkirFk7kcYOZ3ONHXWY9urPzLtT/XqYhx2BhduUwImgeLYrcGbeo k5IqcTumzb3jZgyPrlR4elgV/PgJcn+dVXfk1c3b2BoCccr33ypD/pKV6WmfYN5kWsF4 xQOQ== X-Gm-Message-State: AEkoouu73e1NAV2MZfSgplrVrYQvxbolhTvcff4kw1G5fqGiHrl+03XjNjgz0uP1xwupMdp9x8p+dpqYI7GOqA== X-Received: by 10.36.51.206 with SMTP id k197mr18463437itk.37.1470656850014; Mon, 08 Aug 2016 04:47:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.208.97 with HTTP; Mon, 8 Aug 2016 04:47:29 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 8 Aug 2016 12:47:29 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1119 - Add proper validations in fields before processing To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks, applied. On Mon, Aug 8, 2016 at 9:48 AM, Surinder Kumar wrote: > Hi > > Issues fixed: > 1) Add proper validation checks for fields. > 2) Fixed wrong sql generation due to incorrect conditions in template. > > Please find attached patch and review. > > > Thanks, > Surinder Kumar > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers