MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D-4QEd+9Ac1W1i_6Oz7Ykz2c27rmvkhH8Xh3MjHU6hAPQ@mail.gmail.com>
References: 
 <CAM5-9D_ebJh8VJfvhk2cR-w=QqkC2YTWhc8ft+v3a9qSTTotKw@mail.gmail.com>
 <CA+OCxoxNCNF9bgzJH7+-04o3-agSX8-Py4OgaKvfjfUt0vLi=w@mail.gmail.com>
 <CAM5-9D-MdMz=s4pLdf9E9P_pXfF4Dh49pzq3wbJjO3xV-h9WyQ@mail.gmail.com>
 <CAM5-9D_eeVg_=hPPTybEp2Traoqdj9jEnwTTAaJQQ-M5LiEo=A@mail.gmail.com>
 <CA+OCxoxCvvO6WSvqiJ9zgbynAYXyybtd=kkOCLMBPKU-0POBgQ@mail.gmail.com>
 <CAM5-9D-ZHXrQgYrTg5FOLNX+xSxR0gaGBmv4SK7Scqb4djhgUw@mail.gmail.com>
 <CA+OCxoxP9BYN=QTTLYWVzDuorvBYstzdCkf_U_CdNf=VFUGJrA@mail.gmail.com>
 <CAM5-9D8K-wwzhnhziQ7pBYivE5PmFFFJgKASr4kfh=KqCwjB3Q@mail.gmail.com>
 <CAM5-9D_m6cym4rWP9AUjE0KqPGfehhbhS4HUcc1o01Uz+2e1Lg@mail.gmail.com>
 <CAM5-9D-4QEd+9Ac1W1i_6Oz7Ykz2c27rmvkhH8Xh3MjHU6hAPQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 15 Jul 2016 10:52:03 +0100
Message-ID: 
 <CA+OCxoynDMfL4M3ZHwYhsjr_YwZ1tMJo2O0D_o_1HvoU1mOajw@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM#1432 - File Browser -
 File does not exist error
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: Marc Linster <marc.linster@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks Surinder, patch applied.

I suspect the font rendering issue is related to others we've seen,
where the solution is to ensure the -webkit-transform CSS attribute is
set to none. Can you have a poke around with it please?

On Wed, Jul 13, 2016 at 2:58 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Please find updated patch.
> This patch also includes the fix for issue  "File Browser - File does not
> exist error".
>
> On Wed, Jul 13, 2016 at 7:23 PM, Surinder Kumar
> <surinder.kumar@enterprisedb.com> wrote:
>>
>> I forgot to merge the fix for issue "File Browser - File does not exist
>> error" in the patch.
>> Please ignore this patch.
>>
>> On Wed, Jul 13, 2016 at 7:20 PM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>>>
>>> Please find updated patch with following changes/enhancements:
>>>
>>> Double click on file/folder icon or name will navigate to the
>>> folder/file.
>>> Selected file/folder can be renamed by Rename button only. Double click
>>> rename is removed.
>>> Filename text box will not hide on smaller screen. Setting minimum width
>>> of File Browser fixed it.
>>> Path at top will only show directory name, not the file name and it is
>>> greyed out.
>>>
>>> Issue not fixed:
>>> Icons and fonts of Query tool and File Browser looks blurred in Runtime
>>> environment.
>>> I tried debugging it. while debugging, It gets fixed on my ubuntu
>>> runtime. but I don't know how it gets fixed without changing css styles. It
>>> needs more time to debug.
>>>
>>> Please review.
>>>
>>> On Wed, Jul 13, 2016 at 5:15 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>>
>>>> On Tue, Jul 12, 2016 at 7:10 AM, Surinder Kumar
>>>> <surinder.kumar@enterprisedb.com> wrote:
>>>> > On Mon, Jul 11, 2016 at 6:41 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>> >>
>>>> >> On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar
>>>> >> <surinder.kumar@enterprisedb.com> wrote:
>>>> >> > On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar
>>>> >> > <surinder.kumar@enterprisedb.com> wrote:
>>>> >> >>
>>>> >> >> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page <dpage@pgadmin.org>
>>>> >> >> wrote:
>>>> >> >>>
>>>> >> >>> Hi,
>>>> >> >>>
>>>> >> >>> I think we need more changes than just that;
>>>> >> >>>
>>>> >> >>> - The path at the top should not be editable (it should be greyed
>>>> >> >>> in
>>>> >> >>> fact)
>>>> >> >>
>>>> >> >> Ok
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> - The path at the top should only show the directory path. The
>>>> >> >>> filename should never be appended.
>>>> >> >>
>>>> >> >> Ok
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> - The CSS needs to be fixed so the filename textbox at the bottom
>>>> >> >>> is
>>>> >> >>> never hidden (as it is now if the dialogue opens at a small
>>>> >> >>> size).
>>>> >> >>
>>>> >> >> Ok
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> - Double-click to navigate vs. rename should be modified to work
>>>> >> >>> in
>>>> >> >>> part like it does on Mac - Double-click on either the icon or the
>>>> >> >>> name
>>>> >> >>> should open the item (browser into a folder, or select and "OK"
>>>> >> >>> on a
>>>> >> >>> file), and Click then Enter should rename. I'm hesitant to try to
>>>> >> >>> implement "slow double click to rename" as that would likely need
>>>> >> >>> to
>>>> >> >>> be tunable for accessibility reasons.
>>>> >> >>
>>>> >> >> Ok, I will fix it.
>>>> >> >
>>>> >> > In the current scenario, the Enter Key is bound to the OK button by
>>>> >> > default
>>>> >> > in Alertify dialog which servers the purpose of closing the dialog.
>>>> >> > Should we de-attach Enter Key event bound to OK button and use it
>>>> >> > for
>>>> >> > rename
>>>> >> > file?
>>>> >> > please suggest what should I do?
>>>> >>
>>>> >> Hmm, good point.
>>>> >>
>>>> >> How hard would it be to look for 2 consecutive single-clicks (but not
>>>> >> a double-click) for rename? If we can do that, it avoids timing
>>>> >> considerations for double-clicks (which would be defined by the OS).
>>>> >
>>>> >
>>>> > I tried to implement slow double click, here is Fiddle
>>>> > There are two events 1) double click (it will be used for folder
>>>> > navigation)
>>>> > 2) Slow double click(For rename), It is a simple click event, when
>>>> > clicked
>>>> > twice after delay we consider it a slow double click.
>>>> >
>>>> > But it is not working smoothly, double click and single click events
>>>> > are
>>>> > conflicting.
>>>>
>>>> Yeah, so I see.
>>>>
>>>> > Also, we have rename button in navigation for rename operation,
>>>> > Can we skip slow double click because it is very confusing?
>>>>
>>>> OK, I must have been having a brain failure moment or something. Yes,
>>>> skip it - we obviously don't need it with the rename button.
>>>>
>>>> So we have:
>>>>
>>>> - Click to select
>>>> - Double click to open a folder
>>>> - Button to rename the select file/folder
>>>>
>>>> Sorry!
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers