Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3f1K-0002c3-6h for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 09:47:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3f1I-0004aT-Rq for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 09:47:56 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3f1I-0004aJ-Ap for pgadmin-hackers@lists.postgresql.org; Wed, 04 Apr 2018 09:47:56 +0000 Received: from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3f1D-0001Ta-Mj for pgadmin-hackers@postgresql.org; Wed, 04 Apr 2018 09:47:55 +0000 Received: by mail-wr0-x232.google.com with SMTP id m13so21577165wrj.5 for ; Wed, 04 Apr 2018 02:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=q8OqgVNaFdBwRAAzQaRRzX464uDBSaspHOtnvtnF7bA=; b=G5ByNLsxv6nKEFCSF3ixbaFYmMKmS5l2kX1tfZ3KlTfN3Ok5mZFo2vOdnHt5iet+QP mDWx0cwnEHd7mzohXTBz0Qw60muRaJXFjTDO5vB+uBMLrqtmedfL4zgIM7olI2hHsFIW OmPOnS3k/rlEvsFuSYhhVk6lU6nlPCrM10/cQLm8H1E9scedpQjSV9+Zr+0ToWuus+45 5QlwkaqBaCFTq97nXWTv6AaLwPifAEFKM/GIOyDxcaGtelYoPBhNvY0fOEeV92v958Jb PfhexCxrAkROBnKdCeQPR1oD0jhhvCf514pPc9IGJ4c7SHiRkWNnGI/N0gon64R4JuGd v0Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=q8OqgVNaFdBwRAAzQaRRzX464uDBSaspHOtnvtnF7bA=; b=sohLTcr0sSpHqteBal05gCn/lmTHVmEWEd7bdzVv6vFUsQw5u15I4VQ5wrCbq1IKmo awqePh9Nti9yRenBkwzpft9lKH58whD3LPVFgADrIG3flqQqAp4nN+kUokk96HaBmqLz KOwfPyT5MYiZqTs02Jg/RO5mGBWRzgWKmClty5GBYli4rNyiEg4EZMErK8f4RKsOCDo3 ZDlDBoCTgRP9VuPUmGSFxCOS9iKfGQ2Wu32z3hj1YK2led4sZ3uIaNgxpfQ5DU330FjQ 1QMPiR0yevAr0rvqK1us/UMycd5YazZ1DuTs4IUr6D1piE9SWuM9T4MCG0em0KJg3M/o t+qA== X-Gm-Message-State: AElRT7GCc4464Aj2baDATrG6wPhpu45xiu6Uz12NHlncXk0mL6jRseuV ZceVg6U03y9zwz2eIi7gkyr8JxPGY0Vag/7EII20Cyuo X-Google-Smtp-Source: AIpwx4/pAv4eDBsvBuU8Ygz5hz8jmjmXnEUQRZHsa8YCQsaqhwP4ar0VmDS/KNIHDJo+x64cQS/NOzgFXWer/Zbafkg= X-Received: by 10.223.195.124 with SMTP id e57mr11606466wrg.135.1522835269849; Wed, 04 Apr 2018 02:47:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Wed, 4 Apr 2018 02:47:49 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 4 Apr 2018 10:47:49 +0100 Message-ID: Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045c4e224faa62056902b75e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045c4e224faa62056902b75e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, patch applied. On Tue, Apr 3, 2018 at 4:49 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > =E2=80=8BHi Dave, > > Reverted back jQuery version to 1.x because of SlickGrid dependancy. > Please find updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Please hold on my previous patch. >> >> We can't use latest jQuery version as SlickGrid has dependancy on older >> version. >> I'll send updated patch again. >> >> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Please find updated patches, there are two patches attached one is for >>> the story and another is for changes required as per new modules. >>> >>> >>> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> PFA patch to update the modules to latest version. >>>>> >>>>> >>>> - Why isn't jQuery updated to 3.3.1? >>>> >>> =E2=80=8BDone=E2=80=8B >>> >>> >>>> =E2=80=8B >>>> >>>> >>> >>>> - Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2 >>>> and pycrypto etc? >>>> >>> =E2=80=8BDone=E2=80=8B >>> >>> >>>> >>>> >>>> >>>>> We are not able to update some of the modules to latest version due t= o >>>>> dependancy on other modules, For example >>>>> - Python: Flask-Security has dependancy on flask-babelex which causes >>>>> conflict with flask_babel >>>>> >>>> >>>> Hmm, flask-babelex might be a better option anyway; in particular, it >>>> avoids loading catalogs with every request which seems desirable given= the >>>> size of ours. On the other hand, it hasn't been updated so recently. >>>> >>> =E2=80=8BI have removed flask-babel and used flask_babelex instead.=E2= =80=8B >>> >>> >>>> >>>> >>>>> - JS: Can't update to Bootstrap4 because Bootstrap Switch & Bootstrap= Datetime >>>>> picker has dependancy on Bootstrap3. >>>>> >>>> >>>> OK. >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045c4e224faa62056902b75e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.


=

On Tue, Apr 3, 20= 18 at 4:49 PM, Murtuza Zabuawala <murtuza.zabuawala@enter= prisedb.com> wrote:
=E2=80=8BHi Dave,

Reverted back jQuery version to 1.x because of SlickGrid depen= dancy.
Please find updated = patch.

<= div>
--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.co= m
The Enterprise PostgreSQL Company


On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
P= lease hold on my previous patch.=C2=A0

W= e can't use latest jQuery version as SlickGrid has dependancy on older = version.
I'll send updated patch again.

On Tue, Apr 3, 2018 at 8:20= PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

<= div style=3D"font-family:verdana,sans-serif;color:#444444">Please find upda= ted patches, there are two patches attached one is for the story and anothe= r is for changes required as per new modules.


On Tue, Apr 3, 2018 at 6:27 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to update the modules to latest version.


- Why isn't jQuery updated to 3.3.1?
=E2=80=8BDone=E2=80=8B
= =C2=A0
=E2=80=8B
=C2=A0

- Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2= and pycrypto etc?=C2=A0
=E2=80=8BDone=E2=80=8B
=C2=A0
<= div dir=3D"ltr">
=
=C2=A0
=
We are not able to updat= e some of the modules to latest version due to dependancy on other modules,= For example
- Python: Flask-Security has dependancy on flask-babelex which causes co= nflict with flask_babel

Hmm, fl= ask-babelex might be a better option anyway; in particular, it avoids loadi= ng catalogs with every request which seems desirable given the size of ours= . On the other hand, it hasn't been updated so recently.
=E2=80=8BI have removed flask-babel and us= ed flask_babelex instead.=E2=80=8B
=C2=A0
=C2=A0
- JS: Can't updat= e to Bootstrap4 because Bootstrap Switch & = Bootstrap=C2=A0Datetime picker has dependancy on Bootstrap3.

OK.=C2=A0


--






--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--f403045c4e224faa62056902b75e--