Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erkuE-00011z-Ec for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 13:39:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erkuD-0000Su-FX for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 13:39:25 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erksC-0006re-Er for pgadmin-hackers@lists.postgresql.org; Fri, 02 Mar 2018 13:37:20 +0000 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erks8-0001cU-HK for pgadmin-hackers@postgresql.org; Fri, 02 Mar 2018 13:37:18 +0000 Received: by mail-wm0-x234.google.com with SMTP id z81so3197053wmb.4 for ; Fri, 02 Mar 2018 05:37:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G78hZ73x68JTnsqp/lafYLZc8+duNsx2ETzlrjkAKBM=; b=fRYiKTjGgp5OrqOl+1Ci1Hb6IXZMYfL7WQ8E9MAcIF5tdWtBFD5j13I5VD3dDnZZ9f xssFeQT5PWQyd7WGSjRHPmZ+QgAhpRa/4eC0U0DBLRDe/DJLizHOT6PY3YAHW9KmtJGv Mwltv/nkKS7RfIuAVSvPKQF85sIMiBs1xWuocC+qnwTpiy39twmTNsz2rBldDH4RfZc2 3dcTtRP5LxNrufI24RkuonCflhu2qdzlpt0HkbH9pimP/56/9aNmYoHrADEhDcYbLg+1 fQ7sP1/S50rZaUO/U09qUdO/D6T6zAeOAl15GrPsqmOYF0Wrtgya2i95hb47FM3nz1Rh I0kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G78hZ73x68JTnsqp/lafYLZc8+duNsx2ETzlrjkAKBM=; b=UKiSjlsZMcCXKV5v/CLJwLH5q+ZCfnWJy/RwjXWAQkbmpU7BVUfobahs2Qmju+PKFS A36wCWJONo9KZIqG5loWB5F50GW1X2E2EaKbWxUrq0qI2SWgjxriQ42QcYh6/QL5JMyn mnVTQ79FyD7k/uQOxqUfb+OzWTZ+9noKGu/gCGw+ZNGVyVzXzxnM+UJ1otmf30KorKK/ LxKZN8wUogsu6UllAtxyhsUmZk3hEi5wIhYvabXqUe4L/X18TyhxIOJriVj1Zn3ppX8M ohsIclLAIVhu96dEP32sB83Rqz7pcZgckZFUMXo5LGnOurfjcq/o6rVPrDLAu7s+DmBR wdOQ== X-Gm-Message-State: AElRT7GSb+ZJHiGRCnqXHL9JdmZ4fTTZxF+XpYduez6lyA3GQyS5moqS ntRGKlSN/g0L3SUgg5kx85FSacned4+EWuqyNs6xOA== X-Google-Smtp-Source: AG47ELtT8trv2jRr9UYwQz1yBr/grs+rAGYsI6l6NXjtTbUBY1aUFYwMltuzUkmMw9JW/CN6iciGIdMDwUI9bpmNDl4= X-Received: by 10.28.61.65 with SMTP id k62mr1200373wma.140.1519997833189; Fri, 02 Mar 2018 05:37:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Fri, 2 Mar 2018 05:37:12 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 2 Mar 2018 13:37:12 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3129] handle encoding issue in File manager To: Joao De Almeida Pereira Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114af6cee82fc605666e1234" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114af6cee82fc605666e1234 Content-Type: text/plain; charset="UTF-8" Thanks guys, patch applied. On Thu, Mar 1, 2018 at 10:11 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hello Joao, > The pipeline is green and I believe the change is good to be merged. > > Thanks > Joao > > On Thu, Mar 1, 2018 at 10:56 AM Murtuza Zabuawala enterprisedb.com> wrote: > >> Thanks Joao for reviewing. >> >> Attaching updated patch fixing PEP8 issues. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Thu, Mar 1, 2018 at 8:56 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hello Murtuza, >>> >>> The code looks pretty good, love the fact that you extracted it so that >>> our file size stop growing and get more manageable. All tests pass on our >>> CI. >>> >>> The only issue I found was linting: >>> >>> pycodestyle --config=.pycodestyle pgadmin/tools/sqleditor/ >>> pgadmin/tools/sqleditor/utils/query_tool_fs_utils.py:12: [E302] >>> expected 2 blank lines, found 1 >>> pgadmin/tools/sqleditor/utils/query_tool_fs_utils.py:53: [W391] blank >>> line at end of file >>> pgadmin/tools/sqleditor/utils/tests/test_query_tool_fs_utils.py:27: >>> [E121] continuation line under-indented for hanging indent >>> pgadmin/tools/sqleditor/utils/tests/test_query_tool_fs_utils.py:29: >>> [E122] continuation line missing indentation or outdented >>> 1 E121 continuation line under-indented for hanging indent >>> 1 E122 continuation line missing indentation or outdented >>> 1 E302 expected 2 blank lines, found 1 >>> 1 W391 blank line at end of file >>> 4 >>> >>> When this is fixed I think we are good to go >>> >>> Thanks >>> Joao >>> >>> On Thu, Mar 1, 2018 at 3:01 AM Murtuza Zabuawala >> enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA patch to fix the issue where user was not able to open the file >>>> with non utf-8 encoding. >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >> -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114af6cee82fc605666e1234 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks guys, patch applied.

On Thu, Mar 1, 2018 at 10:11 PM, Joao De A= lmeida Pereira <jdealmeidapereira@pivotal.io> wro= te:
Hello Joao,
The = pipeline is green and I believe the change is good to be merged.
=
Thanks
<= div>Joao
<= br>
On Thu, Mar 1, 2018 at 10:56= AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrot= e:
Thanks= Joao for reviewing.

Attaching updated pat= ch fixing PEP8 issues.

--
Regards,
Murtuza Zabuaw= ala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
=

On Thu, Mar= 1, 2018 at 8:56 PM, Joao De Almeida Pereira <jdealmeidapereir= a@pivotal.io> wrote:
Hello Murtuza,

The code looks pretty good, lo= ve the fact that you extracted it so that our file size stop growing and ge= t more manageable. All tests pass on our CI.

The o= nly issue I found was linting:

pycodestyle --= config=3D.pycodestyle pgadmin/tools/sqleditor/
pgadmin/tools/sqle= ditor/utils/query_tool_fs_utils.py:12: [E302] expected 2 blank lines, = found 1
pgadmin/tools/sqleditor/utils/query_tool_fs_utils.py= :53: [W391] blank line at end of file
pgadmin/tools/sqleditor/uti= ls/tests/test_query_tool_fs_utils.py:27: [E121] continuation line= under-indented for hanging indent
pgadmin/tools/sqleditor/utils/= tests/test_query_tool_fs_utils.py:29: [E122] continuation line mi= ssing indentation or outdented
1=C2=A0 =C2=A0 =C2=A0 =C2=A0E121 c= ontinuation line under-indented for hanging indent
1=C2=A0 =C2=A0= =C2=A0 =C2=A0E122 continuation line missing indentation or outdented
=
1=C2=A0 =C2=A0 =C2=A0 =C2=A0E302 expected 2 blank lines, found 1
=
1=C2=A0 =C2=A0 =C2=A0 =C2=A0W391 blank line at end of file
4=

When this is fixed I think we are good to g= o

Thanks
Joao

On Thu, Mar 1, 2018 at 3:01 AM Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,
<= br>
PFA patch to fix the issue where user was not able to ope= n the file with non utf-8 encoding.

=

--
Regards,
<= font face=3D"verdana, sans-serif" color=3D"#444444">Murtuza Zabuawala
En= terpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise = PostgreSQL Company

<= /div>




--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a114af6cee82fc605666e1234--