Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3NUQ-00012e-0y for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 15:04:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3NUO-0004BK-Qn for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 15:04:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3NUO-000482-GP for pgadmin-hackers@lists.postgresql.org; Tue, 03 Apr 2018 15:04:48 +0000 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3NUK-0001MI-Cz for pgadmin-hackers@postgresql.org; Tue, 03 Apr 2018 15:04:48 +0000 Received: by mail-wm0-x230.google.com with SMTP id f125so35845912wme.4 for ; Tue, 03 Apr 2018 08:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gpQtYuZ+TYbwvZJEt1MJkG/aN5cN2VcRZ/u7hR+hcB4=; b=mSQ9AgiwaEHi3M1HXapfe2mF6hNVNQ45FmpAUC9IQj8ZPJ4LpJb6imiA3cK2FjRyo1 yhRRS9L2PYN+lc7+gaiSgrjgHWEzMh0DX+GDLTuCdK0l4S7U9CwnpWfHrW+o91HmNZGD lGUY+ucyCAxsk2vdagUUIQfhXuN+0fFXPP3JzT0d9gcZ1wSvV7U+ghYiR6x8JY1lkdBS LQcSSTdvuiWjxNantfxOyIsRGxxKRJFiva6bVcpUSIm6/66qoSWSG6yDzHeXQri/c8hR RbeOiWSams+W7tuZNMNI1QV82UNd8SJOP/zegd7lIhN83ugeoazRyLHlQ5bxErXNsCl9 nE0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gpQtYuZ+TYbwvZJEt1MJkG/aN5cN2VcRZ/u7hR+hcB4=; b=C72EREeNLES6LXsZV47jsaZwiTx+FfqUtf8Vv217Uk41Ery4xarGdj6OmSEGmVZlDA 2yAqN6sMCs4V096sV3LLdWk+tnsso9hW6mrFuLjsUR+5seJlbLcxwZJrCB5VXszfMhze YUlr4vQX5Kuo+Jof5y6VLIR1QcvAK9u4slmaJWELmlWuEXE+j2jMR7ozsnD0musK2VR+ yAbgPtEt7Tb9NOSziwWE07mhtLPnmCObMygiUQxaDK1Fhr0t9s+jhk4YZgjQbbX9ZWhF MsLAOlc5gFP0GV9CNFsnzGgIfj4CJaA1TRER/XhhT6WGow/G7UPvX94y1exi4UCeXO+L 4HFQ== X-Gm-Message-State: AElRT7HPQ7vyg4eDIv9PbneasT9P6Rt/GkSKiuMjmlG5APfZP8p44GHe +mxTT2cHtfwkYKF3ZRjhZGcolOoFFLYd35lc3cl+wQ== X-Google-Smtp-Source: AIpwx48+9UvZBZVPZaIPIMRRgOr2rpB+GmrH8RftAkKLCXfSd38u0BPRjYDBFByQK3KddVonUSID975TL0tVeqLwY4s= X-Received: by 10.28.91.65 with SMTP id p62mr5061145wmb.140.1522767883368; Tue, 03 Apr 2018 08:04:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Tue, 3 Apr 2018 08:04:42 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 3 Apr 2018 16:04:42 +0100 Message-ID: Subject: Re: v3.0 release on hold To: Robert Eckhardt Cc: Joao De Almeida Pereira , Akshay Joshi , pgadmin-hackers , Murtuza Zabuawala , Khushboo Vashi , Syed Fahar Abbas , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary="001a1144161ac38cf90568f30633" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1144161ac38cf90568f30633 Content-Type: text/plain; charset="UTF-8" I'm thinking build Monday, release Thursday. Objections? On Tue, Apr 3, 2018 at 2:43 PM, Robert Eckhardt wrote: > All, > > Where are we with respect to cutting this release? > > -- Rob > > On Mon, Mar 26, 2018 at 9:59 AM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hi Hackers, >> >> Did we had any progress on the things that are holding the release back? >> >> Thanks >> Joao >> >> On Fri, Mar 23, 2018 at 9:26 AM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> On Fri, Mar 23, 2018 at 11:06 AM, Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On Thu, Mar 22, 2018 at 10:24 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Thu, Mar 22, 2018 at 1:13 PM, Dave Page wrote: >>>>> >>>>>> >>>>>>>>>> 2) Starting a second instance of the app bundle on Mac doesn't >>>>>>>>>> always open a new pgAdmin window as it should. It works fine in the >>>>>>>>>> debugger, or if you start the app with a command like: >>>>>>>>>> "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It >>>>>>>>>> doesn't work if you double-click the appbundle or use a command like "open >>>>>>>>>> /Applications/pgAdmin\ 4.app" >>>>>>>>>> >>>>>>>>> >>>>>>>>> Still working on this, not found any solution yet. >>>>>>>>> >>>>>>>> >>>>>>> Not able to figure out the solution yet. I have tried to >>>>>>> debug the code, but every time it will create a new instance(tray icon). Do >>>>>>> I need to look into the code or something related to app bundle may be some >>>>>>> settings in info.plist or any other pointer? >>>>>>> >>>>>> >>>>>> Have a look at the code around line 85 an onwards of pgAdmin4.cpp. It >>>>>> creates the shared memory interlock (and log/address files) based on the >>>>>> current username and a hash of the executable name/path. My suspicion is >>>>>> that the path hash (which is calculated from argv[0] on line 72) is for >>>>>> some reason getting a different value each time when launched via the >>>>>> Finder or "open", thus the interlock is failing. >>>>>> >>>>> >>>>> So I took a look at this, and it seems the code is just fine. What is >>>>> happening is that macOS only allows a single instance of an app to run at >>>>> once. Whilst that is what we want of course, macOS is causing the new >>>>> instance to exit before it has a change to open a new pgAdmin window. Using >>>>> "open -n ..." or calling the embedded executable directly resolves that >>>>> issue. >>>>> >>>>> So, there's another challenge to figure out... :-( >>>>> >>>> >>>> OK. Will try to figure that out. >>>> >>> >>> After googled I have tried following solution: >>> >>> 1. Create a shell script "launch.sh" and kept it in "/Applications/pgAdmin\ >>> 4.app/Contents/MacOS" folder. That shell script will contain the command >>> "open -n /Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". >>> Change the "CFBundleExecutable" parameter of Info.plist from "pgAdmin4" to >>> "launch.sh". It didn't work, shall script didn't launch. >>> 2. Create one apple script with command like "do shell execute "/Applications/pgAdmin\ >>> 4.app", compile it and save it as Application. It create the app bundle, >>> copy contents of pgAdmin4 app to this newly created application. But the >>> problem is it opens and having icon in the dock and no response on double >>> click (second time). >>> >>> Will continue to figure out some other solutions tomorrow. >>> >>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>> 976-788-8246 <+91%2097678%2088246>* >>>> >>> >>> >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>> 976-788-8246 <+91%2097678%2088246>* >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1144161ac38cf90568f30633 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I'm thinking build Monday, release Thursday.

<= /div>
Objections?

On Tue, Apr 3, 2018 at 2:43 PM, Robert Eckhardt &= lt;reckhardt@pivo= tal.io> wrote:
All,

Where are we with respect to cutting this rele= ase?=C2=A0

-- Rob

On Mon, Mar 26, 2018 at 9:59 AM, Joao De Almeida Pereira <jde= almeidapereira@pivotal.io> wrote:
Hi Hackers,

Did we had any progr= ess on the things that are holding the release back?

Thanks
Joao

On Fri, Mar 23, 2018 at 9:26 AM Akshay Joshi <akshay.josh= i@enterprisedb.com> wrote:
Hi Dave

On Fri, Mar 23, 2018 at 11:06 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:


On Thu, Mar 22, 2018 at 10:24 PM, Dav= e Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Mar 22, 2018 at 1:13 PM, Dave Page <dpage@pgad= min.org> wrote:

2) Starting a second instance of the app bundle on Mac doesn't= always open a new pgAdmin window as it should. It works fine in the debugg= er, or if you start the app with a command like: "/Applications/pgAdmi= n\ 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you dou= ble-click the appbundle or use a command like "open /Applications/pgAd= min\ 4.app"

=C2=A0 = Still working on this, not found any solution yet.
<= /blockquote>

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Not able to figure out the solution yet= . I have tried to debug the code, but every time it will create a new insta= nce(tray icon). Do I need to look into the code or something related to app= bundle may be some settings in info.plist or any other pointer?=C2=A0

Have a look at t= he code around line 85 an onwards of pgAdmin4.cpp. It creates the shared me= mory interlock (and log/address files) based on the current username and a = hash of the executable name/path. My suspicion is that the path hash (which= is calculated from argv[0] on line 72) is for some reason getting a differ= ent value each time when launched via the Finder or "open", thus = the interlock is failing.

So I took a look at this, and it seems the code is just fine.= What is happening is that macOS only allows a single instance of an app to= run at once. Whilst that is what we want of course, macOS is causing the n= ew instance to exit before it has a change to open a new pgAdmin window. Us= ing "open -n ..." or calling the embedded executable directly res= olves that issue.

So, there's another challeng= e to figure out... :-(=C2=A0

<= /div>
=C2=A0 =C2=A0 OK. Will try to figure that out.=C2=A0

=C2=A0= =C2=A0 =C2=A0 =C2=A0 After googled I have tried following solution:=C2=A0<= /div>
  1. Create a shell script "launch.sh" and kept it i= n=C2=A0 "/Applications/pgAdmin\ 4.app/Conten= ts/MacOS" folder. That shell script will contain the command "ope= n -n=C2=A0/Applications= /pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". Change the "= ;CFBundleExecutable" parameter of Info.plist from "pgAdmin4"= to "launch.sh".=C2=A0 It didn't work, shall script didn'= t launch.
  2. Create one apple script with command like "do shell execute &= quot;/Applications/pgAdmin\ 4.app", compile = it and save it as Application. It create the app bundle, copy contents of p= gAdmin4 app to this newly created application. But the problem is it opens = and having icon in the dock and no response on double click (second time).<= /span>
=C2=A0 =C2=A0 =C2=A0 =C2=A0Will continue to f= igure out some other solutions tomorrow.=C2=A0 =C2=A0 =C2=A0=C2=A0=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com<= br>Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpri= se PostgreSQL Company



--
<= span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;= border-collapse:collapse">Akshay Joshi
Sr. Software Architect


Phone: <= a href=3D"tel:+91%2020%203058%209517" value=3D"+912030589517" target=3D"_bl= ank">+91 20-3058-9517
Mobile: +91 976-788-8246
=


--
Akshay Joshi
Sr. Soft= ware Architect
=
=





--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a1144161ac38cf90568f30633--