MIME-Version: 1.0
In-Reply-To: 
 <CAFOhELc21et_BLjzrcro8_tk5-EDfHYP-cmuhST2s9wzR5o9ng@mail.gmail.com>
References: 
 <CAFOhELc-ST96E35Wcih=uXuXYe5ahnb4Qp+WWAYFPDBP1XTr=g@mail.gmail.com>
 <CA+OCxow84Sigyn=2QQj4RKEV8ManXNqrg4kSmvhxgvbiFn8cpw@mail.gmail.com>
 <CAFOhELc21et_BLjzrcro8_tk5-EDfHYP-cmuhST2s9wzR5o9ng@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 29 Mar 2018 14:24:54 +0100
Message-ID: 
 <CA+OCxoyp9smBhDexiWeCOcp4H8PAwnpkHnmg2ojZDtOSAFd=qw@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to
 disable alertifyjs and acitree animations
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="f403045c4e22a2b50905688d0c79"
Precedence: bulk

--f403045c4e22a2b50905688d0c79
Content-Type: text/plain; charset="UTF-8"

Hi

On Thu, Mar 29, 2018 at 1:51 PM, Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

>
>
> On Mon, Mar 26, 2018 at 6:07 PM, Dave Page <dpage@pgadmin.org> wrote:
>
>> Hi
>>
>> On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi <
>> khushboo.vashi@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix RM #1978: Add an option to allow
>>> user to disable alertifyjs and acitree animations.
>>>
>>
>> I think these really need to be per-user settings, not per-installation..
>> Whether or not animations are shown is really a matter of personal taste
>> and circumstance.
>>
>> Right, it should be per-user settings.  Please find the attached updated
> patch.
>

I found some issues I'm afraid:

- The label "Enable dialogues/notifications animation?" should read "Enable
dialogue/notification animation?"

- Disabling treeview animation only seems to affect the main browser
treeview, and not others in the application (e.g. the one on the
Preferences panel).

 - After disabling dialogue/notification animations, I cannot re-enable
notification animations. If I flip the switch back on, dialogue animations
immediately start working again, but notification animations don't even
work following a reload.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--f403045c4e22a2b50905688d0c79
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Thu, Mar 29, 2018 at 1:51 PM, Khushboo Vashi <span dir=3D"ltr">&lt=
;<a href=3D"mailto:khushboo.vashi@enterprisedb.com" target=3D"_blank">khush=
boo.vashi@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gm=
ail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,=
204,204);padding-left:1ex"><div dir=3D"ltr"><br><div class=3D"gmail_extra">=
<br><div class=3D"gmail_quote"><span class=3D"gmail-">On Mon, Mar 26, 2018 =
at 6:07 PM, Dave Page <span dir=3D"ltr">&lt;<a href=3D"mailto:dpage@pgadmin=
.org" target=3D"_blank">dpage@pgadmin.org</a>&gt;</span> wrote:<br><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px=
 solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi<br><div class=
=3D"gmail_extra"><br><div class=3D"gmail_quote"><span>On Mon, Mar 26, 2018 =
at 7:23 AM, Khushboo Vashi <span dir=3D"ltr">&lt;<a href=3D"mailto:khushboo=
.vashi@enterprisedb.com" target=3D"_blank">khushboo.vashi@enterprisedb.c<wb=
r>om</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex"><div dir=3D"ltr">Hi,<div><br></div><div>Please find the attached patch=
 to fix RM #1978: Add an option to allow user to disable alertifyjs and aci=
tree animations.</div></div></blockquote><div><br></div></span><div>I think=
 these really need to be per-user settings, not per-installation.. Whether =
or not animations are shown is really a matter of personal taste and circum=
stance.</div><div><br></div></div></div></div></blockquote></span><div>Righ=
t, it should be per-user settings.=C2=A0 Please find the attached updated p=
atch.=C2=A0</div></div></div></div></blockquote><div><br></div><div>I found=
 some issues I&#39;m afraid:</div><div><br></div><div>- The label &quot;Ena=
ble dialogues/notifications animation?&quot; should read &quot;Enable dialo=
gue/notification animation?&quot;</div><div><br></div><div>- Disabling tree=
view animation only seems to affect the main browser treeview, and not othe=
rs in the application (e.g. the one on the Preferences panel).</div><div><b=
r></div><div>=C2=A0- After disabling dialogue/notification animations, I ca=
nnot re-enable notification animations. If I flip the switch back on, dialo=
gue animations immediately start working again, but notification animations=
 don&#39;t even work following a reload.</div><div></div></div><div class=
=3D"gmail_extra"><br></div>Thanks.<br clear=3D"all"><div><br></div>-- <br><=
div class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.=
blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter:=
 @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" t=
arget=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise PostgreS=
QL Company<br></div>
</div></div>

--f403045c4e22a2b50905688d0c79--