Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erjLZ-0001hu-Ox for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 11:59:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erjLY-0006lC-Sc for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 11:59:32 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erjLY-0006l2-K9 for pgadmin-hackers@lists.postgresql.org; Fri, 02 Mar 2018 11:59:32 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erjLV-0007sJ-Cs for pgadmin-hackers@postgresql.org; Fri, 02 Mar 2018 11:59:31 +0000 Received: by mail-wm0-x242.google.com with SMTP id a20so2672310wmd.1 for ; Fri, 02 Mar 2018 03:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QHodDv84y3ScKERt6BWfGfvbYzOv2aWC+0exzpIQat0=; b=AaQZLQ3rrMZuJPLWIR14ASxEdXXeAKLMVReKR8RYlUZ0E8+81M4d7ErpMOBGEWfPTR eDUkGoKDrKl7NnbfXwm5va+Zyr3JrjkVmK+NLywqKLA7NsCZS14bMv2DZtq679XEJmCQ APVuVzb6j9/TsYOLdZ8izVn91wwVOJKHz4yOqa5jOYWTt9UmboCKFECzDc0Cy7UDIXrS vvmk0mWXrkmlVXuTFhlSD/lzBNSJbD30VbXoF9C5YbCpEsW4xGnjnEvxQnVhPkuFSc12 OqpvpFM4ZmDWQ6+MsR77PmCHszRJPmQBPkZxBYZn5cMFCkSXo+LVckP2vwnhricb5VS8 DnAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QHodDv84y3ScKERt6BWfGfvbYzOv2aWC+0exzpIQat0=; b=Qg8tFBL2unX3khLFupFHZPZGL1cpr9D+mF6JoBZCIsf5V4FntPJ9vylRfleQKy1gZw fFQZc8fJMDXzWRVh+H+24jgO9anxfNrqw1+kaQkZPQAmTFYmSzDML0eDkyLSfTwNAQKD GI67Pm5lDyDMVeERmUYmhfwoQtqIw0+qZYOIY3q15l2m8dZpmI+hF1HjTqILKvwcr6ZG J2eIctnYoFu38zDDqsw3jPUqySLSnfWccIsboDCNj71lah03Te6O9C/ewrvGSRgWhyWG qfeo1dvXrn6cRWKUp3+/GVxcu4P2D+ac/nqyYPSAucbNpTIdoxgD4vTg1hjshucLngt2 WkzA== X-Gm-Message-State: AElRT7GWC1YABYCcWxkpgStute7bk2Sms7jXVnWJM2yvIdZU8CWHuRtw I/jS0m0DQWziBS2ajSmANjGRrMj1iG+xQHnsenwyJQ== X-Google-Smtp-Source: AG47ELugQfhk3QDecb0yiEQtopQ5o/wdz9qYm+0HQjaMRxnfzEjoCgRwJp9CeMwFToMnaN/vI27G/SVQUMUdQMPDoCU= X-Received: by 10.28.61.65 with SMTP id k62mr928436wma.140.1519991967693; Fri, 02 Mar 2018 03:59:27 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Fri, 2 Mar 2018 03:59:27 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 2 Mar 2018 11:59:27 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3161] Fix PEP-8 issues To: Murtuza Zabuawala Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114af6ce4bcda505666cb509" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114af6ce4bcda505666cb509 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Thu, Mar 1, 2018 at 5:13 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Thank you Joao for reviewing. > > On Thu, Mar 1, 2018 at 3:10 AM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hello Murtuza, >> >> I passed the patch through our CI and all test are green. Also run the >> codestyle in all those folders and everything is clean. >> >> 575 issues to go >> >> Thanks >> Joao >> >> On Wed, Feb 28, 2018 at 1:05 PM Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch to fix the PEP8 issues in Casts, Event triggers, Extensions >>> and Languages module. >>> >>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/ >>> servers/databases/languages/ >>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/ >>> servers/databases/extensions/ >>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/ >>> servers/databases/event_triggers/ >>> pycodestyle --config=.pycodestyle pgadmin/browser/server_groups/ >>> servers/databases/casts/ >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114af6ce4bcda505666cb509 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Thu, Mar 1, 2018 at 5:13 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Thank you Joao fo= r reviewing.

On Thu, Mar 1, 2018 at 3:10 AM, Joao De Alme= ida Pereira <jdealmeidapereira@pivotal.io> wrote:=
Hello Murtuza,

=
I passed the patch through our CI and all test are green. Also r= un the codestyle in all those folders and everything is clean.
575 issues to go

Thanks
Joa= o

On Wed, Feb 28= , 2018 at 1:05 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.co= m> wrote:
<= div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">Hi,
<= div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">
=
PFA patch= to fix the PEP8 issues in=C2=A0Casts, Event triggers, Extensions and Langu= ages module.

pycodestyle --config=3D.pycod= estyle pgadmin/browser/server_groups/servers/databases/languages/
pycodestyle --config=3D.pycodestyle pgad= min/browser/server_groups/servers/databases/extensions/
pycodestyle --config=3D.pycodestyle pgadmin/browse= r/server_groups/servers/databases/event_triggers/
pycodestyle --config=3D.pycodestyle pgadmin/b= rowser/server_groups/servers/databases/casts/

--
Rega= rds,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>
<= br>




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a114af6ce4bcda505666cb509--