Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlWAq-0000Sv-Lq for pgadmin-hackers@arkaria.postgresql.org; Thu, 11 Jul 2019 10:19:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hlWAo-00061G-QN for pgadmin-hackers@arkaria.postgresql.org; Thu, 11 Jul 2019 10:19:34 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlWAo-0005yX-9U for pgadmin-hackers@lists.postgresql.org; Thu, 11 Jul 2019 10:19:34 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlWAl-00067b-4z for pgadmin-hackers@postgresql.org; Thu, 11 Jul 2019 10:19:32 +0000 Received: by mail-wm1-x342.google.com with SMTP id w9so6630332wmd.1 for ; Thu, 11 Jul 2019 03:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ErObRzU4f8mZ5xhMKDJtMOl2FsHT2j27NUJbnc5AsAM=; b=jL2Lxj2lHKDwZchsO4Q4Yh5D3cdGbOVcJFMTT1UK/oTl9xLdy9ZyMnlgt4YdlGVWwN qpLd5zHXNyagw9TJ2t8/CJBmazVWacRIb+uChY2TPv6w7nCWylBysfLVz9WbeeYxRLrp Hk44Qn+mCu+KK9DS3SuRC1py1OO3dYyMEzTfBS4IXbzpEP2vZ+qMcmcev4F56p6JQvDj okiofia92tY9U6Gl9J3HpU6nERzSmvT0iRMGeawKg6BTAObrCvHeabiiz0AzHV3YhHvk P2/Vfle5lirIQGmEpJhYEiR6U6ijMmTk2rn8ClL+xKLTLg77BEgebHIc9XqIAOgav6ha quwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ErObRzU4f8mZ5xhMKDJtMOl2FsHT2j27NUJbnc5AsAM=; b=SeLAyKrF89GDL+2s97eEHKiaCHrt4v8bzutEPO1z3q168PSg9nP6c/OgzqOs+MIjFt pKrpXYoHHn6yb7Jn+FxCj4c4OfJeT7ENJ9Rk5vQKLYi2X88XXkbsER8grqRnSEjdl6ta n1pKdKRm54k9G7DuSQiVRv1dWyDJ7a87jaLQAis/jb5wWclzcfBb6oO2WQQWBM3Gck5S j12FnDrmEzgcP7XecNKaX6uPtRgWXawShfEruTLmO85mmdduIBw8/JfShKa7Y4So8SSX T+ac8NoNCx/N/AAno+TmuwHnzwtTv/ujL01GyD/bZj7SwvAvzbZ1FW2d7VCaKCFO9AdM azFQ== X-Gm-Message-State: APjAAAVSMTyJD67K84dqzpuc0O0S23kDJvJ3tKqcaEIeudPLIyjWCegi gLiLa4CkLe1QpWtXSfQFxwI7ieKxIdaxO6DntjDtbA== X-Google-Smtp-Source: APXvYqw2sfL1MxNWWFbuE+fXH2YPPqE86DbMZZ1ZhswcgVGJBKU7t0dJz9zSUb4E7zfOgapp7t7+uDK32Y1G/5Z9Uks= X-Received: by 2002:a1c:107:: with SMTP id 7mr3525129wmb.84.1562840369728; Thu, 11 Jul 2019 03:19:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 11 Jul 2019 11:19:02 +0100 Message-ID: Subject: Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control To: Ganesh Jaybhay Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000001452d2058d652127" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001452d2058d652127 Content-Type: text/plain; charset="UTF-8" Hi Ganesh, It looks like this has broken the Jasmine tests (which I admit I forgot to run before committing). Can you fix ASAP please? Thanks. On Thu, Jul 11, 2019 at 10:14 AM Dave Page wrote: > Thanks - patch applied with some doc tweaks. > > No need for a new ticket! > > On Thu, Jul 11, 2019 at 7:00 AM Ganesh Jaybhay < > ganesh.jaybhay@enterprisedb.com> wrote: > >> Hi Dave, >> >> Ticket number 3919 refers to keyboard accessibility issues for sub-node >> control and back grid but this patch covers only sub-node control. Should I >> create new one? >> I have added the screenshot having newly added shortcut and updated >> keyboard shortcut rst file. Also moved the code changes from backgrid.js to >> backgrid.pgadmin.js. >> >> Please find the attached updated patch. >> >> Regards, >> Ganesh Jaybhay >> >> On Tue, Jul 9, 2019 at 9:28 PM Dave Page wrote: >> >>> Hi, >>> >>> What's the ticket number for this? That's a fair amount of code for a >>> one-line description. There are also no doc changes describing how to >>> navigate the sub-node control that I can see. >>> >>> Also; instead of changing the repo used for backgrid, can we not >>> un-vendorise it? >>> >>> On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay < >>> ganesh.jaybhay@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch for keyboard accessibility of sub-node control. >>>> It also covers sub-node dialog forward/backward tab navigation with >>>> shortcuts. >>>> >>>> Kindly review. >>>> >>>> Regards, >>>> Ganesh Jaybhay >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000001452d2058d652127 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ganesh,

It looks like this has broke= n the Jasmine tests (which I admit I forgot to run before committing). Can = you fix ASAP please?

Thanks.

On Thu, Jul 11, = 2019 at 10:14 AM Dave Page <dpage@p= gadmin.org> wrote:
Thanks - patch applied with some doc tweaks.
No need for a new ticket!

On Thu, Jul 11, 2019 at 7:0= 0 AM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
Hi Dave,

Ticket number 3919 refers to keyboard = accessibility issues for sub-node control and back grid but this patch cove= rs only sub-node control. Should I create new one?
I have added t= he screenshot having newly added shortcut and updated keyboard shortcut rst= file. Also moved the code changes from backgrid.js to backgrid.pgadmin.js.=

Please find the attached updated patch.

Regards,
Ganesh Jaybhay

On Tue, Jul 9, 2019 = at 9:28 PM Dave Page <dpage@pgadmin.org> wrote:
Hi,

What's th= e ticket number for this? That's a fair amount of code for a one-line d= escription. There are also no doc changes describing how to navigate the su= b-node control that I can see.

Also; instead of ch= anging the repo used for backgrid, can we not un-vendorise it?
<= br>
On Mon,= Jul 8, 2019 at 4:49 PM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com>= ; wrote:
Hi Hackers,

Attached is the p= atch for keyboard accessibility of sub-node control. It also covers sub-nod= e dialog forward/backward tab navigation with shortcuts.

Kindly review.

Regards,
Ganesh Ja= ybhay


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twi= tter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Pos= tgreSQL Company


--
Dave Page
Blog: <= a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blo= gspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--0000000000001452d2058d652127--