Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6Jzp-0002oG-MF for pgadmin-hackers@arkaria.postgresql.org; Fri, 27 May 2016 15:48:21 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b6Jzp-0003um-3n for pgadmin-hackers@arkaria.postgresql.org; Fri, 27 May 2016 15:48:21 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b6Jzo-0003ue-Fb for pgadmin-hackers@postgresql.org; Fri, 27 May 2016 15:48:20 +0000 Received: from mail-ig0-x233.google.com ([2607:f8b0:4001:c05::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b6Jzk-0005Lo-Rp for pgadmin-hackers@postgresql.org; Fri, 27 May 2016 15:48:19 +0000 Received: by mail-ig0-x233.google.com with SMTP id ww4so109803775igb.1 for ; Fri, 27 May 2016 08:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=CSq+z8DXgqOd4BIWKMDkHQ7L3nT7TemG4il374HGams=; b=eFVjYEtwsgP2CzOKyygzrQ4ieKV4+R9OtT2zZ6K9FCV4+B2ZP8xJo6ZIDlkjTQtLyb 3zCDOIZTXYVfQtykUhTe/Y1/oKVtpgGZu3hmbDlSC0bpucuiqfVe+p+q6VfKXmd+dICH ob1OZ9XwpomBiIE9QCgmT2L1jevMabHztg6DssWin/xshlgr4JQUPKI8tkUmM/zo/RnE vcDPRws+IEpQEtOVDGHN8NL52A6KR690Gs4aMfh6fwK3wREj9pp7xRz2p5PQj2nH7r7/ SEpIVFUm8K/XD4n+1lTy6mmGVt4Gtes+frvk6dLbTBPAmZBshLlQTkaXi14x9Oa9H0o1 3bUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=CSq+z8DXgqOd4BIWKMDkHQ7L3nT7TemG4il374HGams=; b=XbyQQp4PebnKE71ZKGVJhrpdeeIQ0YiAw7rZIr7XS4gtiiJ/VhCKRmdjEIH327PQro Hcj7QKIAAhVIkj44kpL5Qz3FjossqsgvetOMTFxLe7oIrP6E2tVlNRwrHkkaBLy6Z8sw 8VjWZyW4XwXc9Zu5GchJJzybQk8LsETx6GcsZqxliBHUYi5UC+LFuwHW1f+lihHC2Pnt 96qIGS4ZyMpdrT1MzH1NzC9dwoxxsy+Qg1nz2HKt/+gyc6lfD9EaFxn86YK0CGCmS9cP PKgNAq11KgGw1vNWDd3BviIkD0IL3MmWChPgnxxLnXb20G6dtWWLL2Bbwn2NIhQAH2xV csXQ== X-Gm-Message-State: ALyK8tIQIUcWhGBNGzxyxatiW/wsDlYpxd9tI/R7EFc/6XUn+ElXZ4bPspT+wl25Lzet7FY0q+wbopqhAz28Iw== MIME-Version: 1.0 X-Received: by 10.50.7.100 with SMTP id i4mr8978222iga.69.1464364095722; Fri, 27 May 2016 08:48:15 -0700 (PDT) Received: by 10.64.236.101 with HTTP; Fri, 27 May 2016 08:48:15 -0700 (PDT) In-Reply-To: References: Date: Fri, 27 May 2016 16:48:15 +0100 Message-ID: Subject: Re: Patch for pgAdmin4 package on Mac OS X From: Dave Page To: Sandeep Thakkar , pgadmin-hackers , Hamid Quddus Content-Type: multipart/alternative; boundary=089e0111bbb0bfc3a30533d4d5af X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --089e0111bbb0bfc3a30533d4d5af Content-Type: text/plain; charset=UTF-8 On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar < sandeep.thakkar@enterprisedb.com> wrote: > Sure. Thanks. > > There is a typo in pkg/mac/build.sh. i.e > > s/HTML_HELP/HELP_PATH/ > > > On Fri, May 27, 2016 at 5:26 PM, Dave Page wrote: > >> Not entirely - we definitely need to improve it. I'll review the code as >> it is now though. >> > OK, review time :-) - The appbundle name should be created from APP_NAME.app in config.py, e.g. 'pgAdmin 4.app' - The DMG name should be created from to_lower(remove_spaces(APP_NAME-APP_VERSION)) in config.py, e.g. pgadmin4-1.0-dev.dmg - Use #ifdef Q_OS_MAC in the QT code for Mac-specific code. There's no need to define another macro. - Please add "MINIFY_HTML = False" to config_local.py (and have Paresh do the same on his packages). This works around a code issue with the docs that I'll log a bug for. - In testing, I found that running the app from within the DMG doesn't seem to work the first time - it prompts for the path, then exits. Once I save the path it offers, it's fine on subsequent runs. - Once copied to my laptop, I saw the same issue as above. Once these issues are resolved, I think we're good to commit. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --089e0111bbb0bfc3a30533d4d5af Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar <= sande= ep.thakkar@enterprisedb.com> wrote:
Sure. Thanks.

There is a typo in pkg/mac/bui= ld.sh. i.e

s/HTML_HELP/HELP_PATH/


=
On Fri, May 27, 2016 at 5:26 PM, Dave Page <dpa= ge@pgadmin.org> wrote:
N= ot entirely - we definitely need to improve it. I'll review the code as= it is now though.
<= div>
OK, review time :-)

- The appbu= ndle name should be created from APP_NAME.app in config.py, e.g. 'pgAdm= in 4.app'

- The DMG name should be created fro= m to_lower(remove_spaces(APP_NAME-APP_VERSION)) in config.py, e.g. pgadmin4= -1.0-dev.dmg

- Use=C2=A0#if= def Q_OS_MAC in the QT code for Mac-specific code. There's no need to d= efine another macro.

- Please add "MINIFY_HTML =3D False" to config_l= ocal.py (and have Paresh do the same on his packages). This works around a = code issue with the docs that I'll log a bug for.

- In testing, I found that = running the app from within the DMG doesn't seem to work the first time= - it prompts for the path, then exits. Once I save the path it offers, it&= #39;s fine on subsequent runs.

- Once copied to my laptop, I saw the same issue a= s above.

Once these issues are resolved, I think we're good to commit.
<= div class=3D"gmail_extra">
Thanks!

--
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--089e0111bbb0bfc3a30533d4d5af--