Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1euJsN-0007it-Nx for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Mar 2018 15:24:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1euJsM-0003se-EQ for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Mar 2018 15:24:06 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1euJsL-0003sH-TR for pgadmin-hackers@lists.postgresql.org; Fri, 09 Mar 2018 15:24:06 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1euJsI-0006Ol-FI for pgadmin-hackers@postgresql.org; Fri, 09 Mar 2018 15:24:04 +0000 Received: by mail-wm0-x244.google.com with SMTP id w128so4633849wmw.0 for ; Fri, 09 Mar 2018 07:24:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G5DF+7S6vp9N5quQe2edt54odPeB7/kSUm5jxBMuhcA=; b=J6lC2FmpxVleSIMOdSUk9m0c4Y3iPtj1z+7Gp4Y1yWRkpIX+epf8ReRqEWegm1h4ID bIlGc70B9ydLxaCwZtWV6FUxJ9KzI1Jh+whEf6Xod/J9XTpZeY2Y4GNj2Kc5x18M9tku /g/5v6U/WKnba7bPXqmEzKafzTXR6N3GR7ysU51cd04cx9Ohfz7jcgyPyNQfTsa0PTm1 MOBxadDvhWdysT3e+z6fQjFYUmGzb4V5+eJsznIyfO0PIP1XBFZKCjQ24n4STOnjqz7o hFTx2UB05h8CtNe27+6c5VimGWwGTCkLiqGjJYM9P5z0G6rN1d1eGQhVY+DTHJb9pELl x6JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G5DF+7S6vp9N5quQe2edt54odPeB7/kSUm5jxBMuhcA=; b=Ne3YLQY0FOCeW8EuhMjGaDzJTXABlSIZlILkGWDguiszMToo9SGuR5qEFJyXX4ewEU UjglFETrkHyAzanNIXCK8wcm+e1UVp1Wu6m6zcpFiQZfC7DbxdDDDOEwqrzY2iHEglDP 4zN0IrRbL/zc5VhAJ63HC4IGvokKhOXNYc6vZnw+bojmAftSeZQ0CHsseqO15+WLwTlQ clgSK+TnssjUCfm86UsfBprUfrRbpHSyD4DjcBXG7fTbH6PnGDViTeNoMLut2JHQ/VRR mkmdsE4F4Kg2vv8vmejQJLjpRR14pZIxwFiKzqqoRmwRo4QgCYlg1WEEGOTJ9EEQ9mT8 6SIQ== X-Gm-Message-State: AElRT7FxarivBXbu4t5/Bv0skdhQdONXKdDyYa8aHhZCwxSVgfAaMoaH 0sltpA4IUOZwNyRRXpqh+Ai3leGkdm7Vpf7ZMwRQtw== X-Google-Smtp-Source: AG47ELt8pPkBU7KmuBuHMG3Pfop3ekJrgvxopA2k1kh1An8gJpFRUlox9ftCYg4euJz7iSWgxBPdVrSK4zYUl+OJW9g= X-Received: by 10.28.130.9 with SMTP id e9mr2242304wmd.161.1520609040781; Fri, 09 Mar 2018 07:24:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Fri, 9 Mar 2018 07:23:59 -0800 (PST) In-Reply-To: References: From: Dave Page Date: Fri, 9 Mar 2018 15:23:59 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#2989] To fix the issue in Table node To: Murtuza Zabuawala Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a11444b44b7e8b80566fc6192" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a11444b44b7e8b80566fc6192 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Mar 8, 2018 at 6:00 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Thank you Joao > > Regards, > Murtuza > > > On Thu, Mar 8, 2018 at 10:19 PM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hello Murtuza/Dave, >> >> Nice splitting of some of the functionality into functions, removing some >> of the complexity of the initial function. Good job. >> >> I made some changes because the linter was failing and also changed some >> variable names. >> These changes pass our CI and the linter. >> >> Thanks >> Joao >> >> On Thu, Mar 8, 2018 at 8:13 AM Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Please find updated patch. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> On Thu, Mar 8, 2018 at 6:10 PM, Dave Page wrote: >>> >>>> Can you rebase this please? >>>> >>>> Thanks. >>>> >>>> On Thu, Mar 8, 2018 at 9:00 AM, Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> Please find updated patch & updated test case to cover that as well. >>>>> >>>>> >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> >>>>> On Wed, Mar 7, 2018 at 9:59 PM, Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala < >>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> PFA updated patch. >>>>>>> >>>>>>> >>>>>> Using your example on the ticket, I added a "character varying (32)" >>>>>> column with NOT NULL to the table. When I then edit the column, and turn >>>>>> off NOT NULL (making no other changes), the SQL generated is: >>>>>> >>>>>> ALTER TABLE public.test_drop >>>>>> ALTER COLUMN col2 TYPE character varying (32) COLLATE >>>>>> pg_catalog."default"; >>>>>> ALTER TABLE public.test_drop >>>>>> ALTER COLUMN col2 DROP NOT NULL; >>>>>> >>>>>> I didn't see that when turning off NOT NULL for col1. >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a11444b44b7e8b80566fc6192 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.
On Thu, Mar 8, 2018 at 6:00 PM, Murtuza Zabuawa= la <murtuza.zabuawala@enterprisedb.com> wro= te:
Thank you J= oao

Regards,
Murtuza=C2=A0


On Thu, Mar 8, 2018 at= 10:19 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.i= o> wrote:
= Hello Murtuza/Dave,

Nice splitting of some of the functi= onality into functions, removing some of the complexity of the initial func= tion. Good job.

I made some changes because the li= nter was failing and also changed some variable names.
These chan= ges pass our CI and the linter.

Thanks
J= oao

On Thu, Mar 8, 201= 8 at 8:13 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com= > wrote:
Hi Dave,

Please find updated pat= ch.
=
--
Regards,
Murtuza Zab= uawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company

=

On Thu, Mar= 8, 2018 at 6:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Can you rebase this please= ?

Thanks.

On Thu, Mar 8, 2018 at 9:00 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wro= te:
Hi Dave,

Please find updated patch & updated t= est case to cover that as well.



-= -
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.ente= rprisedb.com
The Enterprise PostgreSQL Company

=

On Wed, Mar 7, 2018 at 9:59 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala &l= t;m= urtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

PFA updated patch.


Using your example on the ticket, I added a "character varying (32)= " column with NOT NULL to the table. When I then edit the column, and = turn off NOT NULL (making no other changes), the SQL generated is:

ALTER TABLE public.test_drop
=C2=A0 =C2=A0 = ALTER COLUMN col2 TYPE character varying (32) COLLATE pg_catalog."defa= ult";
ALTER TABLE public.test_drop
=C2=A0 =C2=A0 A= LTER COLUMN col2 DROP NOT NULL;

I didn't= see that when turning off NOT NULL for col1.

--
Dave Page
Blog: http://pgsnake.blogs= pot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
= The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogsp= ot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a11444b44b7e8b80566fc6192--