Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bfPx1-0002k1-Cx for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Sep 2016 11:14:31 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bfPx0-0002lO-VX for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Sep 2016 11:14:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bfPwn-0002X4-Hp for pgadmin-hackers@postgresql.org; Thu, 01 Sep 2016 11:14:17 +0000 Received: from mail-it0-x231.google.com ([2607:f8b0:4001:c0b::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bfPwi-0005SC-9p for pgadmin-hackers@postgresql.org; Thu, 01 Sep 2016 11:14:16 +0000 Received: by mail-it0-x231.google.com with SMTP id e124so59782928ith.0 for ; Thu, 01 Sep 2016 04:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LwFQmU25L4m+ckoPgjHM6e1jKSRIZrZXNIuUz+s1X+E=; b=JE/LOK58wVqbfzh3LS/rhFyI5GNJM9M9oSd8ijw9WHcd74P9CINrJGJ43CoWh2/qr5 noDCWKTqy7oE474vRZ6W9Hbm8nHfhBcgV38fVNP+iTHty6wk3ZlHOcALsDGDQUzwJcEd qAKyxolRmNQdhH+L2t7RujRE3Wr8VPIpM0VrNOjU4y6lqUPpxszXAfMtrjDtwcT7CHGx VqMA3ogao27UCufgAD7hRrNeie7fJ1fADKPnGDK9OQaeE803skM4b0LrT5ZGNrHkKydf AqitbMDKp0+bGwF1YHr1TZjulaivGs+f6cexqFGABCpOWg068T8D7PUe9s2DSZi02X7T 7Mqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LwFQmU25L4m+ckoPgjHM6e1jKSRIZrZXNIuUz+s1X+E=; b=Q+SkdJhipwW+z5hFasm43GS8fvpDDY19GDszdAqw6D14ygQQCwZTYeRrHlHJ2EO2DI fd5bAW2TzybWMgSkmgtrUZKBwLN+7NeVTEl36WHRsK8Fr+xXMBoKmHcfMClupUj2VFmF BWbQiv6ab2mLD4zJ2gIgKf0TZrJilDduQOVPaTc5MsCeudKJ82uNozsNVXTV3t+N18pC UsGNOvFnyJz97j2esa3NSDbPREfNA8uJ0E3BDZLjSZnrGEszgPLHuhNCoqp5ejx6PODe D3xN53fRZo7+gCiC5VK5SZPzZcsZEntE9riuMPHI9dxGVrVC6OHjXVCm0PZFyhx80T9U E/IA== X-Gm-Message-State: AE9vXwPguoWOtHgzFJNiFB/OMzcZxCoMks8kOSKZv1mQiFtWdKzuo/bTAzhGCc8LY+cTZpu3a6A36gb4swrk5xW8dJlyJ0ex+UJK5LOFbM0pafW3c2OFvEqg1ykRAR3suVcx5iJh8pIhM5MhyHSlmgDECdOazgcrIPMe97c4ECqPLRq04trMvOkBBVJ1kVzNXRx6Bm1NhA== X-Received: by 10.36.68.135 with SMTP id o129mr20088842ita.0.1472728449962; Thu, 01 Sep 2016 04:14:09 -0700 (PDT) Received: from mail-it0-f49.google.com (mail-it0-f49.google.com. [209.85.214.49]) by smtp.gmail.com with ESMTPSA id 140sm15595768itl.4.2016.09.01.04.14.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Sep 2016 04:14:09 -0700 (PDT) Received: by mail-it0-f49.google.com with SMTP id e124so59782164ith.0 for ; Thu, 01 Sep 2016 04:14:09 -0700 (PDT) X-Received: by 10.36.51.206 with SMTP id k197mr21865189itk.37.1472728448833; Thu, 01 Sep 2016 04:14:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Thu, 1 Sep 2016 04:14:08 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 1 Sep 2016 12:14:08 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: pgAdmin IV : Unittest modular patch (Domains and Tables nodes) To: Navnath Gadakh Cc: pgadmin-hackers , Kanchan Mohitey Content-Type: multipart/alternative; boundary=001a1144dfd00b3ed0053b705081 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1144dfd00b3ed0053b705081 Content-Type: text/plain; charset=UTF-8 Hi Please separate the cleanup from the new tests. Each patch should have just one feature/focus/fix. Thanks. On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh < navnath.gadakh@enterprisedb.com> wrote: > Hello Dave, > Object cleanup work is completed in above patch. I am working on enhanced > summary work, once that's complete I will send the revised patch. > > Thanks! > > On Thu, Sep 1, 2016 at 3:57 PM, Dave Page > wrote: > >> Per my earlier email to Priyanka, I'm not going to commit any more test >> cases until the existing issues are resolved and the enhanced summary and >> object cleanup work is complete, otherwise it's just taking too much time >> unnecessarily. >> >> Please re-test and resubmit this patch once that work is complete. >> >> Thanks. >> >> On Tue, Aug 30, 2016 at 1:02 PM, Navnath Gadakh < >> navnath.gadakh@enterprisedb.com> wrote: >> >>> Hi Dave, >>> Please find the patch API unit test cases for Domain & Tables >>> Nodes. >>> >>> This patch also includes code to drop the all objects(like database, >>> roles, tablespace & server) created during the test suite run. >>> >>> *To run the test suite for domain node:* >>> python regression/runtests.py --pkg browser.server_groups.servers. >>> databases.schemas.domains >>> >>> >>> *To run the test suite for tables node:* >>> python regression/runtests.py --pkg browser.server_groups. >>> servers.databases.schemas.tables >>> >>> *To run the test suite for all nodes *(Comment the all test code in >>> 'synonyms' node i.e. Code under 'tests' directory as its partially >>> completed): >>> python regression/runtests.py >>> >>> >>> -- >>> Thanks, >>> Navnath Gadakh >>> Software Engineer >>> EnterpriseDB Corporation >>> Mobile: +91 9975389878 >>> >>> >>> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > > > -- > Thanks, > Navnath Gadakh > Software Engineer > EnterpriseDB Corporation > Mobile: +91 9975389878 > > > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --001a1144dfd00b3ed0053b705081 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

Please separate the cleanup from the= new tests. Each patch should have just one feature/focus/fix.
Thanks.

On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh <navnath.gadakh@enterprisedb.com> wrote:
Hello Dave,
=C2=A0 =C2=A0 Object c= leanup work is completed in above patch. I am working on=C2=A0enhanced summary work, once that's complete I wil= l send the revised patch.

Thanks!
<= br>
On Thu, Sep 1, 2016 at 3:57 PM, Dave Page <dave.page@enterprisedb.com> wrote:
Per my earlier email to Priyanka, I&#= 39;m not going to commit any more test cases until the existing issues are = resolved and the enhanced summary and object cleanup work is complete, othe= rwise it's just taking too much time unnecessarily.

Please re-test and resubmit this patch once that work is complete.

Thanks.
<= div>
On Tue, Aug 30, 2016 at 1:02 PM, Navnath= Gadakh <navnath.gadakh@enterprisedb.com>= wrote:
Hi Dave,
=C2= =A0 =C2=A0 =C2=A0 =C2=A0Please find the patch API=C2=A0unit test cases for = Domain & Tables Nodes.

This patch also include= s code to drop the all objects(like database, roles, tablespace=C2=A0& = server) created during the test suite run.

To r= un the test suite=C2=A0for domain node:
=C2=A0python regression/runtests.py --pkg browser.server_gro= ups.servers.databases.schemas.domains

= To run the test suite=C2=A0for tables node:
=C2=A0=C2=A0python=C2=A0regression/runtests.py=C2=A0--pkg=C2=A0browser.server_groups.servers.databases.schemas.tables

To run the test suite for all = nodes=C2=A0(Comment the=C2=A0all test code in 'synonyms' node i= .e. Code under 'tests' directory as its partially completed):
=C2=A0=C2=A0python=C2=A0regression/runtests.py


--
=
Thanks,
Navnath=C2=A0Gadakh
Software = Engineer
EnterpriseDB Corporation
Mobile: +91 9975= 389878=C2=A0





<= font color=3D"#888888">--
Dave = Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb= .com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.comTwitter: @pgsnake



--
Thanks,
=
Navnath=C2=A0Gadakh
Software Engineer
EnterpriseDB Co= rporation
Mobil= e: +91 9975389878=C2=A0





--
=
Dave Page=
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Tw= itter: @pgsnake
--001a1144dfd00b3ed0053b705081--