Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJDo9-0006gJ-N2 for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Mar 2021 11:12:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lJDo8-0002IC-8M for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Mar 2021 11:12:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJDo7-0002I5-Eb for pgadmin-hackers@lists.postgresql.org; Mon, 08 Mar 2021 11:12:16 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lJDo4-0004gP-QX for pgadmin-hackers@postgresql.org; Mon, 08 Mar 2021 11:12:14 +0000 Received: by mail-ej1-x635.google.com with SMTP id c10so19437662ejx.9 for ; Mon, 08 Mar 2021 03:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SmbT+gOHMxXh2yeeN1SXgO6Tn8LAEZxt5VDRNZqrulg=; b=oPNUIMp81k6KWekByqisMvM4lmfJixnKWHu4sar3pFGLcehOqdF0G3XDaLE47K/E5y bUrL640nk/40700qAqyAwnZBqMs52wolF5+t+kbpT0eo1Yn9Zx8V+VTp/ULkOdSZOCYx rvievav05pOGfIEUZJxYu6mUXhMk1gY9NqPbsqhp9paBZvS/Dafy8YWPYd2FJ0scVHbr tQy99etyZkPmCdXA62XAUz2BvQHezH5/WTOH8lmcrKN3YUExnD0O72zSaXxo98t5aPQ5 lQoaa6QtJwts6V1xP18pUd3rx+SFCQKeSvbkFR1KwAY0p51y5JPjEYb5FqyzLfiOrcDD zksg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SmbT+gOHMxXh2yeeN1SXgO6Tn8LAEZxt5VDRNZqrulg=; b=es2y7A/W3HYwEWBQRW6INHPU31ijrBIbP7jmhRBAiyp/KGqZy010C8n2aksBgPwyGM 3kwkjKm+7Mvw8TqggtcN58AL466IBP9tA/ZRhZ2lrV7ZWrKIglJUnKcIeAd6hrhHBz4e A3P4PkGH7xjgFapNxFN1FcZtzlmp8tz8aTpiuhT/tEgz9LsSMsZEn7tCgm0osJnnr5Z1 bloyi54frbiyYMWahNFKArf380QpvWMrSezj20pRQg62Hh50qQkmPyhHDKutLf7VLBLI /QyNEIFfZihIGenlgkfIw/7lyFxjEPOvxRM1CTxtlausAYUG5WT0VT8l+SHx+gizDky9 HMzg== X-Gm-Message-State: AOAM531XAIl4WlmlpEgBXmVwOYxtVNyAfCfosvgckBrs1Tog63dMd2aK 47FAaoFT6OOpteYsLoHPddcsu64PnkVlG8Ml/RVFocxX+3dWNA== X-Google-Smtp-Source: ABdhPJzTQ7ijjHBbvnMNB/V1C/jr3PB2fA+VSl2AOLQQzfTPpo5j3nDc6xjUQjjbPJe3DYHKEmTqkwF9lr0myEj+ZZA= X-Received: by 2002:a17:906:aac5:: with SMTP id kt5mr14684617ejb.548.1615201930615; Mon, 08 Mar 2021 03:12:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 8 Mar 2021 11:11:58 +0000 Message-ID: Subject: Re: Making Kerberos optional in the Python wheel To: pgadmin-hackers Cc: Shaheed Haque Content-Type: multipart/alternative; boundary="00000000000050b06505bd0481c8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000050b06505bd0481c8 Content-Type: text/plain; charset="UTF-8" Has anyone been able to review this? On Thu, Mar 4, 2021 at 10:02 AM Dave Page wrote: > There have been a couple of complaints that the latest Python wheel > distribution doesn't install cleanly. This happens when there is no > pre-built gssapi wheel on PyPi that matches the users combination of Python > version and platform, *and* the MIT Kerberos development headers etc. are > not present on the system, so the source wheel cannot be compiled. > > This seems like it's a bit onerous on users, especially if they're on > Windows where they'll also need a suitable compiler to be installed. The > attached patch aims to address that by making the Kerberos support optional > (thankfully, Khushboo made the code handle lack of gssapi libraries). > > To install without gssapi, users would simply do: > > pip install pgadmin4 > > or > > pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl > > To install with gssapi: > > pip install pgadmin4['kerberos'] > > or > > pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl['kerberos'] > > The patch also cleans up some old cruft that was required for now > unsupported Python versions. > > Thoughts? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com --00000000000050b06505bd0481c8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Has anyone been able to review this?

On Thu, Mar 4, 2021 = at 10:02 AM Dave Page <dpage@pgadmi= n.org> wrote:
There have been a couple of complaints that the lates= t Python wheel distribution doesn't install cleanly. This happens when = there is no pre-built gssapi wheel=C2=A0on PyPi that matches the users comb= ination of Python version and platform, *and* the MIT Kerberos development = headers etc. are not present on the system, so the source wheel cannot be c= ompiled.

This seems like it's a bit onerous=C2=A0on = users, especially if they're on Windows where they'll also need a s= uitable compiler to be installed. The attached patch aims to address that b= y making the Kerberos support optional (thankfully, Khushboo made the code = handle lack of gssapi libraries).

To install witho= ut gssapi, users would simply do:

pip install pgad= min4

or=C2=A0

pip install= =C2=A0pip install /path/to/pgadmin4-5.0-py3-none-any.whl

To install with gssapi:

pip install pg= admin4['kerberos']

or=C2=A0

=
pip install=C2=A0pip install /path/to/pgadmin4-5.0-py3-none-any.= whl['kerberos']

The patch also cleans up s= ome old cruft that was required for now unsupported Python versions.
<= div>
Thoughts?

--


--
--00000000000050b06505bd0481c8--