Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eywKi-0000VV-9k for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 09:16:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eywKh-0000T8-09 for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 09:16:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eywKg-0000Sx-L9 for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 09:16:26 +0000 Received: from mail-wr0-x22d.google.com ([2a00:1450:400c:c0c::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eywKc-0001F3-Bs for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 09:16:26 +0000 Received: by mail-wr0-x22d.google.com with SMTP id l8so7888761wrg.5 for ; Thu, 22 Mar 2018 02:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=15S+rn52XKyVfk9Kqrxe6a9guxwH71dZpxY4rc2SpB8=; b=PY0810e1nZ36Sm0Juo+P0iRD1m/1qW9p3K98jobs5VPj3IpG/TnjoODBtZiqt7LMWz CKKzfp2pWKWY4ezE2WNmXja6DDKSKQd7ST4CgLcME3pzIXeQkZGB+4rUdjYwrsY1gWen d0Bt85su3eaBL6iVjFnVMOlMw2KPTS/lG8ZgkNXEwVrq2TY3horCDUC+ZC6m24wajXOh 2dQ0MVEni1xJUZKQZy7Fo3nel8QTfg+OfNWET2yr3mL7k0MlSa7oAQGD+VV1RkymjnRd 0bJtlByTRD5fvF3dL09lZ2PfkU3lNdjKhbimvecafFWZHmDDhuaU3374xsWZWgnvVDIA fNXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=15S+rn52XKyVfk9Kqrxe6a9guxwH71dZpxY4rc2SpB8=; b=LMZM2l0e/FxWcj5cNrYDDrb82yxX/oPrLn52r5f76tBkkGhQTZ4pAjKtQi+d79+g9t 71iwQqnJmO8Rr9oVKDDf1oDf9lpiW0toZwKaoYEueJDU/WY9gyU+VkUP+uWOuD4auip2 EOolMn02LnmbmQGMBYcIUdoRpCd4iv1bT47IXnFTBSXFbFiTN6fk8Yk7uqo6ki4sc+GO DDo8+AlC3nDGB4U+l+EsGPbtlS9hQ0r4k81TQunPETvB1zCwFQziXz4pEO7jA0O4Utvu UDnMor5olcO0yD+hdOuWK3d4thOMYgLX4lMwk/H2KzypFsYVJxy5o5usu9WFzS6+uMAe uxNw== X-Gm-Message-State: AElRT7Efnvy79YFRcKYZgzFDRrY4/dV3RsWW0bnWM7WxSy0tVvOKfYdh UQTa2GFPkIeBFc4Jl/pteUGvvavSjCrAqQojYOdyIA== X-Google-Smtp-Source: AG47ELvW4m6Ur9nxgBWYS39sllU3Rt3wyIsl5MzGLvF1OpVQhAKShKei74W2IbCZPKWOMOUbqzh6TsWJ5Rby1T1VjiM= X-Received: by 10.223.159.74 with SMTP id f10mr1760298wrg.49.1521710178484; Thu, 22 Mar 2018 02:16:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Thu, 22 Mar 2018 02:16:17 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 22 Mar 2018 09:16:17 +0000 Message-ID: Subject: Re: v3.0 release on hold To: Joao De Almeida Pereira Cc: Khushboo Vashi , pgadmin-hackers , Akshay Joshi , Murtuza Zabuawala , Syed Fahar Abbas , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary="089e0826b0e0a3da840567fcc2d9" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --089e0826b0e0a3da840567fcc2d9 Content-Type: text/plain; charset="UTF-8" Hi On Wed, Mar 21, 2018 at 5:52 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hi Dave, > I think that this Gnome issue should be addressed after the release of > 3.0. We should create a bug and see the best way to address it after. This > is my proposal, because I am not 100% sure where this application indicator > should live. > If we search the web for application indicators we can see that usually > these are developed by 3rd parties and is are present at the applications > repository, so this might be a side project that need to be undertaken, by > someone in the community or not, but it is not something that should live > inside our repository as it is not really part of the code source and it is > more like a Hack for Gnome. > > The other issues I believe need to be addressed, specially if they are > crippling to the application like when you click it does not start, but if > they are edge cases, we can always release this week and have a new release > in 2 weeks or something with more fixes to these edge case problems. > > I understand that the process of release at this point is a bit cumbersome > and take a lot of time, but if we can get more tests around the new and > old feature we can have more confidence in our code and as a result of that > we can automate some of the steps in order to generate binaries more > frequently. > The problem is that users of Gnome 3.26 and later don't just lose the tray icon, pgAdmin will exit with an error entirely. I've tried just removing that exit() call, but it then takes ages to start, before crashing the gnome shell and leaving you back at the login prompt. There are 2 things we need to avoid here: 1) Shipping with a design that is then radically changed yet again in the next release. This is akin to my concerns about shipping with this runtime and then replacing it with Electron shortly afterwards. 2) Shipping a product that we know will not work for a potentially large percentage of Linux users. Both of those things, particularly the second point, will piss off users and damage our reputation (which is already somewhat battered following the performance issues on Windows). > > Thanks > Joao > > On Wed, Mar 21, 2018 at 12:54 PM Dave Page wrote: > >> Hi >> >> On Wed, Mar 21, 2018 at 4:22 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hello Dave, >>> For number 1: https://blogs.gnome.org/aday/2017/08/31/status-icons- >>> and-gnome/ >>> We might need to build something like: https://itsfoss.com/ >>> best-indicator-applets-ubuntu/ >>> Not sure if it is wise to do it in such a short notice. >>> >> >> Yeah, the problem with the suggested solutions is that they rely on 3rd >> party extensions that aren't "real" packages for the OS, so we can't just >> add a dependency on them. Unfortunately I think this is going to cause >> quite a bit of work to get 3.0 back on track. >> >> >>> >>> Thanks >>> Joao >>> >>> On Wed, Mar 21, 2018 at 11:38 AM Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On 21 Mar 2018 21:05, "Dave Page" wrote: >>>> >>>> We've run into a number of unexpected issues with the v3.0 release that >>>> I think we need to resolve before moving forwards. For the time being, only >>>> patches critical to fix these issues should be committed. >>>> >>>> I'll try to look at 1, though I do have another deadline I need to >>>> meet. >>>> Akshay, can you look at 2 please? >>>> Fahar is already looking at 3. >>>> Khushboo, can you look at 4 please? >>>> >>>> Sure. >>>> >>>> >>>> Thanks all. >>>> >>>> 1) There is no longer a system tray in Gnome 3.26 and later, and thus >>>> the runtime won't initialise in Fedora 27 and later. We need an alternative >>>> for this, either a tray replacement that the RPM can depend on, or better >>>> yet, support whatever it is Gnome expect such apps to use these days. >>>> >>>> 2) Starting a second instance of the app bundle on Mac doesn't always >>>> open a new pgAdmin window as it should. It works fine in the debugger, or >>>> if you start the app with a command like: "/Applications/pgAdmin\ >>>> 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click >>>> the appbundle or use a command like "open /Applications/pgAdmin\ 4.app" >>>> >>>> 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my >>>> copy, but apparently his is a fresh installation. >>>> >>>> 4) On my Windows 7 machine, after running a backup I get no status >>>> window, and see the following in the logs: >>>> >>>> Traceback (most recent call last): >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", >>>> line 209, in run_wsgi >>>> execute(self.server.app) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", >>>> line 197, in execute >>>> application_iter = app(environ, start_response) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1997, in __call__ >>>> return self.wsgi_app(environ, start_response) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1985, in wsgi_app >>>> response = self.handle_exception(e) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1540, in handle_exception >>>> reraise(exc_type, exc_value, tb) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1982, in wsgi_app >>>> response = self.full_dispatch_request() >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1614, in full_dispatch_request >>>> rv = self.handle_user_exception(e) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1517, in handle_user_exception >>>> reraise(exc_type, exc_value, tb) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1612, in full_dispatch_request >>>> rv = self.dispatch_request() >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1598, in dispatch_request >>>> return self.view_functions[rule.endpoint](**req.view_args) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask_login.py", >>>> line 792, in decorated_view >>>> return func(*args, **kwargs) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py", >>>> line 62, in index >>>> return make_response(response=BatchProcess.list()) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py", >>>> line 584, in list >>>> details = desc.details(p.command, args) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py", >>>> line 190, in details >>>> res += html.safe_str(cmd + self.cmd) >>>> AttributeError: 'BackupMessage' object has no attribute 'cmd' >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --089e0826b0e0a3da840567fcc2d9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Wed, Mar 21, 2018 at 5:52 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Dave,
I think that this Gnome issue shou= ld be addressed after the release of 3.0. We should create a bug and see th= e best way to address it after. This is my proposal, because I am not 100% = sure where this application indicator should live.
If we search t= he web for application indicators we can see that usually these are develop= ed by 3rd parties and is are present at the applications repository, so thi= s might be a side project that need to be undertaken, by someone in the com= munity or not, but it is not something that should live inside our reposito= ry as it is not really part of the code source and it is more like a Hack f= or Gnome.

The other issues I believe need to be ad= dressed, specially if they are crippling to the application like when you c= lick it does not start, but if they are edge cases, we can always release t= his week and have a new release in 2 weeks or something with more fixes to = these edge case problems.

I understand that the pr= ocess of release at this point is a bit cumbersome and take a lot of time, = but=C2=A0 if we can get more tests around the new and old feature we can ha= ve more confidence in our code and as a result of that we can automate some= of the steps in order to generate binaries more frequently.

The problem is that users of Gnome 3.26 and l= ater don't just lose the tray icon, pgAdmin will exit with an error ent= irely. I've tried just removing that exit() call, but it then takes age= s to start, before crashing the gnome shell and leaving you back at the log= in prompt.

There are 2 things we need to avoid her= e:

1) Shipping with a design that is then radicall= y changed yet again in the next release. This is akin to my concerns about = shipping with this runtime and then replacing it with Electron shortly afte= rwards.

2) Shipping a product that we know will no= t work for a potentially large percentage of Linux users.

Both of those things, particularly the second point, will piss off = users and damage our reputation (which is already somewhat battered followi= ng the performance issues on Windows).

=C2=A0

Thanks=
Joao
=

On Wed, Mar 21, 2018 at 12:54 PM Dave Page <dpage@pgadmin.org&= gt; wrote:
Hi
<= div class=3D"gmail_extra">
=
On W= ed, Mar 21, 2018 at 4:22 PM, Joao De Almeida Pereira <= jdealmeid= apereira@pivotal.io> wrote:
Hello Dave,
For number 1:=C2=A0htt= ps://blogs.gnome.org/aday/2017/08/31/status-icons-and-gnome/<= /div>
We might need to build something like:=C2=A0https://itsfoss= .com/best-indicator-applets-ubuntu/
Not sure if it is wi= se to do it in such a short notice.

=
Yeah, the problem with the suggested solutions is that t= hey rely on 3rd party extensions that aren't "real" packages = for the OS, so we can't just add a dependency on them. Unfortunately I = think this is going to cause quite a bit of work to get 3.0 back on track.<= /div>
=C2=A0

Thanks
Joao

On Wed, Mar 21, 2018 at 11:38 AM Kh= ushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On 21 Mar 2018 21:05, "Dave Pag= e" <dpage@pg= admin.org> wrote:
We've run into a number of unexpected issues= with the v3.0 release that I think we need to resolve before moving forwar= ds. For the time being, only patches critical to fix these issues should be= committed.

I'll try to look at 1, though I do have = another deadline I need to meet.=C2=A0
Akshay, can you look at 2 = please?
Fahar is already looking at 3.
Khushboo, can yo= u look at 4 please?
Sure.
=

Thank= s all.

1) There is no longer a system tray in Gnom= e 3.26 and later, and thus the runtime won't initialise in Fedora 27 an= d later. We need an alternative for this, either a tray replacement that th= e RPM can depend on, or better yet, support whatever it is Gnome expect suc= h apps to use these days.

2) Starting a second ins= tance of the app bundle on Mac doesn't always open a new pgAdmin window= as it should. It works fine in the debugger, or if you start the app with = a command like: "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4&= quot;. It doesn't work if you double-click the appbundle or use a = command like "open /Applications/pgAdmin\ 4.app"

3) Fahar saw a crash on Windows 7. I couldn't reproduce this o= n my copy, but apparently his is a fresh installation.

=
4) On my Windows 7 machine, after running a backup I get no status win= dow, and see the following in the logs:

= Traceback (most recent call last):
=C2=A0 File "C:\Program F= iles (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py&quo= t;, line 209, in run_wsgi
=C2=A0 =C2=A0 execute(self.server.app)<= /div>
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\si= te-packages\werkzeug\serving.py", line 197, in execute
= =C2=A0 =C2=A0 application_iter =3D app(environ, start_response)
= =C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-package= s\flask\app.py", line 1997, in __call__
=C2=A0 =C2=A0 r= eturn self.wsgi_app(environ, start_response)
=C2=A0 File "C:= \Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py&= quot;, line 1985, in wsgi_app
=C2=A0 =C2=A0 response =3D self.han= dle_exception(e)
=C2=A0 File "C:\Program Files (x86)\pgAdmin= 4\v3\venv\Lib\site-packages\flask\app.py", line 1540, in handle_= exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packa= ges\flask\app.py", line 1982, in wsgi_app
=C2=A0 =C2=A0= response =3D self.full_dispatch_request()
=C2=A0 File "C:\P= rogram Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py&qu= ot;, line 1614, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D sel= f.handle_user_exception(e)
=C2=A0 File "C:\Program Files (x8= 6)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1517, = in handle_user_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_valu= e, tb)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv= \Lib\site-packages\flask\app.py", line 1612, in full_dispatch_req= uest
=C2=A0 =C2=A0 rv =3D self.dispatch_request()
=C2= =A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\<= wbr>flask\app.py", line 1598, in dispatch_request
=C2=A0 =C2= =A0 return self.view_functions[rule.endpoint](**req.view_args)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-pack= ages\flask_login.py", line 792, in decorated_view
=C2= =A0 =C2=A0 return func(*args, **kwargs)
=C2=A0 File "C:\Prog= ram Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py&qu= ot;, line 62, in index
=C2=A0 =C2=A0 return make_response(respons= e=3DBatchProcess.list())
=C2=A0 File "C:\Program Files = (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py", line= 584, in list
=C2=A0 =C2=A0 details =3D desc.details(p.command, a= rgs)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\web\pg= admin\tools\backup\__init__.py", line 190, in details
= =C2=A0 =C2=A0 res +=3D html.safe_str(cmd + self.cmd)
AttributeErr= or: 'BackupMessage' object has no attribute 'cmd'



--
Dave Page
B= log: http://pgsna= ke.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>



--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--089e0826b0e0a3da840567fcc2d9--