MIME-Version: 1.0
In-Reply-To: <01D3E3D9-3947-461D-9B3F-569420327220@enterprisedb.com>
References: 
 <CAG7mmoy=Wd5xHV=e734d4=8pqS7BOKyL8mUdh-5AMfs84Tm6VQ@mail.gmail.com>
 <569759C0.90009@enterprisedb.com>
 <569F47F0.4070106@enterprisedb.com>
 <01D3E3D9-3947-461D-9B3F-569420327220@enterprisedb.com>
Date: Tue, 2 Feb 2016 09:55:26 +0000
Message-ID: 
 <CA+OCxoytmkdf3a-ngUz1r2b_7OU1aC3bCv48T=hofQKM-PYt=A@mail.gmail.com>
Subject: Re: PATCH: Login/Group Role Node
From: Dave Page <dpage@pgadmin.org>
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: Ashesh Vashi <ashesh.vashi@enterprisedb.com>,
 pgadmin-hackers <pgadmin-hackers@postgresql.org>,
 Akshay Joshi <akshay.joshi@enterprisedb.com>
Content-Type: multipart/alternative; boundary=e89a8f642bd83971df052ac680ab
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--e89a8f642bd83971df052ac680ab
Content-Type: text/plain; charset=UTF-8

On Tue, Feb 2, 2016 at 9:22 AM, Murtuza Zabuawala <
murtuza.zabuawala@enterprisedb.com> wrote:

> Hi Ashesh,
>
> I also found that we are not handling group role in macro templates.
>
> Steps to re-produce the issue:
> 1) Create a sample Group Role.
>     name : my_group
>
> Click 'Ok' to create.
>
> 2) Go to privilege tab (in my case Database node)
> - Click on Add button
> - Select my_group (Group) from options
> - grant any priviledges
>
> 3) Go to modified SQL tab
>
> - You will see wrong SQL generated
> GRANT ALL ON DATABASE postgres *TO* my_group WITH GRANT OPTIONS
>
> *Expected SQL:*
> GRANT ALL ON DATABASE postgres *TO GROUP* my_group WITH GRANT OPTIONS
>

Isn't GROUP just a noise word that's there for backwards compatibility with
pre-role releases?


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--e89a8f642bd83971df052ac680ab
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Tue, Feb 2, 2016 at 9:22 AM, Murtuza Zabuawala <span dir=3D"ltr">&lt=
;<a href=3D"mailto:murtuza.zabuawala@enterprisedb.com" target=3D"_blank">mu=
rtuza.zabuawala@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex"><div style=3D"word-wrap:break-word"><div>Hi Ashesh,</div><div=
><br></div><div>I also found that we are not handling group role in macro t=
emplates.</div><div><br></div><div>Steps to re-produce the issue:</div><div=
>1) Create a sample Group Role.</div><div>=C2=A0 =C2=A0 name : my_group</di=
v><div><br></div><div>Click &#39;Ok&#39; to create.</div><div><br></div><di=
v>2) Go to privilege tab (in my case Database node)</div><div>- Click on Ad=
d button</div><div>- Select my_group (Group) from options=C2=A0</div><div>-=
 grant any priviledges</div><div><br></div><div>3) Go to modified SQL tab</=
div><div><br></div><div>- You will see wrong SQL generated</div><div>GRANT =
ALL ON DATABASE postgres <b>TO</b> my_group WITH GRANT OPTIONS</div><div><b=
r></div><div><u>Expected SQL:</u></div><div><div>GRANT ALL ON DATABASE post=
gres <b>TO GROUP</b> my_group WITH GRANT OPTIONS</div></div></div></blockqu=
ote><div><br></div><div>Isn&#39;t GROUP just a noise word that&#39;s there =
for backwards compatibility with pre-role releases?=C2=A0</div></div><br><b=
r clear=3D"all"><div><br></div>-- <br><div class=3D"gmail_signature">Dave P=
age<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">http=
://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a=
 href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enterpri=
sedb.com</a><br>The Enterprise PostgreSQL Company<br></div>
</div></div>

--e89a8f642bd83971df052ac680ab--